From 4289521fba5dd08a32a74c8d9f27fd42f3a26ea4 Mon Sep 17 00:00:00 2001 From: Joe Schmetzer Date: Sun, 17 Nov 2024 13:39:45 +1100 Subject: [PATCH 1/2] Restore public constructors for compatibility CoreMatchers, MatcherAssert, and Matchers had private contructors added to fix javadoc warnings. Unfortunately, this can break existig users of the classes. Fixes #427 --- hamcrest/src/main/java/org/hamcrest/CoreMatchers.java | 5 ++++- hamcrest/src/main/java/org/hamcrest/MatcherAssert.java | 5 ++++- hamcrest/src/main/java/org/hamcrest/Matchers.java | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hamcrest/src/main/java/org/hamcrest/CoreMatchers.java b/hamcrest/src/main/java/org/hamcrest/CoreMatchers.java index 6dadcc52..f00a6e54 100644 --- a/hamcrest/src/main/java/org/hamcrest/CoreMatchers.java +++ b/hamcrest/src/main/java/org/hamcrest/CoreMatchers.java @@ -13,7 +13,10 @@ @SuppressWarnings("UnusedDeclaration") public class CoreMatchers { - private CoreMatchers() { + /** + * Unused + */ + public CoreMatchers() { } /** diff --git a/hamcrest/src/main/java/org/hamcrest/MatcherAssert.java b/hamcrest/src/main/java/org/hamcrest/MatcherAssert.java index 574f4f61..29d3364e 100644 --- a/hamcrest/src/main/java/org/hamcrest/MatcherAssert.java +++ b/hamcrest/src/main/java/org/hamcrest/MatcherAssert.java @@ -6,7 +6,10 @@ */ public class MatcherAssert { - private MatcherAssert() { + /** + * Unused. + */ + public MatcherAssert() { } /** diff --git a/hamcrest/src/main/java/org/hamcrest/Matchers.java b/hamcrest/src/main/java/org/hamcrest/Matchers.java index 714777c2..dcc88366 100644 --- a/hamcrest/src/main/java/org/hamcrest/Matchers.java +++ b/hamcrest/src/main/java/org/hamcrest/Matchers.java @@ -22,7 +22,10 @@ @SuppressWarnings({"unused", "WeakerAccess"}) public class Matchers { - private Matchers() { + /** + * Unused + */ + public Matchers() { } /** From 55f7391662392338e6d3963a90f9569f3dc42ca4 Mon Sep 17 00:00:00 2001 From: Joe Schmetzer Date: Sun, 17 Nov 2024 13:47:04 +1100 Subject: [PATCH 2/2] Update changes with javadoc fixes --- CHANGES.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 367812e1..851be4dc 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -25,7 +25,9 @@ these methods will need to be updated. The following methods are affected: ### Improvements -* Javadoc improvements and cleanup ([PR #420](https://github.com/hamcrest/JavaHamcrest/pull/420)) +* Javadoc improvements and cleanup ([PR #420](https://github.com/hamcrest/JavaHamcrest/pull/420), +[#427](https://github.com/hamcrest/JavaHamcrest/issues/427), +[PR #428](https://github.com/hamcrest/JavaHamcrest/pull/428)) * Derive version from git tags ([PR #419](https://github.com/hamcrest/JavaHamcrest/pull/419)) * Migrate all tests to JUnit Jupiter ([PR #424](https://github.com/hamcrest/JavaHamcrest/pull/424))