Skip to content

Commit ad9ab2c

Browse files
committed
fix some typos in the characteristics descriptions
1 parent 9c91d82 commit ad9ab2c

10 files changed

+19
-8
lines changed

src/main/java/io/github/hapjava/accessories/HomekitAccessory.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,13 @@ public interface HomekitAccessory {
7979
default Collection<Service> getServices() {
8080
return Collections.singleton(new AccessoryInformationService(this));
8181
};
82+
83+
/**
84+
* default implementation which is sufficient if accessory has only one services
85+
*
86+
* @return primary service
87+
*/
88+
default Service getPrimaryService() {
89+
return getServices().iterator().next();
90+
};
8291
}

src/main/java/io/github/hapjava/characteristics/impl/accessoryinformation/IdentifyCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class IdentifyCharacteristic extends BooleanCharacteristic {
1010
public IdentifyCharacteristic(ExceptionalConsumer<Boolean> setter) {
1111
super(
1212
"00000014-0000-1000-8000-0026BB765291",
13-
"identifies the accessory via a physical action on the accessory",
13+
"identifies the accessory",
1414
Optional.empty(),
1515
Optional.of(setter),
1616
Optional.empty(),

src/main/java/io/github/hapjava/characteristics/impl/accessoryinformation/ManufacturerCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class ManufacturerCharacteristic extends StaticStringCharacteristic {
1414
public ManufacturerCharacteristic(Supplier<CompletableFuture<String>> getter) {
1515
super(
1616
"00000020-0000-1000-8000-0026BB765291",
17-
"ame of the manufacturer",
17+
"manufacturer",
1818
Optional.of(getter),
1919
Optional.empty(),
2020
Optional.empty());

src/main/java/io/github/hapjava/characteristics/impl/accessoryinformation/ModelCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class ModelCharacteristic extends StaticStringCharacteristic {
1414
public ModelCharacteristic(Supplier<CompletableFuture<String>> getter) {
1515
super(
1616
"00000021-0000-1000-8000-0026BB765291",
17-
"name of the model",
17+
"model",
1818
Optional.of(getter),
1919
Optional.empty(),
2020
Optional.empty());

src/main/java/io/github/hapjava/characteristics/impl/accessoryinformation/SerialNumberCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class SerialNumberCharacteristic extends StaticStringCharacteristic {
1414
public SerialNumberCharacteristic(Supplier<CompletableFuture<String>> getter) {
1515
super(
1616
"00000030-0000-1000-8000-0026BB765291",
17-
"serial number of the accessory",
17+
"serial number",
1818
Optional.of(getter),
1919
Optional.empty(),
2020
Optional.empty());

src/main/java/io/github/hapjava/characteristics/impl/base/EnumCharacteristic.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ public EnumCharacteristic(
4949
super(
5050
type, "int", description, getter.isPresent(), setter.isPresent(), subscriber, unsubscriber);
5151
this.maxValue = maxValue;
52+
this.getter = getter;
53+
this.setter = setter;
5254
}
5355

5456
/** {@inheritDoc} */

src/main/java/io/github/hapjava/characteristics/impl/windowcovering/CurrentHorizontalTiltAngleCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public CurrentHorizontalTiltAngleCharacteristic(
2424
Runnable unsubscriber) {
2525
super(
2626
"0000006C-0000-1000-8000-0026BB765291",
27-
"current horizontal tilt angel",
27+
"current horizontal tilt angle",
2828
-90,
2929
90,
3030
"arcdegrees",

src/main/java/io/github/hapjava/characteristics/impl/windowcovering/CurrentVerticalTiltAngleCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public CurrentVerticalTiltAngleCharacteristic(
2424
Runnable unsubscriber) {
2525
super(
2626
"0000006E-0000-1000-8000-0026BB765291",
27-
"current vertical tilt angel",
27+
"current vertical tilt angle",
2828
-90,
2929
90,
3030
"arcdegrees",

src/main/java/io/github/hapjava/characteristics/impl/windowcovering/TargetHorizontalTiltAngleCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public TargetHorizontalTiltAngleCharacteristic(
2323
Runnable unsubscriber) {
2424
super(
2525
"000000B2-0000-1000-8000-0026BB765291",
26-
"target horizontal tilt angel",
26+
"target horizontal tilt angle",
2727
-90,
2828
90,
2929
"arcdegrees",

src/main/java/io/github/hapjava/characteristics/impl/windowcovering/TargetVerticalTiltAngleCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public TargetVerticalTiltAngleCharacteristic(
2323
Runnable unsubscriber) {
2424
super(
2525
"0000007D-0000-1000-8000-0026BB765291",
26-
"target vertical tilt angel",
26+
"target vertical tilt angle",
2727
-90,
2828
90,
2929
"arcdegrees",

0 commit comments

Comments
 (0)