Skip to content

Commit c64e5b0

Browse files
authored
Merge pull request #10 from gry79/fix-characteristics
Fix NPE in HoldPositionCharacteristic and null value in serialized characteristics
2 parents a5d9420 + 1b35063 commit c64e5b0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/com/beowulfe/hap/characteristics/BaseCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ protected void setJsonValue(JsonObjectBuilder builder, T value) {
172172
} else if (value instanceof BigDecimal){
173173
builder.add("value", (BigDecimal) value);
174174
} else if (value == null) {
175-
builder.addNull("value");
175+
// Do not add null value, HomeKit cannot handle that
176176
} else {
177177
builder.add("value", value.toString());
178178
}

src/main/java/com/beowulfe/hap/impl/characteristics/windowcovering/HoldPositionCharacteristic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ protected void setValue(Boolean value) throws Exception {
2222
@Override
2323
protected CompletableFuture<Boolean> getValue() {
2424
//Write only
25-
return null;
25+
return CompletableFuture.completedFuture(null);
2626
}
2727

2828
}

0 commit comments

Comments
 (0)