Skip to content

More detailed meargability tests #508

@jakubbortlik

Description

@jakubbortlik

Problem:

The detailed_merge_status in the MR status can only show a single value. This creates a little inconvenience when the MR has both the not_approved and need_rebase attributes. The not_approved takes precedence and the user may take action to ask for approvals. When necessary approvals are granted, the need_rebase value is shown and after rebasing, the approvals may be removed requiring another round of approvals that could have been avoided if the need_rebase populated the value of detailed_merge_status with higher priority than not_approved.

Possible solution

Unfortunately, there's no way of doing this with the REST API, but it would be possible with the GraphQL API which is available as an experimental API in the new client-go library. We could add a GraphQL call to get the results of all the mergegility chechs and show them in the MR status.

Alternatively, we could get all the MR info data via GraphQL. I've never worked with GraphQL however, so I'm not sure what that would actually entail.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions