Merge pull request #338 from sajidanower23/sajid/update-delete-milestone

Update, Delete Milestones

Author: phadej

src/GitHub.hs

@@ -137,14 +137,14 @@ module GitHub (
     -- ** Milestone
     -- | See <https://developer.github.com/v3/issues/milestones/>
     --
-    -- Missing endpoints:
-    --
-    -- * Update a milestone
-    -- * Delete a milestone
     milestonesR,
     milestoneR,
     createMilestone,
     createMilestoneR,
+    updateMilestone,
+    updateMilestoneR,
+    deleteMilestone,
+    deleteMilestoneR,
 
     -- * Organizations
     -- | See <https://developer.github.com/v3/orgs/>

src/GitHub/Data/Milestone.hs

@@ -63,3 +63,26 @@ instance ToJSON NewMilestone where
       where
         notNull (_, Null) = False
         notNull (_, _)    = True
+
+data UpdateMilestone = UpdateMilestone
+  { updateMilestoneTitle       :: !(Maybe Text)
+  , updateMilestoneState       :: !(Maybe Text)
+  , updateMilestoneDescription :: !(Maybe Text)
+  , updateMilestoneDueOn       :: !(Maybe UTCTime)
+  }
+  deriving (Show, Data, Typeable, Eq, Ord, Generic)
+
+instance NFData UpdateMilestone where rnf = genericRnf
+instance Binary UpdateMilestone
+
+
+instance ToJSON UpdateMilestone where
+  toJSON (UpdateMilestone title state desc due) = object $ filter notNull
+      [ "title"       .= title
+      , "state"       .= state
+      , "description" .= desc
+      , "due_on"      .= due
+      ]
+    where
+      notNull (_, Null) = False
+      notNull (_, _)    = True

src/GitHub/Endpoints/Issues/Milestones.hs

@@ -13,6 +13,10 @@ module GitHub.Endpoints.Issues.Milestones (
     milestoneR,
     createMilestone,
     createMilestoneR,
+    updateMilestone,
+    updateMilestoneR,
+    deleteMilestone,
+    deleteMilestoneR,
     module GitHub.Data,
     ) where
 
@@ -54,11 +58,29 @@ milestoneR user repo mid =
     query ["repos", toPathPart user, toPathPart repo, "milestones", toPathPart mid] []
 
 createMilestone :: Auth -> Name Owner -> Name Repo -> NewMilestone -> IO (Either Error Milestone)
-createMilestone auth user repo mst = executeRequest auth $ createMilestoneR user repo mst
+createMilestone auth user repo mlstn = executeRequest auth $ createMilestoneR user repo mlstn
 
 -- | Create a milestone.
 -- See <https://developer.github.com/v3/issues/milestones/#create-a-milestone>
 createMilestoneR :: Name Owner -> Name Repo -> NewMilestone -> Request 'RW Milestone
 createMilestoneR user repo =
     command Post ["repos", toPathPart user, toPathPart repo, "milestones"] . encode
 
+updateMilestone :: Auth -> Name Owner -> Name Repo -> Id Milestone -> UpdateMilestone -> IO (Either Error Milestone)
+updateMilestone auth user repo mid mlstn = executeRequest auth $ updateMilestoneR user repo mid mlstn
+
+-- | Update a milestone.
+-- See <https://developer.github.com/v3/issues/milestones/#update-a-milestone>
+updateMilestoneR :: Name Owner -> Name Repo -> Id Milestone -> UpdateMilestone -> Request 'RW Milestone
+updateMilestoneR user repo mid =
+    command Patch ["repos", toPathPart user, toPathPart repo, "milestones", toPathPart mid ] . encode
+
+deleteMilestone :: Auth -> Name Owner -> Name Repo -> Id Milestone -> IO (Either Error ())
+deleteMilestone auth user repo mid = executeRequest auth $ deleteMilestoneR user repo mid
+
+-- | Delete a milestone.
+-- See <https://developer.github.com/v3/issues/milestones/#delete-a-milestone>
+deleteMilestoneR :: Name Owner -> Name Repo -> Id Milestone -> Request 'RW ()
+deleteMilestoneR user repo mid =
+    command Delete
+        ["repos", toPathPart user, toPathPart repo, "milestones", toPathPart mid] mempty