return http status 0 as this is actually not a server error

startnow65 · startnow65 · commit 0dc031c12dc7 · 2019-04-26T10:24:28.000+02:00
diff --git a/pkg/zappr/client.go b/pkg/zappr/client.go
@@ -145,7 +145,9 @@ func (c *clientImpl) doRequest(req *http.Request) (int, *zapprErrorResponse, err
 	resp, err := c.slingClient.Do(req, nil, zapprErrorResponse)
 
 	if resp == nil {
-		return http.StatusInternalServerError, nil, errwrap.Wrap(ErrZapprServerError, err)
+		// Even though 0 does not seem like a valid http response code
+		// The status would be ignored by any calling code anyway since a non-nil error is returned
+		return 0, nil, errwrap.Wrap(ErrZapprServerError, err)
 	}
 
 	if resp.StatusCode == http.StatusUnauthorized {

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,9 @@ func (c clientImpl) doRequest(req http.Request) (int, *zapprErrorResponse, err`
`145`	`145`	`resp, err := c.slingClient.Do(req, nil, zapprErrorResponse)`
`146`	`146`
`147`	`147`	`if resp == nil {`
`148`		`- return http.StatusInternalServerError, nil, errwrap.Wrap(ErrZapprServerError, err)`
	`148`	`+ // Even though 0 does not seem like a valid http response code`
	`149`	`+ // The status would be ignored by any calling code anyway since a non-nil error is returned`
	`150`	`+ return 0, nil, errwrap.Wrap(ErrZapprServerError, err)`
`149`	`151`	`}`
`150`	`152`
`151`	`153`	`if resp.StatusCode == http.StatusUnauthorized {`