Fix the condition in LookupApi (#861)

mykhailo-kuchma · web-flow · commit ad96dcbd4aff · 2020-05-25T13:27:01.000+03:00
Condition always evaluates to true

Relates-To: OLPEDGE-1989

Signed-off-by: Mykhailo Kuchma &lt;ext-mykhailo.kuchma@here.com&gt;
diff --git a/olp-cpp-sdk-dataservice-read/src/ApiClientLookup.cpp b/olp-cpp-sdk-dataservice-read/src/ApiClientLookup.cpp
@@ -66,7 +66,7 @@ ApiClientLookup::ApiClientResponse ApiClientLookup::LookupApi(
   std::unique_lock<repository::NamedMutex> lock(mutex, std::adopt_lock);
 
   // If we are not planning to go online or access the cache, release the lock.
-  if (options != CacheOnly || options != OnlineOnly) {
+  if (options != CacheOnly && options != OnlineOnly) {
     mutex.lock();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ ApiClientLookup::ApiClientResponse ApiClientLookup::LookupApi(`
`66`	`66`	`std::unique_lock<repository::NamedMutex> lock(mutex, std::adopt_lock);`
`67`	`67`
`68`	`68`	`// If we are not planning to go online or access the cache, release the lock.`
`69`		`- if (options != CacheOnly \|\| options != OnlineOnly) {`
	`69`	`+ if (options != CacheOnly && options != OnlineOnly) {`
`70`	`70`	`mutex.lock();`
`71`	`71`	`}`
`72`	`72`