Address raspberry pi compilation issues. (#807)

Remove porting_config.h.in
Remove unused defines.
Inline make_unique check.
Remove GLOB usage in CMakeLists.txt

Resolves: OLPEDGE-1862

Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>

Author: mykhailo-kuchma

olp-cpp-sdk-core/CMakeLists.txt

@@ -98,9 +98,13 @@ set(OLP_SDK_PLATFORM_HEADERS
     ./include/olp/core/context/Context.h
 )
 
-file(GLOB PORTING_HEADERS
-    "${CMAKE_CURRENT_SOURCE_DIR}/include/olp/core/porting/*.h"
-    "${CMAKE_CURRENT_BINARY_DIR}/include/olp/core/porting/*.h"
+set(OLP_SDK_PORTING_HEADERS
+    ./include/olp/core/porting/deprecated.h
+    ./include/olp/core/porting/export.h
+    ./include/olp/core/porting/make_unique.h
+    ./include/olp/core/porting/platform.h
+    ./include/olp/core/porting/try_emplace.h
+    ./include/olp/core/porting/warning_disable.h
 )
 
 set(OLP_SDK_UTILS_HEADERS
@@ -296,7 +300,7 @@ set(OLP_SDK_CORE_HEADERS
     ${OLP_SDK_GENERATED_HEADERS}
     ${OLP_SDK_HTTP_HEADERS}
     ${OLP_SDK_PLATFORM_HEADERS}
-    ${PORTING_HEADERS}
+    ${OLP_SDK_PORTING_HEADERS}
     ${OLP_SDK_UTILS_HEADERS}
     ${OLP_SDK_LOGGING_HEADERS}
     ${OLP_SDK_THREAD_HEADERS}
@@ -421,7 +425,7 @@ endif()
 # install component
 install (FILES ${OLP_SDK_HTTP_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/http)
 install (FILES ${OLP_SDK_PLATFORM_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/platform)
-install (FILES ${PORTING_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/porting)
+install (FILES ${OLP_SDK_PORTING_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/porting)
 install (FILES ${OLP_SDK_UTILS_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/utils)
 install (FILES ${OLP_SDK_THREAD_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/thread)
 install (FILES ${OLP_SDK_CACHE_HEADERS} DESTINATION ${INCLUDE_DIRECTORY}/olp/core/cache)

olp-cpp-sdk-core/cmake/CompileChecks.cmake

@@ -16,47 +16,17 @@
 # License-Filename: LICENSE
 
 function(porting_do_checks)
-  if (ARGC GREATER 0)
-    set(PATH_TO_INPUT_FILE ${ARGV0}/)
-    list(REMOVE_AT ARGN 0)
-  endif()
-
   include(CheckCXXSourceCompiles)
-  include(TestBigEndian)
-
-  test_big_endian(PORTING_SYSTEM_BIG_ENDIAN)
 
   # run the cxx compile test with c++xx flags and pthreads library
   set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${CMAKE_CXX${CMAKE_CXX_STANDARD}_EXTENSION_COMPILE_OPTION}")
   set(CMAKE_REQUIRED_LIBRARIES ${CMAKE_REQUIRED_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT})
 
-  set(HAVE_STD_OPTIONAL OFF PARENT_SCOPE)
-  check_cxx_source_compiles(
-    "#include <optional>
-    int main() { return *std::make_optional(4); }"
-    HAVE_STD_OPTIONAL)
-
-  set(HAVE_EXPERIMENTAL_OPTIONAL OFF PARENT_SCOPE)
-  check_cxx_source_compiles(
-    "#include <experimental/optional>
-    int main() { return *std::experimental::make_optional(4); }"
-    HAVE_EXPERIMENTAL_OPTIONAL)
-
-  set(HAVE_STD_FILESYSTEM OFF PARENT_SCOPE)
-  check_cxx_source_compiles(
-    "#include <filesystem>
-    int main() { return static_cast<int>(std::filesystem::file_type::directory); }"
-    HAVE_STD_FILESYSTEM)
-
   set(HAVE_PTHREAD_SETNAME_NP OFF PARENT_SCOPE)
   check_cxx_source_compiles(
     "#define _GNU_SOURCE 1
     #include <pthread.h>
     int main() { pthread_t thread; pthread_setname_np(thread, NULL); }"
     HAVE_PTHREAD_SETNAME_NP)
-
-  configure_file(${PATH_TO_INPUT_FILE}porting_config.h.in
-    include/olp/core/porting/porting_config.h
-    @ONLY)
 endfunction(porting_do_checks)
 

olp-cpp-sdk-core/include/olp/core/porting/make_unique.h

@@ -19,10 +19,12 @@
 
 #pragma once
 
-#include <olp/core/porting/porting_config.h>
-
 #include <memory>
 
+#if ((__cplusplus >= 201304L) || (defined(_MSC_VER) && _MSC_VER >= 1800))
+#define HAVE_STD_MAKE_UNIQUE
+#endif
+
 #if !defined(HAVE_STD_MAKE_UNIQUE)
 
 #include <cstdint>

olp-cpp-sdk-core/porting_config.h.in

@@ -71,7 +71,7 @@ class DefaultNetwork final : public Network {
   void LockStatistics(uint8_t bucket_id,
                       std::function<void(Statistics&)> callback);
 
-  std::atomic_uint8_t current_statistics_bucket_;
+  std::atomic<uint8_t> current_statistics_bucket_;
 
   using BucketsContainer = std::unordered_map<uint8_t, Statistics>;
   thread::Atomic<BucketsContainer> buckets_;