Commit checker:fix minor bug,add lower case check (#856)

Now description is mandatory, trick with third line as
ticket reference will not pass.
Also added new feature: checking reference for lower case.

Relates-To: OLPEDGE-1919

Signed-off-by: Yaroslav Stefinko <ext-yaroslav.stefinko@here.com>

Author: ystefinko

scripts/misc/commit_checker.sh

@@ -36,33 +36,41 @@ do
         echo ""
         echo "ERROR: Title is ${current_line_len} length, so it's too long for title. Expect less than 50 chars !"
         echo ""
+        cat commit.log
+        echo "----------------------------------------------"
         echo "Please read following rules:"
         cat scripts/misc/commit_message_recom.txt
-        exit 1
+        exit 6
     fi
     if [ $line -eq 2 ] && [ ${current_line_len} -ne 1 ] ; then
         echo ""
         echo "ERROR: Second line in Commit Message is not zero length !"
         echo ""
+        cat commit.log
+        echo "----------------------------------------------"
         echo "Please read following rules:"
         cat scripts/misc/commit_message_recom.txt
-        exit 1
+        exit 5
     fi
-    if [ $line -eq 3 ] && [ ${current_line_len} -lt 1 ] && [ -n $(cat commit.log| sed -n ${line}p | grep 'See also: ') ] && [ -n $(cat commit.log| sed -n ${line}p | grep 'Relates-To: ') ] && [ -n $(echo ${current_line_len}| grep 'Resolves: ') ] ; then
+    if [ "$line" -eq 3 ] && ( [ "$current_line_len" -le 2 ] || [ -n "$(cat commit.log | sed -n ${line}p | grep 'See also: ')" ] || [ -n "$(cat commit.log | sed -n ${line}p | grep 'Relates-To: ')" ] || [ -n "$(cat commit.log | sed -n ${line}p | grep 'Resolves: ')" ] ) ; then
         echo ""
-        echo "ERROR: No details added to commit message besides title !"
+        echo "ERROR: No details added to commit message besides title and ticket reference!"
         echo ""
+        cat commit.log
+        echo "----------------------------------------------"
         echo "Please read following rules:"
         cat scripts/misc/commit_message_recom.txt
-        exit 1
+        exit 4
     fi
     if [ ${current_line_len} -gt 72 ] ; then
         echo ""
         echo "ERROR: ${current_line_len} chars in ${line}-th line is too long. Any line length must be less than 72 chars !"
         echo ""
+        cat commit.log
+        echo "----------------------------------------------"
         echo "Please read following rules:"
         cat scripts/misc/commit_message_recom.txt
-        exit 1
+        exit 3
     fi
     echo " ${line}-th line is ${current_line_len} chars length . OK."
 done
@@ -71,16 +79,28 @@ relates_to=$(cat commit.log | grep 'Relates-To: ') || true
 resolves=$(cat commit.log | grep 'Resolves: ') || true
 see=$(cat commit.log | grep 'See also: ') || true
 
-echo "Reference like:  ${relates_to} ${resolves} ${see}  was found in commit message. OK."
-
-if [[ -n ${relates_to} || -n ${resolves} || -n ${see} ]] ; then
+# This is verification that we have any of these possible issue references.
+if [ -n "${relates_to}" ] || [ -n "${resolves}"] || [ -n "${see}" ] ; then
+    # This verification is needed for correct Jira linking in Gitlab.
+    if [[ "$(echo ${relates_to}| cut -d":" -f2)" =~ [a-z] ]] || [[ "$(echo ${resolves}| cut -d":" -f2)" =~ [a-z] ]] || [[ "$(echo ${see}| cut -d":" -f2)" =~ [a-z] ]] ; then
+        echo ""
+        echo "ERROR: Commit message contains ticket or issue reference in lower case !"
+        echo ""
+        cat commit.log
+        echo "----------------------------------------------"
+        echo "Please read following rules:"
+        cat scripts/misc/commit_message_recom.txt
+        exit 2
+    fi
     echo ""
-    echo "Commit message contains issue reference. OK."
+    echo "Commit message contains correct issue reference. OK."
     echo ""
 else
     echo ""
     echo "ERROR: Commit message does not contain ticket or issue reference like Relates-To: or Resolves: or See also:  !"
     echo ""
+    cat commit.log
+    echo "----------------------------------------------"
     echo "Please read following rules:"
     cat scripts/misc/commit_message_recom.txt
     exit 1