fix(bot): normalize DRY_RUN handling and default

Signed-off-by: Akshat Kumar <akshat230405@gmail.com>

Author: Akshat8510

.github/scripts/inactivity_unassign.sh

@@ -2,12 +2,22 @@
 set -euo pipefail
 
 # Unified Inactivity Bot (Phase 1 + Phase 2)
-# Supports DRY_RUN=1 mode.
+# Supports DRY_RUN mode:
+#   DRY_RUN = 1 → simulate only (no changes)
+#   DRY_RUN = 0 → real actions
 
 REPO="${REPO:-${GITHUB_REPOSITORY:-}}"
 DAYS="${DAYS:-21}"
 DRY_RUN="${DRY_RUN:-0}"
 
+# Normalize DRY_RUN input ("true"/"false" → 1/0)
+shopt -s nocasematch
+case "$DRY_RUN" in
+  "true")  DRY_RUN=1 ;;
+  "false") DRY_RUN=0 ;;
+esac
+shopt -u nocasematch
+
 if [[ -z "$REPO" ]]; then
   echo "ERROR: REPO environment variable not set."
   exit 1
@@ -17,11 +27,12 @@ echo "------------------------------------------------------------"
 echo " Unified Inactivity Unassign Bot"
 echo " Repo:      $REPO"
 echo " Threshold: $DAYS days"
-echo " Dry Run:   $DRY_RUN"
+echo " DRY_RUN:   $DRY_RUN"
 echo "------------------------------------------------------------"
 
 NOW_TS=$(date +%s)
 
+# Converts GitHub timestamps → epoch
 parse_ts() {
   local ts="$1"
   if date --version >/dev/null 2>&1; then
@@ -31,9 +42,13 @@ parse_ts() {
   fi
 }
 
-ISSUES=$(gh api "repos/$REPO/issues" \
-  --paginate \
-  --jq '.[] | select(.state=="open" and (.assignees | length > 0) and (.pull_request | not)) | .number')
+# Fetch all open issues that have assignees
+ISSUES=$(
+  gh api "repos/$REPO/issues" --paginate \
+    --jq '.[] 
+      | select(.state=="open" and (.assignees|length>0) and (.pull_request|not))
+      | .number'
+)
 
 for ISSUE in $ISSUES; do
   echo "============================================================"
@@ -48,11 +63,13 @@ for ISSUE in $ISSUES; do
   for USER in $ASSIGNEES; do
     echo "  → Checking assignee: $USER"
 
-    # timeline check with cross-repo filtering
+    # Fetch timeline (for PR cross-references)
     TIMELINE=$(gh api \
       -H "Accept: application/vnd.github.mockingbird-preview+json" \
-      "repos/$REPO/issues/$ISSUE/timeline")
+      "repos/$REPO/issues/$ISSUE/timeline"
+    )
 
+    # Filter only PRs from SAME repository
     PR_NUMBERS=$(echo "$TIMELINE" | jq -r --arg repo "$REPO" '
       .[]
       | select(.event == "cross-referenced")
@@ -62,20 +79,20 @@ for ISSUE in $ISSUES; do
     ')
 
     # -------------------------------
-    # PHASE 1 — No PR linked
+    # PHASE 1: ISSUE HAS NO PR
     # -------------------------------
     if [[ -z "$PR_NUMBERS" ]]; then
       AGE_DAYS=$(( (NOW_TS - CREATED_TS) / 86400 ))
       echo "    [INFO] Assigned for: ${AGE_DAYS} days"
 
-      if [[ "$AGE_DAYS" -ge "$DAYS" ]]; then
-        echo "    [PHASE 1 STALE] No PR & stale assignment"
+      if (( AGE_DAYS >= DAYS )); then
+        echo "    [PHASE 1 STALE] No PR linked + stale"
 
-        if [[ "$DRY_RUN" -eq 0 ]]; then
+        if (( DRY_RUN == 0 )); then
           gh issue edit "$ISSUE" --repo "$REPO" --remove-assignee "$USER"
-          echo "    [ACTION] Unassigned $USER (no PR & stale)"
+          echo "    [ACTION] Unassigned $USER"
         else
-          echo "    [DRY RUN] Would unassign $USER (no PR & stale)"
+          echo "    [DRY RUN] Would unassign $USER"
         fi
       else
         echo "    [KEEP] Not stale yet"
@@ -85,13 +102,13 @@ for ISSUE in $ISSUES; do
     fi
 
     # -------------------------------
-    # PHASE 2 — Stale PR detection
+    # PHASE 2: ISSUE HAS PR(s)
     # -------------------------------
     echo "    [INFO] Linked PRs: $PR_NUMBERS"
 
     for PR_NUM in $PR_NUMBERS; do
 
-      # Check PR existence safely
+      # Safe PR check
       if ! PR_STATE=$(gh pr view "$PR_NUM" --repo "$REPO" --json state --jq '.state' 2>/dev/null); then
         echo "    [SKIP] #$PR_NUM is not a valid PR in $REPO"
         continue
@@ -102,23 +119,22 @@ for ISSUE in $ISSUES; do
         continue
       fi
 
-      # Last commit (pagination + last)
+      # Last commit (paginate + last)
       COMMITS=$(gh api "repos/$REPO/pulls/$PR_NUM/commits" --paginate)
-      LAST=$(echo "$COMMITS" | jq -r 'last | (.commit.committer.date // .commit.author.date)')
+      LAST_TS_STR=$(echo "$COMMITS" | jq -r 'last | (.commit.committer.date // .commit.author.date)')
+      LAST_TS=$(parse_ts "$LAST_TS_STR")
 
-      LAST_TS=$(parse_ts "$LAST")
       AGE_DAYS=$(( (NOW_TS - LAST_TS) / 86400 ))
 
-      echo "    [INFO] PR #$PR_NUM → Last commit = $LAST (~${AGE_DAYS} days)"
+      echo "    [INFO] PR #$PR_NUM → Last commit = $LAST_TS_STR (~${AGE_DAYS} days)"
 
-      if [[ "$AGE_DAYS" -ge "$DAYS" ]]; then
-        echo "    [STALE PR] $PR_NUM by $USER is stale"
+      if (( AGE_DAYS >= DAYS )); then
+        echo "    [STALE PR] PR #$PR_NUM is stale"
 
-        if [[ "$DRY_RUN" -eq 0 ]]; then
-          # comment + close + unassign
+        if (( DRY_RUN == 0 )); then
           gh pr close "$PR_NUM" --repo "$REPO"
           gh issue edit "$ISSUE" --repo "$REPO" --remove-assignee "$USER"
-          echo "    [ACTION] Closed PR + unassigned user"
+          echo "    [ACTION] Closed PR + unassigned $USER"
         else
           echo "    [DRY RUN] Would close PR #$PR_NUM + unassign $USER"
         fi
@@ -134,5 +150,5 @@ done
 
 echo "------------------------------------------------------------"
 echo " Unified Inactivity Bot Complete"
-echo " DRY MODE: $DRY_RUN"
+echo " DRY_RUN: $DRY_RUN"
 echo "------------------------------------------------------------"

.github/workflows/bot-inactivity-unassign-phase.yml

@@ -8,7 +8,7 @@ on:
       dry_run:
         description: "Run in dry-run mode (no unassign / close / comment)"
         required: true
-        default: "true"
+        default:  true
         type: boolean
 
 permissions: