bot: unify inactivity unassign logic (Phase 1 + Phase 2)

Signed-off-by: Akshat Kumar <akshat230405@gmail.com>

Author: Akshat8510

.github/scripts/inactivity_unassign.sh

@@ -3,14 +3,14 @@ set -euo pipefail
 
 # Unified Inactivity Bot (Phase 1 + Phase 2)
 # DRY_RUN controls behaviour:
-#   DRY_RUN = 1 → simulate only (no changes, just logs)
-#   DRY_RUN = 0 → real actions (comments, closes, unassigns)
+#   DRY_RUN = 1 -> simulate only (no changes, just logs)
+#   DRY_RUN = 0 -> real actions (comments, closes, unassigns)
 
 REPO="${REPO:-${GITHUB_REPOSITORY:-}}"
 DAYS="${DAYS:-21}"
 DRY_RUN="${DRY_RUN:-0}"
 
-# Normalise DRY_RUN input ("true"/"false" → 1/0, case-insensitive)
+# Normalise DRY_RUN input ("true"/"false" -> 1/0, case-insensitive)
 shopt -s nocasematch
 case "$DRY_RUN" in
   "true")  DRY_RUN=1 ;;
@@ -30,96 +30,105 @@ echo " Threshold $DAYS days"
 echo " DRY_RUN:  $DRY_RUN"
 echo "------------------------------------------------------------"
 
+# current time (epoch seconds)
 NOW_TS=$(date +%s)
 
-# Convert GitHub ISO timestamp → epoch seconds
+# Convert GitHub ISO timestamp -> epoch seconds (works on Linux/BSD)
 parse_ts() {
   local ts="$1"
   if date --version >/dev/null 2>&1; then
-    # GNU date (Linux)
     date -d "$ts" +%s
   else
-    # BSD / macOS
     date -j -f "%Y-%m-%dT%H:%M:%SZ" "$ts" +"%s"
   fi
 }
 
-# Fetch all open issues with assignees (no PRs)
+# Quick gh availability/auth checks
+if ! command -v gh >/dev/null 2>&1; then
+  echo "ERROR: gh CLI not found. Install it and ensure it's on PATH."
+  exit 1
+fi
+
+if ! gh auth status >/dev/null 2>&1; then
+  echo "WARN: gh auth status failed — ensure gh is logged in for non-dry runs."
+fi
+
+# Get list of open issues with assignees (pagination via gh)
 ISSUES=$(
-  gh api "repos/$REPO/issues" --paginate \
-    --jq '.[]
-      | select(.state=="open" and (.assignees | length > 0) and (.pull_request | not))
-      | .number'
+  gh api "repos/$REPO/issues" --paginate --jq '.[] 
+    | select(.state=="open" and (.assignees|length>0) and (.pull_request|not))
+    | .number' 2>/dev/null || true
 )
 
 for ISSUE in $ISSUES; do
   echo "============================================================"
   echo " ISSUE #$ISSUE"
   echo "============================================================"
 
-  ISSUE_JSON=$(gh api "repos/$REPO/issues/$ISSUE")
-  ISSUE_CREATED_AT=$(echo "$ISSUE_JSON" | jq -r '.created_at')
-  ASSIGNEES=$(echo "$ISSUE_JSON" | jq -r '.assignees[].login')
+  ISSUE_JSON=$(gh api "repos/$REPO/issues/$ISSUE" 2>/dev/null || echo "{}")
+  ISSUE_CREATED_AT=$(echo "$ISSUE_JSON" | jq -r '.created_at // empty')
+  ASSIGNEES=$(echo "$ISSUE_JSON" | jq -r '.assignees[]?.login' 2>/dev/null || true)
 
-  echo "  [INFO] Issue created at: $ISSUE_CREATED_AT"
+  echo "  [INFO] Issue created at: ${ISSUE_CREATED_AT:-(unknown)}"
   echo
 
-  # Fetch timeline once (used for assignment events + PR links)
-  TIMELINE=$(
-    gh api \
-      -H "Accept: application/vnd.github.mockingbird-preview+json" \
-      "repos/$REPO/issues/$ISSUE/timeline"
-  )
+  # Fetch timeline once (used for assignment events + PR links).
+  # If gh fails, default to a valid empty JSON array so jq never blocks.
+  TIMELINE=$(gh api -H "Accept: application/vnd.github.mockingbird-preview+json" "repos/$REPO/issues/$ISSUE/timeline" 2>/dev/null || echo "[]")
+  TIMELINE=${TIMELINE:-'[]'}   # defensive default (ensures valid JSON)
+
+  # if there are no assignees, skip (defensive)
+  if [[ -z "${ASSIGNEES// }" ]]; then
+    echo "  [INFO] No assignees for this issue, skipping."
+    echo
+    continue
+  fi
 
   for USER in $ASSIGNEES; do
     echo "  → Checking assignee: $USER"
 
-    # Determine assignment timestamp for this user
-    ASSIGN_EVENT_JSON=$(
-      echo "$TIMELINE" | jq -c --arg user "$USER" '
-        [ .[]
-          | select(.event == "assigned")
-          | select(.assignee.login == $user)
-        ]
-        | last // empty
-      '
-    )
+    # Determine assignment timestamp for this user: find last assigned event for this user
+    # Use here-string to pass TIMELINE into jq (prevents jq from reading stdin unexpectedly).
+    ASSIGN_EVENT_JSON=$(jq -c --arg user "$USER" '
+      [ .[] | select(.event == "assigned") | select(.assignee.login == $user) ] | last // empty' <<<"$TIMELINE" 2>/dev/null || echo "")
 
     if [[ -n "$ASSIGN_EVENT_JSON" && "$ASSIGN_EVENT_JSON" != "null" ]]; then
-      ASSIGNED_AT=$(echo "$ASSIGN_EVENT_JSON" | jq -r '.created_at')
+      ASSIGNED_AT=$(echo "$ASSIGN_EVENT_JSON" | jq -r '.created_at // empty')
       ASSIGN_SOURCE="assignment_event"
     else
-      # Fallback: use issue creation time when no explicit assignment event
-      ASSIGNED_AT="$ISSUE_CREATED_AT"
+      # fallback: use issue creation time
+      ASSIGNED_AT="${ISSUE_CREATED_AT:-}"
       ASSIGN_SOURCE="issue_created_at (no explicit assignment event)"
     fi
 
-    ASSIGNED_TS=$(parse_ts "$ASSIGNED_AT")
-    ASSIGNED_AGE_DAYS=$(( (NOW_TS - ASSIGNED_TS) / 86400 ))
+    # compute assignment age safely (if no timestamp, set to 0)
+    if [[ -n "$ASSIGNED_AT" ]]; then
+      ASSIGNED_TS=$(parse_ts "$ASSIGNED_AT")
+      ASSIGNED_AGE_DAYS=$(( (NOW_TS - ASSIGNED_TS) / 86400 ))
+    else
+      ASSIGNED_AGE_DAYS=0
+    fi
 
     echo "    [INFO] Assignment source: $ASSIGN_SOURCE"
-    echo "    [INFO] Assigned at:      $ASSIGNED_AT (~${ASSIGNED_AGE_DAYS} days ago)"
-
-    # Determine PRs linked to this issue for this user
-    PR_NUMBERS=$(
-      echo "$TIMELINE" | jq -r --arg repo "$REPO" --arg user "$USER" '
-        .[]
-        | select(.event == "cross-referenced")
-        | select(.source.issue.pull_request != null)
-        | select(.source.issue.repository.full_name == $repo)
-        | select(.source.issue.user.login == $user)
-        | .source.issue.number
-      '
-    )
-
-    # ===========================
-    # PHASE 1: ISSUE HAS NO PR(s)
-    # ===========================
-    if [[ -z "$PR_NUMBERS" ]]; then
+    echo "    [INFO] Assigned at:      ${ASSIGNED_AT:-(unknown)} (~${ASSIGNED_AGE_DAYS} days ago)"
+
+    # Determine PRs cross-referenced from the same repo
+    PR_NUMBERS=$(jq -r --arg repo "$REPO" '
+      .[] |
+      select(.event == "cross-referenced") |
+      select(.source.issue.pull_request != null) |
+      select(.source.issue.repository.full_name == $repo) |
+      .source.issue.number' <<<"$TIMELINE" 2>/dev/null || true)
+
+    # Defensive normalization: remove blank lines and spaces
+    PR_NUMBERS=$(echo "$PR_NUMBERS" | sed '/^[[:space:]]*$/d' || true)
+
+    # PHASE 1: no PRs attached
+    if [[ -z "${PR_NUMBERS// }" ]]; then
       echo "    [INFO] Linked PRs: none"
 
       if (( ASSIGNED_AGE_DAYS >= DAYS )); then
-        echo "    [RESULT] Phase 1 → stale assignment (>= $DAYS days, no PR)"
+        echo "    [RESULT] Phase 1 -> stale assignment (>= $DAYS days, no PR)"
 
         if (( DRY_RUN == 0 )); then
           MESSAGE=$(
@@ -133,51 +142,53 @@ If you'd like to continue working on this later, feel free to get re-assigned or
 EOF
           )
 
-          gh issue comment "$ISSUE" --repo "$REPO" --body "$MESSAGE"
-          gh issue edit "$ISSUE" --repo "$REPO" --remove-assignee "$USER"
+          gh issue comment "$ISSUE" --repo "$REPO" --body "$MESSAGE" || echo "WARN: couldn't post comment (gh error)"
+          gh issue edit "$ISSUE" --repo "$REPO" --remove-assignee "$USER" || echo "WARN: couldn't remove assignee (gh error)"
           echo "    [ACTION] Commented and unassigned @$USER from issue #$ISSUE"
         else
           echo "    [DRY RUN] Would comment + unassign @$USER from issue #$ISSUE (Phase 1 stale)"
         fi
       else
-        echo "    [RESULT] Phase 1 → no PR linked but not stale (< $DAYS days) → KEEP"
+        echo "    [RESULT] Phase 1 -> no PR linked but not stale (< $DAYS days) -> KEEP"
       fi
 
       echo
       continue
     fi
 
-    # ===========================
-    # PHASE 2: ISSUE HAS PR(s)
-    # ===========================
+    # PHASE 2: process linked PR(s)
     echo "    [INFO] Linked PRs: $PR_NUMBERS"
-
     PHASE2_TOUCHED=0
 
     for PR_NUM in $PR_NUMBERS; do
-      # Safe PR existence check
+      # Safe check: verify PR exists in this repo
       if ! PR_STATE=$(gh pr view "$PR_NUM" --repo "$REPO" --json state --jq '.state' 2>/dev/null); then
         echo "    [SKIP] #$PR_NUM is not a valid PR in $REPO"
         continue
       fi
 
+      # log state and continue only if open
       echo "    [INFO] PR #$PR_NUM state: $PR_STATE"
-
       if [[ "$PR_STATE" != "OPEN" ]]; then
         echo "    [SKIP] PR #$PR_NUM is not open"
         continue
       fi
 
-      COMMITS_JSON=$(gh api "repos/$REPO/pulls/$PR_NUM/commits" --paginate)
-      LAST_TS_STR=$(echo "$COMMITS_JSON" | jq -r 'last | (.commit.committer.date // .commit.author.date)')
-      LAST_TS=$(parse_ts "$LAST_TS_STR")
-      PR_AGE_DAYS=$(( (NOW_TS - LAST_TS) / 86400 ))
+      # get last commit time safely
+      COMMITS_JSON=$(gh api "repos/$REPO/pulls/$PR_NUM/commits" --paginate 2>/dev/null || echo "[]")
+      LAST_TS_STR=$(jq -r 'last? | (.commit.committer.date // .commit.author.date) // empty' <<<"$COMMITS_JSON" 2>/dev/null || echo "")
+      if [[ -n "$LAST_TS_STR" ]]; then
+        LAST_TS=$(parse_ts "$LAST_TS_STR")
+        PR_AGE_DAYS=$(( (NOW_TS - LAST_TS) / 86400 ))
+      else
+        PR_AGE_DAYS=$((DAYS+1))   # treat as stale if we cannot find commit timestamp
+      fi
 
-      echo "    [INFO] PR #$PR_NUM last commit: $LAST_TS_STR (~${PR_AGE_DAYS} days ago)"
+      echo "    [INFO] PR #$PR_NUM last commit: ${LAST_TS_STR:-(unknown)} (~${PR_AGE_DAYS} days ago)"
 
       if (( PR_AGE_DAYS >= DAYS )); then
         PHASE2_TOUCHED=1
-        echo "    [RESULT] Phase 2 → PR #$PR_NUM is stale (>= $DAYS days since last commit)"
+        echo "    [RESULT] Phase 2 -> PR #$PR_NUM is stale (>= $DAYS days since last commit)"
 
         if (( DRY_RUN == 0 )); then
           MESSAGE=$(
@@ -190,21 +201,20 @@ You're very welcome to open a new PR or ask to be re-assigned when you're ready
 EOF
           )
 
-          gh pr comment "$PR_NUM" --repo "$REPO" --body "$MESSAGE"
-          gh pr close "$PR_NUM" --repo "$REPO"
-          gh issue edit "$ISSUE" --repo "$REPO" --remove-assignee "$USER"
-
+          gh pr comment "$PR_NUM" --repo "$REPO" --body "$MESSAGE" || echo "WARN: couldn't comment on PR"
+          gh pr close "$PR_NUM" --repo "$REPO" || echo "WARN: couldn't close PR"
+          gh issue edit "$ISSUE" --repo "$REPO" --remove-assignee "$USER" || echo "WARN: couldn't remove assignee"
           echo "    [ACTION] Commented on PR #$PR_NUM, closed it, and unassigned @$USER from issue #$ISSUE"
         else
           echo "    [DRY RUN] Would comment, close PR #$PR_NUM, and unassign @$USER from issue #$ISSUE"
         fi
       else
-        echo "    [INFO] PR #$PR_NUM is active (< $DAYS days) → KEEP"
+        echo "    [INFO] PR #$PR_NUM is active (< $DAYS days) -> KEEP"
       fi
     done
 
     if (( PHASE2_TOUCHED == 0 )); then
-      echo "    [RESULT] Phase 2 → all linked PRs active or not applicable → KEEP"
+      echo "    [RESULT] Phase 2 -> all linked PRs active or not applicable -> KEEP"
     fi
 
     echo