diff --git a/.github/workflows/bot-verified-commits.yml b/.github/workflows/bot-verified-commits.yml index 03c87c3d6..b5583b339 100644 --- a/.github/workflows/bot-verified-commits.yml +++ b/.github/workflows/bot-verified-commits.yml @@ -2,7 +2,7 @@ name: PythonBot - Verify PR Commits on: pull_request_target: - types: [opened, synchronize] + types: [opened, synchronize, ready_for_review] permissions: contents: read @@ -16,6 +16,7 @@ concurrency: jobs: verify-commits: runs-on: ubuntu-latest + if: github.event.pull_request.draft == false steps: - name: Harden the runner (Audit all outbound calls) diff --git a/.github/workflows/merge-conflict-bot.yml b/.github/workflows/merge-conflict-bot.yml index af6d61426..52fe93ac8 100644 --- a/.github/workflows/merge-conflict-bot.yml +++ b/.github/workflows/merge-conflict-bot.yml @@ -2,7 +2,7 @@ name: PythonBot - Check Merge Conflicts on: pull_request_target: - types: [opened, synchronize, reopened] + types: [opened, synchronize, reopened, ready_for_review] permissions: contents: read @@ -15,6 +15,7 @@ concurrency: jobs: check-conflicts: runs-on: ubuntu-latest + if: github.event.pull_request.draft == false steps: - name: Harden the runner (Audit all outbound calls) diff --git a/.github/workflows/pr-check-changelog.yml b/.github/workflows/pr-check-changelog.yml index e61d7dd69..f6afeb21b 100644 --- a/.github/workflows/pr-check-changelog.yml +++ b/.github/workflows/pr-check-changelog.yml @@ -3,7 +3,7 @@ name: 'PR Changelog Check' on: workflow_dispatch: pull_request: - types: [opened, reopened, edited, synchronize] + types: [opened, reopened, edited, synchronize, ready_for_review] permissions: contents: read @@ -11,6 +11,7 @@ permissions: jobs: changelog-check: runs-on: ubuntu-latest + if: github.event_name == 'workflow_dispatch' || github.event.pull_request.draft == false steps: - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 with: diff --git a/.github/workflows/pr-check-title.yml b/.github/workflows/pr-check-title.yml index ee9a46987..705fa60f2 100644 --- a/.github/workflows/pr-check-title.yml +++ b/.github/workflows/pr-check-title.yml @@ -7,6 +7,7 @@ on: - reopened - edited - synchronize + - ready_for_review defaults: run: @@ -25,7 +26,7 @@ jobs: title-check: name: Title Check runs-on: ubuntu-latest - if: ${{ !github.event.pull_request.base.repo.fork }} + if: ${{ !github.event.pull_request.base.repo.fork && (github.event_name == 'workflow_dispatch' || github.event.pull_request.draft == false) }} permissions: checks: write statuses: write diff --git a/CHANGELOG.md b/CHANGELOG.md index c7649ff5a..9fcbc9f70 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1. ### Added - Added __str__() to CustomFixedFee and updated examples and tests accordingly. +- Added draft PR check to prevent bots from triggering on draft pull requests - Added a github template for good first issues - Added `.github/workflows/bot-assignment-check.yml` to limit non-maintainers to 2 concurrent issue assignments. - Added all missing fields to __str__() method and updated `test_tokem_info.py`