better

Author: hsayed21

Class/MarkerFinder.cs

@@ -5,27 +5,25 @@ namespace SQLBakVersion.Class
 {
     public interface IMarkerFinder
     {
-        long FindMarker(FileStream fileStream);
+        bool FindMarker(FileStream fileStream);
     }
 
     public class MarkerFinder : IMarkerFinder
     {
         private const int MsciMarkerSize = 4;
         private const int MsciMarker = 0x4943534D; // "MSCI" marker Little Endian
 
-        public long FindMarker(FileStream fileStream)
+        public bool FindMarker(FileStream fileStream)
         {
             byte[] markerBytes = new byte[4];
             while (fileStream.Read(markerBytes, 0, MsciMarkerSize) == 4)
             {
                 if (BitConverter.ToInt32(markerBytes, 0) == MsciMarker)
                 {
-                    fileStream.Seek(-MsciMarkerSize, SeekOrigin.Current);
-                    return fileStream.Position;
+                    return true;
                 }
-                fileStream.Seek(-2, SeekOrigin.Current);
             }
-            return -1; // Marker not found
+            return false;
         }
     }
 }

Class/SQLVersion.cs

@@ -28,13 +28,12 @@ public string GetVersion(string filePath)
                         return "Invalid Tape Header";
                     }
 
-                    var versionOffset = _markerFinder.FindMarker(fs);
-                    if (versionOffset == -1)
+                    if (!_markerFinder.FindMarker(fs))
                     {
                         return "MSCI marker not found";
                     }
 
-                    return _versionDeterminer.DetermineVersion(fs, versionOffset);
+                    return _versionDeterminer.DetermineVersion(fs);
                 }
             }
             catch (Exception ex)

Class/VersionDeterminer.cs

@@ -5,18 +5,17 @@ namespace SQLBakVersion.Class
 {
     public interface IVersionDeterminer
     {
-        string DetermineVersion(FileStream fileStream, long MSCIOffset);
+        string DetermineVersion(FileStream fileStream);
     }
 
     public class VersionDeterminer : IVersionDeterminer
     {
 
-        public string DetermineVersion(FileStream fileStream, long MSCIOffset)
+        public string DetermineVersion(FileStream fileStream)
         {
-            long versionOffset = MSCIOffset + 172;
             byte[] versionBytes = new byte[2];
 
-            fileStream.Seek(versionOffset, SeekOrigin.Begin);
+            fileStream.Seek(168, SeekOrigin.Current);
             fileStream.Read(versionBytes, 0, 2);
             Int16 dbVersion = BitConverter.ToInt16(versionBytes, 0);