Skip to content

Conversation

@neha222222
Copy link

Issue - #7880

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! I think it works great in general but can have weird edge cases, like if the splits are defined with directories that are not the split names, e.g.

- split: train
  path: "my-dir/*.png"
- split: test
  path: "my-other-dir/*.png"

maybe a more robust way could be to check whether each split has exactly one label, and that the labels of every split are different. wdyt ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants