Fix needless_borrow warnings

Signed-off-by: Joseph Livesey <joseph.livesey@btp.works>

Author: suchapalaver

families/battleship/src/bin/cli.rs

@@ -154,7 +154,7 @@ fn run() -> Result<(), Error> {
             let col = fire_matches.value_of("col").expect("Column is required!");
             let wait = parse_wait_flag(fire_matches)?;
 
-            let game = client.get_game(&name)?;
+            let game = client.get_game(name)?;
             let board = Board::load_or_generate(format!("{}-{}", name, key), &game.ships)?;
             let (reveal_space, reveal_nonce) = game.get_last_fire_row_col(&board)?;
 

families/battleship/src/client.rs

@@ -86,7 +86,7 @@ impl<'a> BattleshipClient<'a> {
             let mut contents = String::new();
             file.read_to_string(&mut contents)?;
             Box::new(
-                Secp256k1PrivateKey::from_hex(&contents.trim())
+                Secp256k1PrivateKey::from_hex(contents.trim())
                     .map_err(|e| format_err!("{}", e))?,
             )
         };

families/battleship/src/game.rs

@@ -332,7 +332,7 @@ impl Board {
     pub fn render(&self) -> String {
         self.spaces
             .iter()
-            .map(|ref row| row.iter().collect::<String>())
+            .map(|row| row.iter().collect::<String>())
             .collect::<Vec<_>>()
             .join("\n")
     }

families/battleship/src/handler.rs

@@ -248,15 +248,15 @@ impl BattleshipTransactionHandler {
             // Every turn after the first should hit this, unless the client tried giving
             // incomplete information.
             (Some(lfc), Some(lfr), Some(rs), Some(rn)) => {
-                let last_row = game::parse_row(&lfr).ok_or_else(|| {
+                let last_row = game::parse_row(lfr).ok_or_else(|| {
                     ApplyError::InvalidTransaction(format!("Invalid row {}", row))
                 })?;
 
-                let last_col = game::parse_column(&lfc).ok_or_else(|| {
+                let last_col = game::parse_column(lfc).ok_or_else(|| {
                     ApplyError::InvalidTransaction(format!("Invalid column {}", column))
                 })?;
 
-                let space_hash = game::get_space_hash(rs, &rn);
+                let space_hash = game::get_space_hash(rs, rn);
 
                 let hashed_board = match game.state.as_ref() {
                     "P1-NEXT" => &game.hashed_board_1,

families/block_info/sawtooth_block_info/src/payload.rs

@@ -40,7 +40,7 @@ pub struct BlockInfoPayload {
 
 impl BlockInfoPayload {
     pub fn new(payload_data: &[u8]) -> Result<BlockInfoPayload, ApplyError> {
-        let payload: BlockInfoTxn = parse_protobuf(&payload_data)?;
+        let payload: BlockInfoTxn = parse_protobuf(payload_data)?;
 
         {
             let next_block = payload.get_block();

families/settings/sawtooth_settings/src/handler.rs

@@ -116,13 +116,13 @@ impl TransactionHandler for SettingsTransactionHandler {
         match settings_payload.get_action() {
             SettingsPayload_Action::PROPOSE => apply_proposal(
                 &auth_keys,
-                &public_key,
+                public_key,
                 settings_payload.get_data(),
                 context,
             ),
             SettingsPayload_Action::VOTE => apply_vote(
                 &auth_keys,
-                &public_key,
+                public_key,
                 settings_payload.get_data(),
                 context,
             ),
@@ -255,7 +255,7 @@ fn unpack_data<T>(data: &[u8]) -> Result<T, ApplyError>
 where
     T: protobuf::Message,
 {
-    Message::parse_from_bytes(&data).map_err(|err| {
+    Message::parse_from_bytes(data).map_err(|err| {
         warn!(
             "Invalid error: Failed to unmarshal SettingsTransaction: {:?}",
             err

families/smallbank/smallbank_rust/src/handler.rs

@@ -102,7 +102,7 @@ impl TransactionHandler for SmallbankTransactionHandler {
 }
 
 fn unpack_payload(payload: &[u8]) -> Result<SmallbankTransactionPayload, ApplyError> {
-    Message::parse_from_bytes(&payload).map_err(|err| {
+    Message::parse_from_bytes(payload).map_err(|err| {
         warn!(
             "Invalid transaction: Failed to unmarshal SmallbankTransaction: {:?}",
             err
@@ -260,7 +260,7 @@ fn apply_amalgamate(
 }
 
 fn unpack_account(account_data: &[u8]) -> Result<Account, ApplyError> {
-    Message::parse_from_bytes(&account_data).map_err(|err| {
+    Message::parse_from_bytes(account_data).map_err(|err| {
         warn!(
             "Invalid transaction: Failed to unmarshal Account: {:?}",
             err

perf/intkey_workload/src/intkey_transformer.rs

@@ -103,7 +103,7 @@ impl<'a> IntKeyTransformer<'a> {
                 .collect(),
         );
 
-        let payload_bytes = self.payload_to_cbor_bytes(&payload)?;
+        let payload_bytes = self.payload_to_cbor_bytes(payload)?;
 
         let mut sha = Sha512::new();
         sha.input(payload_bytes.as_slice());

perf/sawtooth_perf/src/workload.rs

@@ -234,7 +234,7 @@ pub fn form_request_from_batchlist(
 
     if let Some(ref basic_auth) = *basic_auth {
         req.headers_mut()
-            .set(Authorization(Basic::from_str(&basic_auth)?));
+            .set(Authorization(Basic::from_str(basic_auth)?));
     }
 
     Ok((req, batch_id))

perf/smallbank_workload/src/smallbank_transformer.rs

@@ -105,12 +105,12 @@ impl<'a> SBPayloadTransformer<'a> {
         let elapsed = Instant::now().elapsed();
         txn_header.set_nonce(format!("{}{}", elapsed.as_secs(), elapsed.subsec_nanos()));
 
-        let addresses = protobuf::RepeatedField::from_vec(make_addresses(&payload));
+        let addresses = protobuf::RepeatedField::from_vec(make_addresses(payload));
 
         txn_header.set_inputs(addresses.clone());
         txn_header.set_outputs(addresses);
 
-        let dependencies = protobuf::RepeatedField::from_vec(self.get_dependencies(&payload));
+        let dependencies = protobuf::RepeatedField::from_vec(self.get_dependencies(payload));
         txn_header.set_dependencies(dependencies);
 
         let payload_bytes = payload.clone().write_to_bytes()?;
@@ -127,7 +127,7 @@ impl<'a> SBPayloadTransformer<'a> {
         let header_bytes = txn_header.write_to_bytes()?;
 
         let signature = self.signer.sign(&header_bytes.to_vec())?;
-        self.add_signature_if_create_account(&payload, signature.clone());
+        self.add_signature_if_create_account(payload, signature.clone());
 
         txn.set_header(header_bytes);
         txn.set_header_signature(signature);