Skip to content

Commit e7178ec

Browse files
committed
test(clickhouse): enable xpassing tpch and tpcds tests
1 parent 513cc1f commit e7178ec

File tree

2 files changed

+1
-29
lines changed

2 files changed

+1
-29
lines changed

ibis/backends/tests/tpc/ds/test_queries.py

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2066,11 +2066,6 @@ def test_40(catalog_sales, catalog_returns, warehouse, item, date_dim):
20662066

20672067

20682068
@tpc_test("ds")
2069-
@pytest.mark.notyet(
2070-
["clickhouse"],
2071-
raises=ClickHouseDatabaseError,
2072-
reason="correlated subqueries don't exist in clickhouse",
2073-
)
20742069
def test_41(item):
20752070
return (
20762071
item.view()
@@ -3417,7 +3412,6 @@ def test_64(
34173412

34183413

34193414
@tpc_test("ds", result_is_empty=True)
3420-
@pytest.mark.notyet(["clickhouse"], reason="Broken")
34213415
def test_65(store, item, store_sales, date_dim):
34223416
sa = (
34233417
store_sales.join(
@@ -4110,14 +4104,7 @@ def _sales(
41104104

41114105

41124106
@tpc_test("ds")
4113-
@pytest.mark.notyet(["clickhouse"], raises=AssertionError, reason="incorrect result")
4114-
def test_76(
4115-
store_sales,
4116-
item,
4117-
date_dim,
4118-
web_sales,
4119-
catalog_sales,
4120-
):
4107+
def test_76(store_sales, item, date_dim, web_sales, catalog_sales):
41214108
def _sales(
41224109
sales, customer_sk, sold_date, item_sk, channel, col_name, ext_sales_price
41234110
):

ibis/backends/tests/tpc/h/test_queries.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ def test_01(lineitem):
4040
return q
4141

4242

43-
@pytest.mark.notyet(
44-
["clickhouse"],
45-
raises=ClickHouseDatabaseError,
46-
reason="correlated subqueries don't exist in clickhouse",
47-
)
4843
@tpc_test("h")
4944
def test_02(part, supplier, partsupp, nation, region):
5045
"""Minimum Cost Supplier Query (Q2)"""
@@ -633,11 +628,6 @@ def test_19(lineitem, part):
633628
return q
634629

635630

636-
@pytest.mark.notyet(
637-
["clickhouse"],
638-
raises=ClickHouseDatabaseError,
639-
reason="correlated subqueries don't exist in clickhouse",
640-
)
641631
@tpc_test("h")
642632
def test_20(supplier, nation, partsupp, part, lineitem):
643633
"""Potential Part Promotion Query (Q20)
@@ -728,11 +718,6 @@ def test_21(supplier, lineitem, orders, nation):
728718
return q.limit(100)
729719

730720

731-
@pytest.mark.notyet(
732-
["clickhouse"],
733-
raises=ClickHouseDatabaseError,
734-
reason="correlated subqueries don't exist in clickhouse",
735-
)
736721
@tpc_test("h")
737722
def test_22(customer, orders):
738723
"""Global Sales Opportunity Query (Q22)

0 commit comments

Comments
 (0)