From 2d4fb648beaeabe31b024b83d390cd30911b7d82 Mon Sep 17 00:00:00 2001 From: Julien Robert Date: Fri, 21 Feb 2025 16:56:57 +0100 Subject: [PATCH 1/3] refactor!: promote codespace instead of gitpod --- .github/ISSUE_TEMPLATE/release-tracker.md | 1 - .gitpod.Dockerfile | 14 ---- .gitpod.yml | 56 -------------- .gitpod/readme.md | 75 ------------------- docs/docs/01-welcome/02-install.md | 3 +- .../version-v0.26/01-welcome/02-install.md | 2 +- ignite/cmd/cmd.go | 5 -- ignite/internal/analytics/analytics.go | 2 - ignite/pkg/cosmosfaucet/try_retrieve.go | 2 +- ignite/pkg/gitpod/gitpod.go | 25 ------- ignite/pkg/matomo/matomo.go | 6 +- ignite/version/version.go | 6 -- readme.md | 18 ++--- 13 files changed, 14 insertions(+), 201 deletions(-) delete mode 100644 .gitpod.Dockerfile delete mode 100644 .gitpod.yml delete mode 100644 .gitpod/readme.md delete mode 100644 ignite/pkg/gitpod/gitpod.go diff --git a/.github/ISSUE_TEMPLATE/release-tracker.md b/.github/ISSUE_TEMPLATE/release-tracker.md index 808dd30d0a..20492fee45 100644 --- a/.github/ISSUE_TEMPLATE/release-tracker.md +++ b/.github/ISSUE_TEMPLATE/release-tracker.md @@ -42,7 +42,6 @@ versions of cli to guarantee that no regression is introduced --> - [ ] Update [`changelog.md`](https://github.com/ignite/cli/blob/main/changelog.md) - [ ] Update [`readme.md](https://github.com/ignite/cli/blob/main/readme.md): - [ ] Version matrix. - - [ ] Link to Gitpod with a URL to the newly released stable version. - [ ] Update docs site: - [ ] Add new release tag to [`docs/versioned_docs`](https://github.com/ignite/cli/tree/main/docs/versioned_docs). - [ ] After changes to docs site are deployed, check [docs.ignite.com/](https://docs.ignite.com/) is updated. diff --git a/.gitpod.Dockerfile b/.gitpod.Dockerfile deleted file mode 100644 index 4e7c4f9f3f..0000000000 --- a/.gitpod.Dockerfile +++ /dev/null @@ -1,14 +0,0 @@ -FROM gitpod/workspace-full - -# Go -ENV GO_VERSION=1.23.6 -ENV GOPATH=$HOME/go-packages -ENV GOROOT=$HOME/go -ENV PATH=$GOROOT/bin:$GOPATH/bin:$PATH -RUN curl -fsSL https://dl.google.com/go/go${GO_VERSION}.linux-amd64.tar.gz | tar xzs && printf '%s\n' 'export GOPATH=/workspace/go' 'export PATH=$GOPATH/bin:$PATH' > $HOME/.bashrc.d/300-go - -# GH CLI -RUN brew install gh - -# NPM -RUN npm install -g npm@7.10.0 diff --git a/.gitpod.yml b/.gitpod.yml deleted file mode 100644 index 8a083268b7..0000000000 --- a/.gitpod.yml +++ /dev/null @@ -1,56 +0,0 @@ -image: - file: .gitpod.Dockerfile - -checkoutLocation: "ignite" - -workspaceLocation: "./ignite/.gitpod" - -tasks: - - name: Open the Readme - command: gp open readme.md - - - name: Setup - - init: | - ## - ## install Ignite CLI - make -C /workspace/ignite install - - command: | - ## - # configure env vars. - echo " - export VITE_CUSTOM_URL=$(gp url) - export CHISEL_ADDR=$(gp url 7575) - export RPC_ADDRESS=$(gp url 26657):443 - export API_ADDRESS=$(gp url 1317) - " >> ~/.bashrc && source ~/.bashrc - - echo " - export VITE_API_COSMOS=${API_ADDRESS} - export VITE_API_TENDERMINT=${RPC_ADDRESS} - export VITE_WS_TENDERMINT=${RPC_ADDRESS/https/wss}/websocket - " >> ~/.bashrc && source ~/.bashrc - - ## - # cd into the .gitpod dir. - cd .gitpod - - ## - # print a welcome message. - clear && printf '\e[3J' - echo -e " - This terminal has the \033[1mignite\033[0m binary already installed and ready to go. - - " - -ports: - - port: 1317 - - port: 26657 - visibility: public - - port: 26659 - visibility: public - - port: 8080 - - port: 7575 - visibility: public - - port: 4500 diff --git a/.gitpod/readme.md b/.gitpod/readme.md deleted file mode 100644 index c56fe5dcf7..0000000000 --- a/.gitpod/readme.md +++ /dev/null @@ -1,75 +0,0 @@ -# Welcome to Ignite CLI ✨ - -Ignite CLI is an easy-to-use CLI tool for creating sovereign blockchains. Blockchains created with Ignite CLI use Cosmos SDK, the world's most widely used blockchain application framework. - -In this browser-based development environment, the terminal window is in the lower part of the window. The `ignite` binary is pre-installed and ready to use on the command line. - -## Quick start - -To create a blockchain and start a node in development: - -```bash -ignite scaffold chain example - -cd example - -ignite chain serve -``` - -## Next steps - -📺 **[Introduction to Ignite CLI](https://www.youtube.com/watch?v=5RqAIE0b8Kw)**: Watch an introductory video to learn about Ignite CLI. - -🧑‍🏫 **[Developer Guide](https://docs.ignite.com/guide)**: Learn by building a simple IBC-enabled module, nameservice, or a decentralized exchange (DEX). - -📕 **Ignite CLI Documentation]()**: Explore the features of Ignite CLI. - -📚 [Cosmos SDK Documentation](https://docs.cosmos.network): Learn about the framework for building application-specific blockchains. - -⭐️ [Ignite CLI on Github](https://github.com/ignite/cli): Submit an issue or contribute to the source code. - -## Ignite CLI features - -* Scaffold modules, messages, types with CRUD operations, IBC packets, and more -* Start a blockchain node in development with live reloading -* Connect to other blockchains with a built-in IBC relayer -* Use automatically generated TypeScript clients and Vuex stores to interact with your blockchain -* Use the Vue 3 web app template with a set of UI components to build your custom web application - -## Install Ignite CLI locally - -You can install Ignite using [HomeBrew](https://formulae.brew.sh/formula/ignite) on macOS and GNU/Linux: - -```sh -brew install ignite -``` - -Or using Snap on GNU/Linux: - -```sh -snap install ignite --classic -``` - -Or manually using the following command: - -```sh -curl https://get.ignite.com/cli | bash -``` - -The latest `ignite` binary is downloaded from the project repo and installed in `/usr/local/bin`. Learn more about [installing Ignite CLI](https://docs.ignite.com/welcome/install). - -## Stay in touch - -Ignite CLI is a free and open source product maintained by [Ignite](https://ignite.com). Follow us on [Twitter](https://twitter.com/ignite) to get the latest updates. - -## Community - -Ignite CLI is a free and open source product maintained by [Ignite](https://ignite.com). Here's where you can find us. Stay in touch. - -* [ignite.com website](https://ignite.com) -* [@ignite on Twitter](https://twitter.com/ignite) -* [ignite.com/blog](https://ignite.com/blog) -* [Ignite Discord](https://discord.gg/ignite) -* [Ignite YouTube](https://www.youtube.com/@ignitehq) -* [Ignite docs](https://docs.ignite.com) -* [Ignite jobs](https://ignite.com/careers) diff --git a/docs/docs/01-welcome/02-install.md b/docs/docs/01-welcome/02-install.md index 26eff5a354..50af550c5d 100644 --- a/docs/docs/01-welcome/02-install.md +++ b/docs/docs/01-welcome/02-install.md @@ -5,8 +5,7 @@ description: Steps to install Ignite CLI on your local computer. # Install Ignite CLI -You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based Gitpod IDE or you can install Ignite CLI on your -local computer. +You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based IDE or you can install Ignite CLI on your local computer. ## Prerequisites diff --git a/docs/versioned_docs/version-v0.26/01-welcome/02-install.md b/docs/versioned_docs/version-v0.26/01-welcome/02-install.md index 9fa22fbb07..3c17027de5 100644 --- a/docs/versioned_docs/version-v0.26/01-welcome/02-install.md +++ b/docs/versioned_docs/version-v0.26/01-welcome/02-install.md @@ -5,7 +5,7 @@ description: Steps to install Ignite CLI on your local computer. # Install Ignite CLI -You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based Gitpod IDE or you can install Ignite CLI on your +You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based IDE or you can install Ignite CLI on your local computer. ## Prerequisites diff --git a/ignite/cmd/cmd.go b/ignite/cmd/cmd.go index 38f4cc1a76..a6630bc6d4 100644 --- a/ignite/cmd/cmd.go +++ b/ignite/cmd/cmd.go @@ -18,7 +18,6 @@ import ( uilog "github.com/ignite/cli/v29/ignite/pkg/cliui/log" "github.com/ignite/cli/v29/ignite/pkg/dircache" "github.com/ignite/cli/v29/ignite/pkg/errors" - "github.com/ignite/cli/v29/ignite/pkg/gitpod" "github.com/ignite/cli/v29/ignite/pkg/goenv" "github.com/ignite/cli/v29/ignite/pkg/gomodulepath" "github.com/ignite/cli/v29/ignite/version" @@ -259,10 +258,6 @@ func deprecated() []*cobra.Command { } func checkNewVersion(cmd *cobra.Command) { - if gitpod.IsOnGitpod() { - return - } - ctx, cancel := context.WithTimeout(cmd.Context(), checkVersionTimeout) defer cancel() diff --git a/ignite/internal/analytics/analytics.go b/ignite/internal/analytics/analytics.go index ca0e8779df..5c13367036 100644 --- a/ignite/internal/analytics/analytics.go +++ b/ignite/internal/analytics/analytics.go @@ -13,7 +13,6 @@ import ( "github.com/spf13/cobra" "github.com/ignite/cli/v29/ignite/config" - "github.com/ignite/cli/v29/ignite/pkg/gitpod" "github.com/ignite/cli/v29/ignite/pkg/matomo" "github.com/ignite/cli/v29/ignite/pkg/randstr" "github.com/ignite/cli/v29/ignite/pkg/sentry" @@ -89,7 +88,6 @@ func SendMetric(wg *sync.WaitGroup, cmd *cobra.Command) { Uname: versionInfo.Uname, CWD: versionInfo.CWD, BuildFromSource: versionInfo.BuildFromSource, - IsGitPod: gitpod.IsOnGitpod(), IsCI: getIsCI(), } diff --git a/ignite/pkg/cosmosfaucet/try_retrieve.go b/ignite/pkg/cosmosfaucet/try_retrieve.go index c8197a34cc..c4172e3a22 100644 --- a/ignite/pkg/cosmosfaucet/try_retrieve.go +++ b/ignite/pkg/cosmosfaucet/try_retrieve.go @@ -101,7 +101,7 @@ func guessFaucetURLs(rpcAddress string) ([]*url.URL, error) { }{ {"4500", "", "."}, {"", "faucet", "."}, - {"", "4500", "-"}, // Gitpod uses port number as sub domain name. + {"", "4500", "-"}, } // creating guesses addresses by basing RPC address. diff --git a/ignite/pkg/gitpod/gitpod.go b/ignite/pkg/gitpod/gitpod.go deleted file mode 100644 index 3ce73c8002..0000000000 --- a/ignite/pkg/gitpod/gitpod.go +++ /dev/null @@ -1,25 +0,0 @@ -package gitpod - -import ( - "bytes" - "context" - "os" - "strings" - - "github.com/ignite/cli/v29/ignite/pkg/cmdrunner/exec" - "github.com/ignite/cli/v29/ignite/pkg/cmdrunner/step" -) - -// IsOnGitpod reports whether if running on Gitpod or not. -func IsOnGitpod() bool { - return os.Getenv("GITPOD_WORKSPACE_ID") != "" -} - -func URLForPort(ctx context.Context, port string) (string, error) { - buf := bytes.Buffer{} - if err := exec.Exec(ctx, []string{"gp", "url", port}, exec.StepOption(step.Stdout(&buf))); err != nil { - return "", err - } - - return strings.TrimSpace(buf.String()), nil -} diff --git a/ignite/pkg/matomo/matomo.go b/ignite/pkg/matomo/matomo.go index d7e095f5c8..66ce8b10d2 100644 --- a/ignite/pkg/matomo/matomo.go +++ b/ignite/pkg/matomo/matomo.go @@ -53,8 +53,8 @@ type ( // 1 = internal ON not supported at present | 0 = internal OFF. Dimension2 uint `url:"dimension2"` - // Dimension3 is gitpod (0 or 1). - // 1 = isGitpod ON | 0 = isGitpod OFF. + // Dimension3 is deprecated. + // Should always be 0. Dimension3 uint `url:"dimension3"` // Dimension4 ignite version @@ -116,7 +116,6 @@ type ( CWD string ScaffoldType string BuildFromSource bool - IsGitPod bool IsCI bool } ) @@ -221,7 +220,6 @@ func (c Client) SendMetric(sessionID string, metric Metric) error { Second: now.Second(), Dimension1: 0, Dimension2: formatBool(metric.IsCI), - Dimension3: formatBool(metric.IsGitPod), Dimension4: metric.Version, Dimension6: metric.ConfigVersion, Dimension7: metric.Cmd, diff --git a/ignite/version/version.go b/ignite/version/version.go index efd6eaa509..62f589b09e 100644 --- a/ignite/version/version.go +++ b/ignite/version/version.go @@ -8,7 +8,6 @@ import ( "path" "runtime" "runtime/debug" - "strconv" "strings" "text/tabwriter" @@ -21,7 +20,6 @@ import ( "github.com/ignite/cli/v29/ignite/pkg/cosmosbuf" "github.com/ignite/cli/v29/ignite/pkg/cosmosver" "github.com/ignite/cli/v29/ignite/pkg/errors" - "github.com/ignite/cli/v29/ignite/pkg/gitpod" "github.com/ignite/cli/v29/ignite/pkg/xexec" ) @@ -49,7 +47,6 @@ type Info struct { Arch string Uname string CWD string - IsGitpod bool BuildFromSource bool } @@ -163,8 +160,6 @@ func Long(ctx context.Context) (string, error) { write("Your cwd", info.CWD) } - write("Is on Gitpod", strconv.FormatBool(info.IsGitpod)) - if err := w.Flush(); err != nil { return "", err } @@ -239,7 +234,6 @@ func GetInfo(ctx context.Context) (Info, error) { info.OS = runtime.GOOS info.Arch = runtime.GOARCH info.GoVersion = strings.TrimSpace(goVersionBuf.String()) - info.IsGitpod = gitpod.IsOnGitpod() info.BuildFromSource = fromSource() if cwd, err := os.Getwd(); err == nil { diff --git a/readme.md b/readme.md index b1ab401ef8..940e3bb8d6 100644 --- a/readme.md +++ b/readme.md @@ -93,12 +93,12 @@ The instructions for installing Ignite CLI manually and configuring your system
View development setup instructions -#### Supported Operating Systems: +#### Supported Operating Systems - GNU/Linux - macOS -#### Install Go: +#### Install Go 1. Install the latest version of Go. 2. Download the release suitable for your system. @@ -106,7 +106,7 @@ The instructions for installing Ignite CLI manually and configuring your system **Note:** We recommend not using `brew` to install Go. -#### Add the Go bin Directory to Your PATH: +#### Add the Go bin Directory to Your PATH 1. Edit your `~/.bashrc` file and add the following line: @@ -120,7 +120,7 @@ The instructions for installing Ignite CLI manually and configuring your system source ~/.bashrc ``` -#### Remove Existing Ignite CLI Installations: +#### Remove Existing Ignite CLI Installations 1. Remove the Ignite CLI binary: @@ -132,13 +132,13 @@ The instructions for installing Ignite CLI manually and configuring your system 2. Repeat the step until all Ignite CLI installations are removed. -#### Install Ignite CLI: +#### Install Ignite CLI ```sh curl https://get.ignite.com/cli! | bash ``` -#### Clone the Ignite CLI Repo: +#### Clone the Ignite CLI Repo 1. Clone the repository: @@ -152,13 +152,13 @@ curl https://get.ignite.com/cli! | bash cd cli ``` -#### Run make install: +#### Run make install ```sh make install ``` -#### Verify Your Ignite CLI Version: +#### Verify Your Ignite CLI Version ```sh ignite version @@ -166,7 +166,7 @@ ignite version
-Alternatively, you can open Ignite CLI directly in your web browser via [Gitpod](https://gitpod.io/#https://github.com/ignite/cli). +Alternatively, you can open Ignite CLI directly in your web browser via [GitHub Codespaces](https://github.com/features/codespaces): [Open in GitHub Codespaces](https://github.dev/ignite/cli). ## Documentation From a07798b05aa834e45dd32bdda3ab73ffafdf1b68 Mon Sep 17 00:00:00 2001 From: Julien Robert Date: Fri, 21 Feb 2025 16:59:39 +0100 Subject: [PATCH 2/3] cl --- changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.md b/changelog.md index 9e93168613..ee3d34ffa3 100644 --- a/changelog.md +++ b/changelog.md @@ -51,6 +51,7 @@ - [#4361](https://github.com/ignite/cli/pull/4361) Remove unused `KeyPrefix` method - [#4384](https://github.com/ignite/cli/pull/4384) Compare genesis params into chain genesis tests - [#4463](https://github.com/ignite/cli/pull/4463) Run `chain simulation` with any simulation test case +- [#4533](https://github.com/ignite/cli/pull/4533) Promote GitHub codespace instead of Gitpod ### Fixes From 1c4b79baf04def7ca0c3ae22251cad020d204535 Mon Sep 17 00:00:00 2001 From: Julien Robert Date: Fri, 21 Feb 2025 17:01:09 +0100 Subject: [PATCH 3/3] revert --- docs/versioned_docs/version-v0.26/01-welcome/02-install.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/versioned_docs/version-v0.26/01-welcome/02-install.md b/docs/versioned_docs/version-v0.26/01-welcome/02-install.md index 3c17027de5..9fa22fbb07 100644 --- a/docs/versioned_docs/version-v0.26/01-welcome/02-install.md +++ b/docs/versioned_docs/version-v0.26/01-welcome/02-install.md @@ -5,7 +5,7 @@ description: Steps to install Ignite CLI on your local computer. # Install Ignite CLI -You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based IDE or you can install Ignite CLI on your +You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based Gitpod IDE or you can install Ignite CLI on your local computer. ## Prerequisites