diactric fix

Author: ANKUR DWIVEDI

imagekitio/url.py

@@ -85,7 +85,6 @@ def build_url(self, options: dict) -> str:
             private_key = options.get("private_key")
             expiry_timestamp = self.get_signature_timestamp(expire_seconds)
             url_signature = self.get_signature(
-                self,
                 private_key=private_key,
                 url=url_object.geturl(),
                 url_endpoint=url_endpoint,
@@ -130,11 +129,11 @@ def get_signature_timestamp(expiry_seconds: int = None) -> int:
         return current_timestamp + expiry_seconds
 
     @staticmethod
-    def get_signature(self, private_key, url, url_endpoint, expiry_timestamp: int) -> str:
+    def get_signature(private_key, url, url_endpoint, expiry_timestamp: int) -> str:
         last_slash_pos = url.rfind('/')
         question_mark_pos = url.find('?', last_slash_pos)
         path = url[last_slash_pos + 1:question_mark_pos] if question_mark_pos != -1 else url[last_slash_pos + 1:]
-        encoded_path = self.encode_string_if_required(self,path)
+        encoded_path = Url.encode_string_if_required(path)
         encoded_url = url[:last_slash_pos + 1] + encoded_path + url[question_mark_pos:] if question_mark_pos != -1 else url[:last_slash_pos + 1] + encoded_path
         url = encoded_url
         print(url)
@@ -225,5 +224,5 @@ def has_more_than_ascii(s):
         return any(ord(char) > 127 for char in s)
 
     @staticmethod
-    def encode_string_if_required(self,s):
-        return quote(s) if self.has_more_than_ascii(s) else s
+    def encode_string_if_required(s):
+        return quote(s) if Url.has_more_than_ascii(s) else s

tests/test_generate_url.py

@@ -407,21 +407,21 @@ def test_generate_url_with_all_params(self):
     def test_get_signature_with_100_expire_seconds(self):
         url = "https://test-domain.com/test-endpoint/tr:w-100/test-signed-url.png"
         signature = self.client.url_obj.get_signature(
-            self,"private_key_test", url, "https://test-domain.com/test-endpoint/", 100
+            "private_key_test", url, "https://test-domain.com/test-endpoint/", 100
         )
         self.assertEqual(signature, "5e5037a31a7121cbe2964e220b4338cc6e1ba66d")
 
     def test_get_signature_without_expire_seconds(self):
         url = "https://test-domain.com/test-endpoint/tr:w-100/test-signed-url.png"
         signature = self.client.url_obj.get_signature(
-           self, "private_key_test", url, "https://test-domain.com/test-endpoint/", 0
+           "private_key_test", url, "https://test-domain.com/test-endpoint/", 0
         )
         self.assertEqual(signature, "41b3075c40bc84147eb71b8b49ae7fbf349d0f00")
 
     def test_get_signature_without_expire_seconds_without_slash(self):
         url = "https://test-domain.com/test-endpoint/tr:w-100/test-signed-url.png"
         signature = self.client.url_obj.get_signature(
-            self,"private_key_test", url, "https://test-domain.com/test-endpoint", 0
+            "private_key_test", url, "https://test-domain.com/test-endpoint", 0
         )
         self.assertEqual(signature, "41b3075c40bc84147eb71b8b49ae7fbf349d0f00")