Skip to content

Commit cbeb0e6

Browse files
authored
Merge pull request #16 from KhushbooMer/pending-comment-fix
added fixes for pending comments
2 parents 483404f + 17a7846 commit cbeb0e6

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

imagekitio/file.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,8 +460,9 @@ def create_folder(
460460
"""Create folder by provided folderName and parentFolderPath as an options"""
461461
url = "{}/v1/folder".format(URL.API_BASE_URL)
462462
headers = self.request.create_headers()
463+
headers.update({"Content-Type": "application/json"})
463464
formatted_data = (
464-
request_formatter(options.__dict__) if options is not None else dict()
465+
dumps(request_formatter(options.__dict__)) if options is not None else dict()
465466
)
466467
resp = self.request.request(
467468
method="Post", url=url, headers=headers, data=formatted_data
@@ -484,8 +485,9 @@ def delete_folder(
484485
"""Delete folder by provided folderPath as an options"""
485486
url = "{}/v1/folder".format(URL.API_BASE_URL)
486487
headers = self.request.create_headers()
488+
headers.update({"Content-Type": "application/json"})
487489
formatted_data = (
488-
request_formatter(options.__dict__) if options is not None else dict()
490+
dumps(request_formatter(options.__dict__)) if options is not None else dict()
489491
)
490492
resp = self.request.request(
491493
method="Delete", url=url, headers=headers, data=formatted_data

tests/test_folder_ops.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def test_create_folder_succeeds(self):
8787
)
8888
self.assertEqual("http://test.com/v1/folder", responses.calls[0].request.url)
8989
self.assertEqual(
90-
"folderName=folder_name&parentFolderPath=%2Ftest",
90+
'{"folderName": "folder_name", "parentFolderPath": "/test"}',
9191
responses.calls[0].request.body,
9292
)
9393

@@ -169,7 +169,7 @@ def test_delete_folder_succeeds(self):
169169
resp.response_metadata.__dict__,
170170
)
171171
self.assertEqual("http://test.com/v1/folder", responses.calls[0].request.url)
172-
self.assertEqual("folderPath=%2FfolderName", responses.calls[0].request.body)
172+
self.assertEqual('{"folderPath": "/folderName"}', responses.calls[0].request.body)
173173

174174

175175
class TestCopyFolder(ClientTestCase):

0 commit comments

Comments
 (0)