Skip to content

Commit 468e1ed

Browse files
committed
don't duplicate contributing universes in sidenav
1 parent b1b41e6 commit 468e1ed

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

app/controllers/application_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def cache_contributable_universe_ids
159159
cache_current_user_content
160160

161161
@contributable_universe_ids ||= if user_signed_in?
162-
current_user.contributable_universe_ids + @current_user_content.fetch('Universe', []).map(&:id)
162+
current_user.contributable_universe_ids
163163
else
164164
[]
165165
end

app/views/layouts/_sidenav.html.erb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
</a>
1818
<div class="collapsible-body blue lighten-1">
1919
<ul>
20-
<%# TODO: we should use a cache here %>
21-
<% (@current_user_content.fetch('Universe', []) + current_user.contributable_universes).sort_by(&:name).each do |universe| %>
20+
<% @current_user_content.fetch('Universe', []).sort_by(&:name).each do |universe| %>
2221
<li>
2322
<%= link_to "?universe=#{universe.id}", class: 'waves-effect' do %>
2423
<i class="material-icons <%= Universe.text_color %>">

0 commit comments

Comments
 (0)