Clean up sonar warnings (#593)

Co-authored-by: Timea <4144203+timea-solid@users.noreply.github.com>

Author: acoburn

access-grant/src/main/java/com/inrupt/client/accessgrant/AccessCredentialQuery.java

@@ -32,10 +32,6 @@
  */
 public class AccessCredentialQuery<T extends AccessCredential> {
 
-    private static final URI SOLID_ACCESS_GRANT = URI.create("SolidAccessGrant");
-    private static final URI SOLID_ACCESS_REQUEST = URI.create("SolidAccessRequest");
-    private static final URI SOLID_ACCESS_DENIAL = URI.create("SolidAccessDenial");
-
     private final Set<URI> purposes;
     private final Set<String> modes;
     private final URI resource;
@@ -199,7 +195,7 @@ public Builder recipient(final URI recipient) {
          * @param clazz the credential type
          * @return the query object
          */
-        public <T extends AccessCredential> AccessCredentialQuery build(final Class<T> clazz) {
+        public <T extends AccessCredential> AccessCredentialQuery<T> build(final Class<T> clazz) {
             return new AccessCredentialQuery<T>(builderResource, builderCreator, builderRecipient, purposes, modes,
                     clazz);
         }

access-grant/src/main/java/com/inrupt/client/accessgrant/AccessGrantClient.java

@@ -168,6 +168,7 @@ private AccessGrantClient(final Client client, final ClientCache<URI, Metadata>
         this.config = Objects.requireNonNull(config, "config may not be null!");
         this.metadataCache = Objects.requireNonNull(metadataCache, "metadataCache may not be null!");
         this.jsonService = ServiceProvider.getJsonService();
+        LOGGER.debug("Initializing Access Grant client with issuer: {}", config.getIssuer());
     }
 
     /**

jena/src/test/java/com/inrupt/client/jena/JenaBodyPublishersTest.java

@@ -32,8 +32,8 @@
 import java.util.HashMap;
 import java.util.Map;
 
-import org.apache.jena.graph.Factory;
 import org.apache.jena.graph.Graph;
+import org.apache.jena.graph.GraphMemFactory;
 import org.apache.jena.query.Dataset;
 import org.apache.jena.query.DatasetFactory;
 import org.apache.jena.rdf.model.Model;
@@ -121,7 +121,7 @@ void testOfUpdateRequestPublisher() throws IOException, InterruptedException {
 
     @Test
     void testOfGraphPublisher() throws IOException, InterruptedException {
-        graph = Factory.createDefaultGraph();
+        graph = GraphMemFactory.createDefaultGraph();
 
         graph.add(JenaTestModel.S_NODE, JenaTestModel.P_NODE, JenaTestModel.O_NODE);
         graph.add(JenaTestModel.S1_NODE, JenaTestModel.P1_NODE, JenaTestModel.O1_NODE);

openid/src/main/java/com/inrupt/client/openid/OpenIdSession.java

@@ -242,12 +242,12 @@ public void reset() {
     public CompletionStage<Optional<Credential>> authenticate(final Authenticator auth,
             final Request request, final Set<String> algorithms) {
         return auth.authenticate(this, request, algorithms)
-                .thenApply(credential -> {
-                    if (credential != null) {
+                .thenApply(cred -> {
+                    if (cred != null) {
                         LOGGER.debug("Setting cache entry for request: {}", request.uri());
-                        requestCache.put(cacheKey(request.uri()), credential);
+                        requestCache.put(cacheKey(request.uri()), cred);
                     }
-                    return Optional.ofNullable(credential);
+                    return Optional.ofNullable(cred);
                 });
     }
 

solid/src/main/java/com/inrupt/client/solid/SolidNonRDFSource.java

@@ -66,6 +66,7 @@ public SolidNonRDFSource(final URI identifier, final String contentType, final I
      *
      * @return the metadata
      */
+    @Override
     public Metadata getMetadata() {
         return metadata;
     }