Skip to content

Commit 2beaa36

Browse files
stofrobocoder
authored andcommitted
Improve the CI setup
- add jobs for PHP 8.4 and 8.5 - add the env variables expected by the MinkSelenium2Driver testsuite to rely on the upstream skipping of unsupported tests based on the tested Selenium version.
1 parent 981db08 commit 2beaa36

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,11 @@ jobs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
15-
selenium: [ '2.53.1', '3.141.59' ]
16-
php: [ '7.2', '7.3', '7.4', '8.0', '8.1' ]
15+
selenium: [ '3.141.59' ]
16+
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
17+
include:
18+
- selenium: '2.53.1'
19+
php: 'latest'
1720
fail-fast: false
1821

1922
steps:
@@ -48,9 +51,7 @@ jobs:
4851
- name: Run Mink tests
4952
run: |
5053
sed -i "s~vendor/~../../../vendor/~" vendor/behat/mink-selenium2-driver/phpunit.xml.dist
51-
# remove test excludes once https://github.com/minkphp/MinkSelenium2Driver/pull/354 Selenium 3 issues are fixed
52-
if [ "${{ matrix.selenium }}" = "3.141.59" ]; then
53-
vendor/bin/phpunit --exclude-group none --no-coverage -v -c vendor/behat/mink-selenium2-driver --filter '^(?!Behat\\Mink\\Tests\\Driver\\(?:Basic\\IFrameTest::testIFrame|Js\\ChangeEventTest::testSetValueChangeEvent.*|Js\\WindowTest::testWindow|Custom\\TimeoutTest::testInvalidTimeoutSettingThrowsException|Js\\EventsTest::testRightClick)$)'
54-
else
55-
vendor/bin/phpunit --exclude-group none --no-coverage -v -c vendor/behat/mink-selenium2-driver
56-
fi
54+
vendor/bin/phpunit --exclude-group none --no-coverage -v -c vendor/behat/mink-selenium2-driver
55+
env:
56+
SELENIUM_VERSION: ${{ matrix.selenium }}
57+
WEB_FIXTURES_BROWSER: firefox

0 commit comments

Comments
 (0)