Fix the upload tests in CI #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of `TEST_MACHINE_BASE_PATH` expects to find the `mink/driver-testsuite` in the vendor folder of the selenium2-driver package. As the CI installs both packages side by side, it needs to configure it explicitly.
Member
|
@stof No worries. Thanks for the PRs. |
Contributor
Author
|
this did not fix the failing tests. Something more might be missing. |
Contributor
|
@stof , The You can use the Docker compose-based version from the current build config: https://github.com/minkphp/MinkSelenium2Driver/blob/master/.github/workflows/tests.yml#L89C11-L89C109 |
Contributor
Author
|
@aik099 given that the mink/driver-testsuite is installed as a sibling of the driver in this CI setup (as both are installed as dependencies), I don't think we can use the docker compose setup of the driver repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
TEST_MACHINE_BASE_PATHexpects to find themink/driver-testsuitein the vendor folder of the selenium2-driver package. As the CI installs both packages side by side, it needs to configure it explicitly.Follow-up of #144 which was merged before I had a chance to look at failing tests.