docs: add descriptions and plan-time validation for enterprise team org data sources/resources

- add top-level Description to enterprise team org data source and resource
- add ValidateDiagFunc to required fields and drop runtime empty checks
- add Description and validation to enterprise teams listing data source

Author: github-actions[bot]

github/data_source_github_enterprise_team_organizations.go

@@ -2,27 +2,30 @@ package github
 
 import (
 	"context"
-	"fmt"
 	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func dataSourceGithubEnterpriseTeamOrganizations() *schema.Resource {
 	return &schema.Resource{
+		Description: "Lists organizations assigned to a GitHub enterprise team.",
 		ReadContext: dataSourceGithubEnterpriseTeamOrganizationsRead,
 
 		Schema: map[string]*schema.Schema{
 			"enterprise_slug": {
-				Type:        schema.TypeString,
-				Required:    true,
-				Description: "The slug of the enterprise.",
+				Type:             schema.TypeString,
+				Required:         true,
+				Description:      "The slug of the enterprise.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.All(validation.StringIsNotWhiteSpace, validation.StringIsNotEmpty)),
 			},
 			"enterprise_team": {
-				Type:        schema.TypeString,
-				Required:    true,
-				Description: "The slug or ID of the enterprise team.",
+				Type:             schema.TypeString,
+				Required:         true,
+				Description:      "The slug or ID of the enterprise team.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.All(validation.StringIsNotWhiteSpace, validation.StringIsNotEmpty)),
 			},
 			"organization_slugs": {
 				Type:        schema.TypeSet,
@@ -39,12 +42,6 @@ func dataSourceGithubEnterpriseTeamOrganizationsRead(ctx context.Context, d *sch
 	client := meta.(*Owner).v3client
 	enterpriseSlug := strings.TrimSpace(d.Get("enterprise_slug").(string))
 	enterpriseTeam := strings.TrimSpace(d.Get("enterprise_team").(string))
-	if enterpriseSlug == "" {
-		return diag.FromErr(fmt.Errorf("enterprise_slug must not be empty"))
-	}
-	if enterpriseTeam == "" {
-		return diag.FromErr(fmt.Errorf("enterprise_team must not be empty"))
-	}
 	orgs, err := listEnterpriseTeamOrganizations(ctx, client, enterpriseSlug, enterpriseTeam)
 	if err != nil {
 		return diag.FromErr(err)

github/data_source_github_enterprise_teams.go

@@ -2,22 +2,24 @@ package github
 
 import (
 	"context"
-	"fmt"
 	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func dataSourceGithubEnterpriseTeams() *schema.Resource {
 	return &schema.Resource{
+		Description: "Lists all GitHub enterprise teams in an enterprise.",
 		ReadContext: dataSourceGithubEnterpriseTeamsRead,
 
 		Schema: map[string]*schema.Schema{
 			"enterprise_slug": {
-				Type:        schema.TypeString,
-				Required:    true,
-				Description: "The slug of the enterprise.",
+				Type:             schema.TypeString,
+				Required:         true,
+				Description:      "The slug of the enterprise.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.All(validation.StringIsNotWhiteSpace, validation.StringIsNotEmpty)),
 			},
 			"teams": {
 				Type:        schema.TypeList,
@@ -65,9 +67,6 @@ func dataSourceGithubEnterpriseTeams() *schema.Resource {
 func dataSourceGithubEnterpriseTeamsRead(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
 	client := meta.(*Owner).v3client
 	enterpriseSlug := strings.TrimSpace(d.Get("enterprise_slug").(string))
-	if enterpriseSlug == "" {
-		return diag.FromErr(fmt.Errorf("enterprise_slug must not be empty"))
-	}
 	teams, err := listEnterpriseTeams(ctx, client, enterpriseSlug)
 	if err != nil {
 		return diag.FromErr(err)

github/resource_github_enterprise_team_organizations.go

@@ -11,10 +11,12 @@ import (
 	githubv3 "github.com/google/go-github/v67/github"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func resourceGithubEnterpriseTeamOrganizations() *schema.Resource {
 	return &schema.Resource{
+		Description:   "Manages organization assignments for a GitHub enterprise team.",
 		CreateContext: resourceGithubEnterpriseTeamOrganizationsCreateOrUpdate,
 		ReadContext:   resourceGithubEnterpriseTeamOrganizationsRead,
 		UpdateContext: resourceGithubEnterpriseTeamOrganizationsCreateOrUpdate,
@@ -23,16 +25,18 @@ func resourceGithubEnterpriseTeamOrganizations() *schema.Resource {
 
 		Schema: map[string]*schema.Schema{
 			"enterprise_slug": {
-				Type:        schema.TypeString,
-				Required:    true,
-				ForceNew:    true,
-				Description: "The slug of the enterprise.",
+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				Description:      "The slug of the enterprise.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.All(validation.StringIsNotWhiteSpace, validation.StringIsNotEmpty)),
 			},
 			"enterprise_team": {
-				Type:        schema.TypeString,
-				Required:    true,
-				ForceNew:    true,
-				Description: "The slug or ID of the enterprise team.",
+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				Description:      "The slug or ID of the enterprise team.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.All(validation.StringIsNotWhiteSpace, validation.StringIsNotEmpty)),
 			},
 			"organization_slugs": {
 				Type:        schema.TypeSet,