Skip to content

Commit aa3a5e5

Browse files
harp-intelCopilot
andauthored
fix missing xlsx brief sheet (#583)
* fix missing xlsx brief sheet Signed-off-by: Harper, Jason M <jason.m.harper@intel.com> * Update internal/common/common.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Harper, Jason M <jason.m.harper@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 4f25b6c commit aa3a5e5

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

cmd/report/report.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ func runCmd(cmd *cobra.Command, args []string) error {
359359
SummaryTableName: benchmarkSummaryTableName,
360360
SummaryBeforeTableName: SpeedBenchmarkTableName,
361361
InsightsFunc: insightsFunc,
362+
SystemSummaryTableName: SystemSummaryTableName,
362363
}
363364

364365
report.RegisterHTMLRenderer(DIMMTableName, dimmTableHTMLRenderer)

internal/common/common.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,11 @@ type ReportingCommand struct {
9191
Tables []table.TableDefinition
9292
ScriptParams map[string]string
9393
SummaryFunc SummaryFunc
94-
SummaryTableName string
94+
SummaryTableName string // e.g., the benchmark or telemetry summary table
9595
SummaryBeforeTableName string // the name of the table that the summary table should be placed before in the report
9696
InsightsFunc InsightsFunc
9797
AdhocFunc AdhocFunc
98+
SystemSummaryTableName string // Optional: Only affects xlsx format reports. If set, the table with this name will be used as the "Brief" sheet in the xlsx report. If empty or unset, no "Brief" sheet is generated.
9899
}
99100

100101
// Run is the common flow/logic for all reporting commands, i.e., 'report', 'telemetry', 'flame', 'lock'
@@ -405,7 +406,7 @@ func (rc *ReportingCommand) createReports(appContext AppContext, orderedTargetSc
405406
})
406407
// create the report(s)
407408
for _, format := range formats {
408-
reportBytes, err := report.Create(format, allTableValues, targetScriptOutputs.TargetName, rc.SummaryTableName)
409+
reportBytes, err := report.Create(format, allTableValues, targetScriptOutputs.TargetName, rc.SystemSummaryTableName)
409410
if err != nil {
410411
err = fmt.Errorf("failed to create report: %w", err)
411412
return nil, err

0 commit comments

Comments
 (0)