From b0214cc9288bdb0ed487420197bd9b5464e00604 Mon Sep 17 00:00:00 2001 From: "Harper, Jason M" Date: Wed, 10 Dec 2025 20:43:08 -0800 Subject: [PATCH 1/2] fix missing xlsx brief sheet Signed-off-by: Harper, Jason M --- cmd/report/report.go | 1 + internal/common/common.go | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/report/report.go b/cmd/report/report.go index 28100255..4e25b581 100644 --- a/cmd/report/report.go +++ b/cmd/report/report.go @@ -359,6 +359,7 @@ func runCmd(cmd *cobra.Command, args []string) error { SummaryTableName: benchmarkSummaryTableName, SummaryBeforeTableName: SpeedBenchmarkTableName, InsightsFunc: insightsFunc, + SystemSummaryTableName: SystemSummaryTableName, } report.RegisterHTMLRenderer(DIMMTableName, dimmTableHTMLRenderer) diff --git a/internal/common/common.go b/internal/common/common.go index 314ab8e5..a611ed50 100644 --- a/internal/common/common.go +++ b/internal/common/common.go @@ -91,10 +91,11 @@ type ReportingCommand struct { Tables []table.TableDefinition ScriptParams map[string]string SummaryFunc SummaryFunc - SummaryTableName string + SummaryTableName string // e.g., the benchmark or telemetry summary table SummaryBeforeTableName string // the name of the table that the summary table should be placed before in the report InsightsFunc InsightsFunc AdhocFunc AdhocFunc + SystemSummaryTableName string // e.g., "System Summary" for xlsx report that becomes the "Brief" sheet } // Run is the common flow/logic for all reporting commands, i.e., 'report', 'telemetry', 'flame', 'lock' @@ -405,7 +406,7 @@ func (rc *ReportingCommand) createReports(appContext AppContext, orderedTargetSc }) // create the report(s) for _, format := range formats { - reportBytes, err := report.Create(format, allTableValues, targetScriptOutputs.TargetName, rc.SummaryTableName) + reportBytes, err := report.Create(format, allTableValues, targetScriptOutputs.TargetName, rc.SystemSummaryTableName) if err != nil { err = fmt.Errorf("failed to create report: %w", err) return nil, err From d9c9743d1daeb8baefeb98f026c52b1e3aade82b Mon Sep 17 00:00:00 2001 From: Jason Harper <78619061+harp-intel@users.noreply.github.com> Date: Wed, 10 Dec 2025 20:52:03 -0800 Subject: [PATCH 2/2] Update internal/common/common.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- internal/common/common.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/common/common.go b/internal/common/common.go index a611ed50..cb478bd7 100644 --- a/internal/common/common.go +++ b/internal/common/common.go @@ -95,7 +95,7 @@ type ReportingCommand struct { SummaryBeforeTableName string // the name of the table that the summary table should be placed before in the report InsightsFunc InsightsFunc AdhocFunc AdhocFunc - SystemSummaryTableName string // e.g., "System Summary" for xlsx report that becomes the "Brief" sheet + SystemSummaryTableName string // Optional: Only affects xlsx format reports. If set, the table with this name will be used as the "Brief" sheet in the xlsx report. If empty or unset, no "Brief" sheet is generated. } // Run is the common flow/logic for all reporting commands, i.e., 'report', 'telemetry', 'flame', 'lock'