From 010c22f106a928c3cb2a3dbefeab0c0c2b833b05 Mon Sep 17 00:00:00 2001 From: "Harper, Jason M" Date: Thu, 11 Dec 2025 06:14:06 -0800 Subject: [PATCH 1/2] clean maxdepth Signed-off-by: Harper, Jason M --- cmd/flame/flame_tables.go | 2 +- cmd/flame/render_html_flamegraph.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/flame/flame_tables.go b/cmd/flame/flame_tables.go index c8dd95cc..6e254b95 100644 --- a/cmd/flame/flame_tables.go +++ b/cmd/flame/flame_tables.go @@ -111,7 +111,7 @@ func maxRenderDepthFromOutput(outputs map[string]script.ScriptOutput) string { } for header, content := range sections { if header == "maximum depth" { - return content + return strings.TrimSpace(content) } } return "" diff --git a/cmd/flame/render_html_flamegraph.go b/cmd/flame/render_html_flamegraph.go index ed8f7eae..190fb8b9 100644 --- a/cmd/flame/render_html_flamegraph.go +++ b/cmd/flame/render_html_flamegraph.go @@ -156,7 +156,7 @@ func renderFlameGraph(header string, tableValues table.TableValues, field string return } maxDepth := tableValues.Fields[maxDepthFieldIndex].Values[0] - maxStackDepth, err := strconv.Atoi(strings.TrimSpace(maxDepth)) + maxStackDepth, err := strconv.Atoi(maxDepth) if err != nil { slog.Error("failed to convert maximum stack depth", slog.String("error", err.Error())) return From 8eea1d1c0ae0d01e4b2eb88179eacc48c661afaf Mon Sep 17 00:00:00 2001 From: "Harper, Jason M" Date: Thu, 11 Dec 2025 06:14:20 -0800 Subject: [PATCH 2/2] clean logs Signed-off-by: Harper, Jason M --- internal/common/common.go | 2 +- internal/common/targets.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/common/common.go b/internal/common/common.go index cb478bd7..35aa7e7a 100644 --- a/internal/common/common.go +++ b/internal/common/common.go @@ -532,7 +532,7 @@ func outputsFromTargets(cmd *cobra.Command, myTargets []target.Target, tables [] targetScriptNames[targetIdx] = util.UniqueAppend(targetScriptNames[targetIdx], scriptName) } } else { - slog.Info("table not supported for target", slog.String("table", tbl.Name), slog.String("target", target.GetName())) + slog.Debug("table not supported for target", slog.String("table", tbl.Name), slog.String("target", target.GetName())) } } } diff --git a/internal/common/targets.go b/internal/common/targets.go index d8dffcc5..1903c6a7 100644 --- a/internal/common/targets.go +++ b/internal/common/targets.go @@ -758,7 +758,7 @@ func ScriptSupportedOnTarget(t target.Target, scriptDef script.ScriptDefinition, return false, err } if !slices.Contains(scriptDef.Architectures, arch) { - slog.Info("script not supported on target architecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("architecture", arch)) + slog.Debug("script not supported on target architecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("architecture", arch)) return false, nil } } @@ -768,7 +768,7 @@ func ScriptSupportedOnTarget(t target.Target, scriptDef script.ScriptDefinition, return false, err } if !slices.Contains(scriptDef.Vendors, vendor) { - slog.Info("script not supported on target CPU vendor", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("vendor", vendor)) + slog.Debug("script not supported on target CPU vendor", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("vendor", vendor)) return false, nil } } @@ -781,7 +781,7 @@ func ScriptSupportedOnTarget(t target.Target, scriptDef script.ScriptDefinition, shortUarch = strings.Split(shortUarch, "-")[0] // handle GNR-D shortUarch = strings.Split(shortUarch, " ")[0] // handle Turin (Zen 5) if !slices.Contains(scriptDef.MicroArchitectures, uarch) && !slices.Contains(scriptDef.MicroArchitectures, shortUarch) { - slog.Info("script not supported on target CPU microarchitecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("microarchitecture", uarch)) + slog.Debug("script not supported on target CPU microarchitecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("microarchitecture", uarch)) return false, nil } }