validate event details before posting

Author: dehora

intercom-java/src/main/java/io/intercom/api/Error.java

@@ -20,6 +20,11 @@ public class Error extends TypedData {
     public Error() {
     }
 
+    public Error(String code, String message) {
+        this.code = code;
+        this.message = message;
+    }
+
     public String getType() {
         return type;
     }

intercom-java/src/main/java/io/intercom/api/Event.java

@@ -3,9 +3,11 @@
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Strings;
+import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 
-import java.util.Date;
 import java.util.Map;
 
 @SuppressWarnings("UnusedDeclaration")
@@ -14,12 +16,35 @@
 public class Event extends TypedData {
 
     public static void create(Event event) throws InvalidException, AuthorizationException {
+
+        validateCreateEvent(event);
+
         if (event.getCreatedAt() == 0L) {
             event.setCreatedAt(System.currentTimeMillis() / 1000);
         }
         DataResource.create(event, "events", Void.class);
     }
 
+    private static final ErrorCollection INVALID_NAME = new ErrorCollection(
+        Lists.newArrayList(
+            new Error("invalid", "an event must supply an event name")));
+
+    private static final ErrorCollection INVALID_USER = new ErrorCollection(
+        Lists.newArrayList(
+            new Error("invalid", "an event must supply either an email or a user id")));
+
+    @VisibleForTesting
+    static void validateCreateEvent(Event event) {
+        if(Strings.isNullOrEmpty(event.getEventName())) {
+            throw new InvalidException(INVALID_NAME);
+        }
+
+        if(Strings.isNullOrEmpty(event.getUserID())
+            && Strings.isNullOrEmpty(event.getEmail())) {
+            throw new InvalidException(INVALID_USER);
+        }
+    }
+
     @SuppressWarnings("FieldCanBeLocal")
     @JsonProperty("type")
     private final String type = "event";

intercom-java/src/test/java/io/intercom/api/EventTest.java

@@ -0,0 +1,96 @@
+package io.intercom.api;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+public class EventTest {
+
+    @Test
+    public void testMissingUser() {
+        final Event event1 = new Event().setEventName("bought-hat");
+        try {
+            Event.create(event1);
+            fail("an event with no user id or email should be invalid");
+        } catch (InvalidException e) {
+            assertTrue(e.getFirstError() != null);
+        }
+
+        final Event event2 = new Event()
+            .setEventName("bought-hat")
+            .setUserID("")
+            .putMetadata("invitee_email", "jayne@serenity.io");
+        try {
+            Event.create(event2);
+            fail("an event with a blank  user id should be invalid");
+        } catch (InvalidException e) {
+            assertTrue(e.getFirstError() != null);
+        }
+
+        final Event event3 = new Event().setEmail("");
+        try {
+            Event.create(event3);
+            fail("an event with a blank  email should be invalid");
+        } catch (InvalidException e) {
+            assertTrue(e.getFirstError() != null);
+        }
+
+    }
+
+    @Test
+    public void testMissingEventName() {
+        Event event1 = new Event()
+            .setEmail("jayne@serenity.io");
+        try {
+            Event.create(event1);
+            fail("an event with a blank  name should be invalid");
+        } catch (InvalidException e) {
+            assertTrue(e.getFirstError() != null);
+
+        }
+
+        Event event2 = new Event()
+            .setEmail("jayne@serenity.io")
+            .setEventName("");
+        try {
+            Event.create(event2);
+            fail("an event with a blank  name should be invalid");
+        } catch (InvalidException e) {
+            assertTrue(e.getFirstError() != null);
+        }
+    }
+
+    @Test
+    public void testValid() {
+        Event event1 = new Event()
+            .setEmail("jayne@serenity.io")
+            .setEventName("bought-hat");
+        try {
+            Event.validateCreateEvent(event1);
+        } catch (InvalidException e) {
+            fail("an event with an email and a name should be valid");
+        }
+
+        Event event2 = new Event()
+            .setUserID("1")
+            .setEventName("bought-hat");
+        try {
+            Event.validateCreateEvent(event2);
+        } catch (InvalidException e) {
+            fail("an event with a user id and a name should be valid");
+        }
+
+        Event event3 = new Event()
+            .setUserID("1")
+            .setEmail("jayne@serenity.io")
+            .setEventName("bought-hat");
+        try {
+            Event.validateCreateEvent(event3);
+        } catch (InvalidException e) {
+            fail("an event with a user id, email and a name should be valid");
+        }
+    }
+
+
+}