From 59f09d12fead2eb605746950eb9c349930194b4a Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Thu, 22 Jan 2026 08:49:13 -0700 Subject: [PATCH 1/4] fix(ci): fix failing angular tests in stencil-nightly --- .github/workflows/actions/test-angular-e2e/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/actions/test-angular-e2e/action.yml b/.github/workflows/actions/test-angular-e2e/action.yml index 1e5b49b3150..c6225382658 100644 --- a/.github/workflows/actions/test-angular-e2e/action.yml +++ b/.github/workflows/actions/test-angular-e2e/action.yml @@ -17,7 +17,7 @@ runs: - uses: ./.github/workflows/actions/download-archive with: name: ionic-angular - path: ./angular + path: ./packages/angular filename: AngularBuild.zip - uses: ./.github/workflows/actions/download-archive with: From 1bd4ca25b66e0b7fcd985757d560ba2fb4cd37bf Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Thu, 22 Jan 2026 12:40:05 -0700 Subject: [PATCH 2/4] fix(ci): include package.json in core archive upload --- .../workflows/actions/build-core-stencil-prerelease/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/actions/build-core-stencil-prerelease/action.yml b/.github/workflows/actions/build-core-stencil-prerelease/action.yml index d58299125e3..bd7bd96c7c9 100644 --- a/.github/workflows/actions/build-core-stencil-prerelease/action.yml +++ b/.github/workflows/actions/build-core-stencil-prerelease/action.yml @@ -29,4 +29,4 @@ runs: with: name: ionic-core output: core/CoreBuild.zip - paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts + paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts core/package.json From e3b3bb33e64afd41b37b7dc77fed6c83e92be399 Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Thu, 22 Jan 2026 14:46:48 -0700 Subject: [PATCH 3/4] chore(ci): checkout core/package.json before testing git diff --- .github/workflows/actions/build-angular/action.yml | 6 +++++- .github/workflows/actions/build-react/action.yml | 6 +++++- .github/workflows/actions/build-vue/action.yml | 6 +++++- .github/workflows/actions/test-core-clean-build/action.yml | 4 ++++ .github/workflows/actions/test-core-lint/action.yml | 4 ++++ .github/workflows/actions/test-core-screenshot/action.yml | 4 ++++ .../actions/update-reference-screenshots/action.yml | 4 ++++ 7 files changed, 31 insertions(+), 3 deletions(-) diff --git a/.github/workflows/actions/build-angular/action.yml b/.github/workflows/actions/build-angular/action.yml index fc7496de421..9f3fadd6ec6 100644 --- a/.github/workflows/actions/build-angular/action.yml +++ b/.github/workflows/actions/build-angular/action.yml @@ -27,8 +27,12 @@ runs: run: npm run build shell: bash working-directory: ./packages/angular + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: 🔍 Check Diff - run: git diff --exit-code + run: git diff --exit-code . shell: bash working-directory: ./packages/angular - uses: ./.github/workflows/actions/upload-archive diff --git a/.github/workflows/actions/build-react/action.yml b/.github/workflows/actions/build-react/action.yml index 04e3f2c8b3a..1cdc5f4ccd4 100644 --- a/.github/workflows/actions/build-react/action.yml +++ b/.github/workflows/actions/build-react/action.yml @@ -31,8 +31,12 @@ runs: run: npm run test.spec shell: bash working-directory: ./packages/react + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: 🔍 Check Diff - run: git diff --exit-code + run: git diff --exit-code . shell: bash working-directory: ./packages/react - uses: ./.github/workflows/actions/upload-archive diff --git a/.github/workflows/actions/build-vue/action.yml b/.github/workflows/actions/build-vue/action.yml index ddd96b7a690..c14255339fc 100644 --- a/.github/workflows/actions/build-vue/action.yml +++ b/.github/workflows/actions/build-vue/action.yml @@ -27,8 +27,12 @@ runs: run: npm run build shell: bash working-directory: ./packages/vue + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: 🔍 Check Diff - run: git diff --exit-code + run: git diff --exit-code . shell: bash working-directory: ./packages/vue - uses: ./.github/workflows/actions/upload-archive diff --git a/.github/workflows/actions/test-core-clean-build/action.yml b/.github/workflows/actions/test-core-clean-build/action.yml index ac5c345a235..7e5942a036e 100644 --- a/.github/workflows/actions/test-core-clean-build/action.yml +++ b/.github/workflows/actions/test-core-clean-build/action.yml @@ -12,6 +12,10 @@ runs: name: ionic-core path: ./core filename: CoreBuild.zip + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: 🔍 Check Diff run: | git diff --exit-code || { diff --git a/.github/workflows/actions/test-core-lint/action.yml b/.github/workflows/actions/test-core-lint/action.yml index a32355d33fa..ef9d37d0c7d 100644 --- a/.github/workflows/actions/test-core-lint/action.yml +++ b/.github/workflows/actions/test-core-lint/action.yml @@ -10,6 +10,10 @@ runs: run: npm ci working-directory: ./core shell: bash + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: 🖌️ Lint run: npm run lint shell: bash diff --git a/.github/workflows/actions/test-core-screenshot/action.yml b/.github/workflows/actions/test-core-screenshot/action.yml index 1ae7ac361e0..629c68d79f2 100644 --- a/.github/workflows/actions/test-core-screenshot/action.yml +++ b/.github/workflows/actions/test-core-screenshot/action.yml @@ -30,6 +30,10 @@ runs: run: npm run test.e2e.docker.ci ${{ inputs.component }} -- --shard=${{ inputs.shard }}/${{ inputs.totalShards }} shell: bash working-directory: ./core + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: Test and Update id: test-and-update if: inputs.update == 'true' diff --git a/.github/workflows/actions/update-reference-screenshots/action.yml b/.github/workflows/actions/update-reference-screenshots/action.yml index f104d227095..9c082f1a17d 100644 --- a/.github/workflows/actions/update-reference-screenshots/action.yml +++ b/.github/workflows/actions/update-reference-screenshots/action.yml @@ -21,6 +21,10 @@ runs: find . -type f -name 'UpdatedScreenshots-*.zip' -exec unzip -q -o -d ../ {} \; shell: bash working-directory: ./artifacts + - name: Clean core package.json + run: git checkout ./package.json + shell: bash + working-directory: ./core - name: 📸 Push Screenshots # Configure user as Ionitron # and push only the changed .png snapshots From 89f4fd68508b44df842d6677c9e2b5c3a4823456 Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Fri, 23 Jan 2026 09:14:00 -0700 Subject: [PATCH 4/4] chore(ci): remove . from git diff commands --- .github/workflows/actions/build-angular/action.yml | 2 +- .github/workflows/actions/build-react/action.yml | 2 +- .github/workflows/actions/build-vue/action.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/actions/build-angular/action.yml b/.github/workflows/actions/build-angular/action.yml index 9f3fadd6ec6..5224f9741e0 100644 --- a/.github/workflows/actions/build-angular/action.yml +++ b/.github/workflows/actions/build-angular/action.yml @@ -32,7 +32,7 @@ runs: shell: bash working-directory: ./core - name: 🔍 Check Diff - run: git diff --exit-code . + run: git diff --exit-code shell: bash working-directory: ./packages/angular - uses: ./.github/workflows/actions/upload-archive diff --git a/.github/workflows/actions/build-react/action.yml b/.github/workflows/actions/build-react/action.yml index 1cdc5f4ccd4..f2adcb0788f 100644 --- a/.github/workflows/actions/build-react/action.yml +++ b/.github/workflows/actions/build-react/action.yml @@ -36,7 +36,7 @@ runs: shell: bash working-directory: ./core - name: 🔍 Check Diff - run: git diff --exit-code . + run: git diff --exit-code shell: bash working-directory: ./packages/react - uses: ./.github/workflows/actions/upload-archive diff --git a/.github/workflows/actions/build-vue/action.yml b/.github/workflows/actions/build-vue/action.yml index c14255339fc..72a49093fca 100644 --- a/.github/workflows/actions/build-vue/action.yml +++ b/.github/workflows/actions/build-vue/action.yml @@ -32,7 +32,7 @@ runs: shell: bash working-directory: ./core - name: 🔍 Check Diff - run: git diff --exit-code . + run: git diff --exit-code shell: bash working-directory: ./packages/vue - uses: ./.github/workflows/actions/upload-archive