fix(30003): formatter deletes comments after trailing comma (microsoft#36674)

Author: a-tarasyuk

src/services/formatting/formatting.ts

@@ -824,8 +824,11 @@ namespace ts.formatting {
                 if (listEndToken !== SyntaxKind.Unknown && formattingScanner.isOnToken()) {
                     let tokenInfo: TokenInfo | undefined = formattingScanner.readTokenInfo(parent);
                     if (tokenInfo.token.kind === SyntaxKind.CommaToken && isCallLikeExpression(parent)) {
-                        formattingScanner.advance();
-                        tokenInfo = formattingScanner.isOnToken() ? formattingScanner.readTokenInfo(parent) : undefined;
+                        const commaTokenLine = sourceFile.getLineAndCharacterOfPosition(tokenInfo.token.pos).line;
+                        if (startLine !== commaTokenLine) {
+                            formattingScanner.advance();
+                            tokenInfo = formattingScanner.isOnToken() ? formattingScanner.readTokenInfo(parent) : undefined;
+                        }
                     }
 
                     // consume the list end token only if it is still belong to the parent

src/services/formatting/rules.ts

@@ -241,7 +241,7 @@ namespace ts.formatting {
             rule("SpaceAfterConstructor", SyntaxKind.ConstructorKeyword, SyntaxKind.OpenParenToken, [isOptionEnabled("insertSpaceAfterConstructor"), isNonJsxSameLineTokenContext], RuleAction.InsertSpace),
             rule("NoSpaceAfterConstructor", SyntaxKind.ConstructorKeyword, SyntaxKind.OpenParenToken, [isOptionDisabledOrUndefined("insertSpaceAfterConstructor"), isNonJsxSameLineTokenContext], RuleAction.DeleteSpace),
 
-            rule("SpaceAfterComma", SyntaxKind.CommaToken, anyToken, [isOptionEnabled("insertSpaceAfterCommaDelimiter"), isNonJsxSameLineTokenContext, isNonJsxElementOrFragmentContext, isNextTokenNotCloseBracket], RuleAction.InsertSpace),
+            rule("SpaceAfterComma", SyntaxKind.CommaToken, anyToken, [isOptionEnabled("insertSpaceAfterCommaDelimiter"), isNonJsxSameLineTokenContext, isNonJsxElementOrFragmentContext, isNextTokenNotCloseBracket, isNextTokenNotCloseParen], RuleAction.InsertSpace),
             rule("NoSpaceAfterComma", SyntaxKind.CommaToken, anyToken, [isOptionDisabledOrUndefined("insertSpaceAfterCommaDelimiter"), isNonJsxSameLineTokenContext, isNonJsxElementOrFragmentContext], RuleAction.DeleteSpace),
 
             // Insert space after function keyword for anonymous functions
@@ -670,6 +670,10 @@ namespace ts.formatting {
         return context.nextTokenSpan.kind !== SyntaxKind.CloseBracketToken;
     }
 
+    function isNextTokenNotCloseParen(context: FormattingContext): boolean {
+        return context.nextTokenSpan.kind !== SyntaxKind.CloseParenToken;
+    }
+
     function isArrowFunctionContext(context: FormattingContext): boolean {
         return context.contextNode.kind === SyntaxKind.ArrowFunction;
     }

tests/cases/fourslash/formatNoSpaceBeforeCloseBrace.ts

@@ -0,0 +1,6 @@
+/// <reference path="fourslash.ts"/>
+
+////foo(1, /* comment */    );
+
+format.document();
+verify.currentFileContentIs(`foo(1, /* comment */);`);

tests/cases/fourslash/formatNoSpaceBeforeCloseBrace1.ts

@@ -0,0 +1,6 @@
+/// <reference path="fourslash.ts"/>
+
+////new Foo(1, /* comment */    );
+
+format.document();
+verify.currentFileContentIs(`new Foo(1, /* comment */);`);

tests/cases/fourslash/formatNoSpaceBeforeCloseBrace2.ts

@@ -0,0 +1,6 @@
+/// <reference path="fourslash.ts"/>
+
+////new Foo(1,     );
+
+format.document();
+verify.currentFileContentIs(`new Foo(1,);`);