Add MSVC Support

- Removes variable length arrays
- Adds static linking, disable optimization
- Ensure Java is found by cmake

Closes #2

Author: Woodrow Barlow

CMakeLists.txt

@@ -1,6 +1,7 @@
 cmake_minimum_required(VERSION 3.9)
 project(jssc VERSION 2.8.0 DESCRIPTION "Java Simple Serial Connector")
 
+find_package(Java)
 find_package(JNI)
 
 # Kitware-recommended technique for defaulting to 'Release' mode
@@ -37,12 +38,18 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
 			find_package(JNI)
 		endif()
 	endif()
+elseif(MSVC)
+	set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT")
 endif()
 
 if(WIN32)
 	set(JSSC_PLATFORM "windows")
 	# Disable optimization for Release builds (XP/Server 2003)
-	set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -O0")
+	if(NOT MSVC)
+		set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -O0")
+	else()
+		set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /Od")
+	endif()
 else()
 	set(JSSC_PLATFORM "_nix_based")
 	# Sane level of optimization for Release builds

src/cpp/windows/jssc.cpp

@@ -29,6 +29,8 @@
 
 //#include <iostream>
 
+#define MAX_PORT_NAME_STR_LEN 32
+
 /*
  * Get native library version
  */
@@ -46,7 +48,12 @@ JNIEXPORT jlong JNICALL Java_jssc_SerialNativeInterface_openPort(JNIEnv *env, jo
     const char* port = env->GetStringUTFChars(portName, JNI_FALSE);
 
     //since 2.1.0 -> string concat fix
-    char portFullName[strlen(prefix) + strlen(port) + 1];
+    char portFullName[MAX_PORT_NAME_STR_LEN];
+
+    if(strlen(prefix) + strlen(port) + 1 > sizeof(portFullName)){
+        return (jlong)((HANDLE)jssc_SerialNativeInterface_ERR_PORT_NOT_FOUND);
+    }
+
     strcpy(portFullName, prefix);
     strcat(portFullName, port);
     //<- since 2.1.0
@@ -259,8 +266,15 @@ JNIEXPORT jbyteArray JNICALL Java_jssc_SerialNativeInterface_readBytes
     DWORD lpNumberOfBytesTransferred;
     DWORD lpNumberOfBytesRead;
     OVERLAPPED *overlapped = new OVERLAPPED();
-    jbyte lpBuffer[byteCount];
+    jbyte *lpBuffer = NULL;
     jbyteArray returnArray = env->NewByteArray(byteCount);
+
+    lpBuffer = (jbyte *)malloc(byteCount * sizeof(jbyte));
+    if(lpBuffer == NULL){
+        // return an empty array
+        return returnArray;
+    }
+
     overlapped->hEvent = CreateEventA(NULL, true, false, NULL);
     if(ReadFile(hComm, lpBuffer, (DWORD)byteCount, &lpNumberOfBytesRead, overlapped)){
         env->SetByteArrayRegion(returnArray, 0, byteCount, lpBuffer);
@@ -274,6 +288,7 @@ JNIEXPORT jbyteArray JNICALL Java_jssc_SerialNativeInterface_readBytes
     }
     CloseHandle(overlapped->hEvent);
     delete overlapped;
+    free(lpBuffer);
     return returnArray;
 }