Improved attribute parser to handle values with equal signs

Author: javadev

src/main/java/com/github/underscore/Xml.java

@@ -1527,7 +1527,7 @@ static Map<String, String> parseAttributes(final String source) {
         boolean quoteFound = false;
         boolean equalFound = false;
         for (int index = 0; index < source.length(); index += 1) {
-            if (source.charAt(index) == '=') {
+            if (source.charAt(index) == '=' && !quoteFound) {
                 equalFound = !equalFound;
                 continue;
             }

src/test/java/com/github/underscore/LodashTest.java

@@ -1028,6 +1028,19 @@ void xmpToJson4() {
                                 + "</z:catalog>"));
     }
 
+    @Test
+    void xmpToJson5() {
+        assertEquals("{\n" +
+                        "  \"Comment\": {\n" +
+                        "    \"-stringValue\": \"============================\",\n" +
+                        "    \"-self-closing\": \"true\"\n" +
+                        "  },\n" +
+                        "  \"#omit-xml-declaration\": \"yes\"\n" +
+                        "}",
+                U.xmlToJson(
+                        "<Comment stringValue=\"============================\"/>"));
+    }
+
     @Test
     void xmlToJsonMinimum() {
         assertEquals(

src/test/java/com/github/underscore/StringTest.java

@@ -2358,9 +2358,11 @@ void parseAttributes() {
                 "{version=1.0}",
                 Xml.parseAttributes(" version = \"1.0\"  encoding= \"UTF-8 ").toString());
         assertEquals(
-                "{}", Xml.parseAttributes(" version = \"1.0  encoding= \"UTF-8\" ").toString());
+                "{version=1.0  encoding= }",
+                Xml.parseAttributes(" version = \"1.0  encoding= \"UTF-8\" ").toString());
         assertEquals(
-                "{}", Xml.parseAttributes(" version = 1.0\"  encoding= \"UTF-8\" ").toString());
+                "{version1.0=  encoding= }",
+                Xml.parseAttributes(" version = 1.0\"  encoding= \"UTF-8\" ").toString());
     }
 
     @SuppressWarnings("unchecked")