Skip to content

Commit d5a99dd

Browse files
authored
Remove unnecessary 'return'
Better to remove 'return' before 'reject' in two example code pieces. This 'return' doesn't make sense. Also, there is no such 'return' keyword in English version of this article. This mistake in example code makes difficult to beginners to understand the code, distracts attention, creates questions in comments.
1 parent 098c554 commit d5a99dd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

1-js/11-async/06-promisify/article.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function promisify(f) {
5353
return new Promise((resolve, reject) => {
5454
function callback(err, result) { // наш специальный колбэк для f
5555
if (err) {
56-
return reject(err);
56+
reject(err);
5757
} else {
5858
resolve(result);
5959
}
@@ -84,7 +84,7 @@ function promisify(f, manyArgs = false) {
8484
return new Promise((resolve, reject) => {
8585
function *!*callback(err, ...results*/!*) { // наш специальный колбэк для f
8686
if (err) {
87-
return reject(err);
87+
reject(err);
8888
} else {
8989
// делаем resolve для всех results колбэка, если задано manyArgs
9090
*!*resolve(manyArgs ? results : results[0]);*/!*

0 commit comments

Comments
 (0)