From 3d7a8b572a2c084c8c0e70e2373564d24b0722c4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Oct 2025 13:49:23 +0000 Subject: [PATCH 1/7] Initial plan From 2c5ad3c79cdb7f707efe71eea919c46d033acea0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Oct 2025 14:03:18 +0000 Subject: [PATCH 2/7] Migrate from Shouldly to AwesomeAssertions v9.2.1 Co-authored-by: JohnCampionJr <1094820+JohnCampionJr@users.noreply.github.com> --- ...Framework.AspNetCore.Identity.Tests.csproj | 2 +- ...ameworkServiceCollectionExtensionsTests.cs | 18 ++++---- .../MongoIdentityBuilderExtensionsTests.cs | 30 +++++++------- .../MongoIdentityContextsTests.cs | 12 +++--- .../MongoIdentityRoleTests.cs | 23 ++++++----- .../MongoIdentityUserTests.cs | 41 ++++++++++--------- .../MongoRoleStoreTests.cs | 16 ++++---- .../MongoUserOnlyStoreTests/AddClaims.cs | 20 ++++----- .../MongoUserOnlyStoreTests/AddLogin.cs | 20 ++++----- .../MongoUserOnlyStoreTests/CreateUser.cs | 28 ++++++------- .../MongoUserOnlyStoreTests/DeleteUser.cs | 16 ++++---- .../MongoUserOnlyStoreTests/FindByEmail.cs | 14 +++---- .../MongoUserOnlyStoreTests/FindById.cs | 20 ++++----- .../MongoUserOnlyStoreTests/FindByLogin.cs | 18 ++++---- .../MongoUserOnlyStoreTests/FindByName.cs | 18 ++++---- .../MongoUserOnlyStoreTests/GetClaims.cs | 12 +++--- .../MongoUserOnlyStoreTests/GetLogins.cs | 12 +++--- .../MongoUserOnlyStoreTests/GetToken.cs | 12 +++--- .../GetUsersForClaim.cs | 12 +++--- .../MongoUserOnlyStoreTests/RemoveClaim.cs | 18 ++++---- .../MongoUserOnlyStoreTests/RemoveLogin.cs | 12 +++--- .../MongoUserOnlyStoreTests/RemoveToken.cs | 12 +++--- .../MongoUserOnlyStoreTests/ReplaceClaim.cs | 24 +++++------ .../MongoUserOnlyStoreTests/SetToken.cs | 16 ++++---- .../MongoUserOnlyStoreTests/UpdateUser.cs | 12 +++--- .../MongoUserStoreTests/FindByEmail.cs | 18 ++++---- .../MongoUserStoreTests/FindByLogin.cs | 18 ++++---- .../MongoUserStoreTests/FindByName.cs | 14 +++---- .../MongoUserStoreTests/FindUserRole.cs | 22 +++++----- .../MongoUserStoreTests/GetRoles.cs | 12 +++--- 30 files changed, 263 insertions(+), 259 deletions(-) diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoEntityFramework.AspNetCore.Identity.Tests.csproj b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoEntityFramework.AspNetCore.Identity.Tests.csproj index f2f705c..eb18771 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoEntityFramework.AspNetCore.Identity.Tests.csproj +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoEntityFramework.AspNetCore.Identity.Tests.csproj @@ -16,7 +16,7 @@ - + all diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoFrameworkServiceCollectionExtensionsTests.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoFrameworkServiceCollectionExtensionsTests.cs index c5f5cf4..49018e2 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoFrameworkServiceCollectionExtensionsTests.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoFrameworkServiceCollectionExtensionsTests.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Collections.Generic; using System.Linq; using Microsoft.AspNetCore.Identity; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoFramework.AspNetCore.Identity.Tests @@ -32,9 +32,9 @@ public void RegistersContextWithNoParameters() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService()) { - db.ShouldBeOfType(); - db.Connection.ShouldNotBeNull(); - db.Connection.GetDatabase().DatabaseNamespace.DatabaseName.ShouldBe("identity-test"); + db.Should().BeOfType(); + db.Connection.Should().NotBeNull(); + db.Connection.GetDatabase().DatabaseNamespace.DatabaseName.Should().Be("identity-test"); } } @@ -54,9 +54,9 @@ public void RegistersConnectionWithValidConnectionString() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService()) { - db.ShouldBeOfType(); - db.Connection.ShouldNotBeNull(); - db.Connection.GetDatabase().DatabaseNamespace.DatabaseName.ShouldBe("identity-test"); + db.Should().BeOfType(); + db.Connection.Should().NotBeNull(); + db.Connection.GetDatabase().DatabaseNamespace.DatabaseName.Should().Be("identity-test"); } } @@ -76,7 +76,7 @@ public void RegistersConnectionWithListener() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService()) { - db.Connection.DiagnosticListener.ShouldBeOfType(); + db.Connection.DiagnosticListener.Should().BeOfType(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityBuilderExtensionsTests.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityBuilderExtensionsTests.cs index d50c2ed..0c39454 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityBuilderExtensionsTests.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityBuilderExtensionsTests.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Collections.Generic; using System.Linq; using Microsoft.AspNetCore.Identity; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoFramework.AspNetCore.Identity.Tests @@ -36,8 +36,8 @@ public void RegistersFullyTypedUserStoreWithMongoIdentityContext() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService>()) { - db.GetType().GenericTypeArguments.Length.ShouldBe(9); - db.ShouldBeOfType, IdentityUserRole, IdentityUserLogin, IdentityUserToken, IdentityRoleClaim>>(); + db.GetType().GenericTypeArguments.Length.Should().Be(9); + db.Should().BeOfType, IdentityUserRole, IdentityUserLogin, IdentityUserToken, IdentityRoleClaim>>(); } } @@ -64,8 +64,8 @@ public void RegistersFullyTypedUserOnlyStoreWithMongoIdentityContext() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService>()) { - db.GetType().GenericTypeArguments.Length.ShouldBe(6); - db.ShouldBeOfType, IdentityUserLogin, IdentityUserToken>>(); + db.GetType().GenericTypeArguments.Length.Should().Be(6); + db.Should().BeOfType, IdentityUserLogin, IdentityUserToken>>(); } } @@ -94,8 +94,8 @@ public void RegistersLimitedTypedUserStoreWithMongoContext() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService>()) { - db.GetType().GenericTypeArguments.Length.ShouldBe(4); - db.ShouldBeOfType>(); + db.GetType().GenericTypeArguments.Length.Should().Be(4); + db.Should().BeOfType>(); } } @@ -122,8 +122,8 @@ public void RegistersLimitedTypedUserOnlyStoreWithMongoContext() using (var scoped = provider.GetRequiredService().CreateScope()) using (var db = scoped.ServiceProvider.GetRequiredService>()) { - db.GetType().GenericTypeArguments.Length.ShouldBe(3); - db.ShouldBeOfType>(); + db.GetType().GenericTypeArguments.Length.Should().Be(3); + db.Should().BeOfType>(); } } @@ -141,12 +141,13 @@ public void ExtensionThrowsExceptionWithoutMongoIdentityRole() services.AddTransient(); - Should.Throw(() => + Action action = () => { services .AddIdentity() .AddMongoFrameworkStores(); - }); + }; + action.Should().Throw(); } [Fact] @@ -162,12 +163,13 @@ public void ExtensionThrowsExceptionWithoutMongoIdentityUser() services.AddTransient(); - Should.Throw(() => + Action action = () => { services .AddIdentity() .AddMongoFrameworkStores(); - }); + }; + action.Should().Throw(); } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityContextsTests.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityContextsTests.cs index 62bcec8..c13be97 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityContextsTests.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityContextsTests.cs @@ -1,9 +1,9 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using MongoDB.Bson; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests @@ -49,8 +49,8 @@ public void ContextWithRolesLoadsRoles() var store = new MongoRoleStore(context); - store.Context.ShouldBeOfType(); - store.Roles.Count().ShouldBe(3); + store.Context.Should().BeOfType(); + store.Roles.Count().Should().Be(3); } [Fact] @@ -60,8 +60,8 @@ public void ContextWithUsersLoadsUsers() var store = new MongoUserOnlyStore(context); - store.Context.ShouldBeOfType(); - store.Users.Count().ShouldBe(1); + store.Context.Should().BeOfType(); + store.Users.Count().Should().Be(1); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityRoleTests.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityRoleTests.cs index 29cb387..5dee2a8 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityRoleTests.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityRoleTests.cs @@ -1,7 +1,7 @@ -using System; +using System; using System.Collections.Generic; using Microsoft.AspNetCore.Identity; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests @@ -13,8 +13,8 @@ public void ConstructorCreatesEmptyLists() { var role = new MongoIdentityRole(); - role.Claims.ShouldNotBeNull(); - role.Claims.Count.ShouldBe(0); + role.Claims.Should().NotBeNull(); + role.Claims.Count.Should().Be(0); } [Fact] @@ -22,18 +22,19 @@ public void ConstructorSucceedsWithValidUserName() { var role = new MongoIdentityRole("role-name"); - role.Name.ShouldBe("role-name"); - role.NormalizedName.ShouldBe("ROLE-NAME"); - role.ToString().ShouldBe("role-name"); + role.Name.Should().Be("role-name"); + role.NormalizedName.Should().Be("ROLE-NAME"); + role.ToString().Should().Be("role-name"); } [Fact] public void ConstructorThrowsExceptionWithNullUserName() { - Should.Throw(() => + Action action = () => { _ = new MongoIdentityRole(null); - }); + }; + action.Should().Throw(); } [Fact] @@ -41,7 +42,7 @@ public void KeyTypeIsUsedInCollectionsWithInteger() { var role = new MongoIdentityRole(); - role.Claims.ShouldBeOfType>>(); + role.Claims.Should().BeOfType>>(); } [Fact] @@ -49,7 +50,7 @@ public void KeyTypeIsUsedInCollectionsWithGuid() { var role = new MongoIdentityRole(); - role.Claims.ShouldBeOfType>>(); + role.Claims.Should().BeOfType>>(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityUserTests.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityUserTests.cs index a0050ee..c5b73b5 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityUserTests.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoIdentityUserTests.cs @@ -1,7 +1,7 @@ -using System; +using System; using System.Collections.Generic; using Microsoft.AspNetCore.Identity; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests @@ -13,15 +13,15 @@ public void ConstructorCreatesEmptyLists() { var user = new MongoIdentityUser(); - user.Claims.ShouldNotBeNull(); - user.Roles.ShouldNotBeNull(); - user.Tokens.ShouldNotBeNull(); - user.Logins.ShouldNotBeNull(); + user.Claims.Should().NotBeNull(); + user.Roles.Should().NotBeNull(); + user.Tokens.Should().NotBeNull(); + user.Logins.Should().NotBeNull(); - user.Claims.Count.ShouldBe(0); - user.Roles.Count.ShouldBe(0); - user.Tokens.Count.ShouldBe(0); - user.Logins.Count.ShouldBe(0); + user.Claims.Count.Should().Be(0); + user.Roles.Count.Should().Be(0); + user.Tokens.Count.Should().Be(0); + user.Logins.Count.Should().Be(0); } [Fact] @@ -29,17 +29,18 @@ public void ConstructorSucceedsWithValidUserName() { var user = new MongoIdentityUser("username"); - user.UserName.ShouldBe("username"); - user.NormalizedUserName.ShouldBe("USERNAME"); + user.UserName.Should().Be("username"); + user.NormalizedUserName.Should().Be("USERNAME"); } [Fact] public void ConstructorThrowsExceptionWithNullUserName() { - Should.Throw(() => + Action action = () => { _ = new MongoIdentityUser(null); - }); + }; + action.Should().Throw(); } [Fact] @@ -47,9 +48,9 @@ public void KeyTypeIsUsedInCollectionsWithInteger() { var user = new MongoIdentityUser(); - user.Claims.ShouldBeOfType>>(); - user.Tokens.ShouldBeOfType>>(); - user.Logins.ShouldBeOfType>>(); + user.Claims.Should().BeOfType>>(); + user.Tokens.Should().BeOfType>>(); + user.Logins.Should().BeOfType>>(); } [Fact] @@ -57,9 +58,9 @@ public void KeyTypeIsUsedInCollectionsWithGuid() { var user = new MongoIdentityUser(); - user.Claims.ShouldBeOfType>>(); - user.Tokens.ShouldBeOfType>>(); - user.Logins.ShouldBeOfType>>(); + user.Claims.Should().BeOfType>>(); + user.Tokens.Should().BeOfType>>(); + user.Logins.Should().BeOfType>>(); } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoRoleStoreTests.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoRoleStoreTests.cs index 728dcc0..e447d5c 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoRoleStoreTests.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoRoleStoreTests.cs @@ -1,8 +1,8 @@ -using System; +using System; using System.Threading.Tasks; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests @@ -39,7 +39,7 @@ public void ConstructorUsesMongo() var store = new MongoRoleStore(context); - store.Context.ShouldBeOfType(); + store.Context.Should().BeOfType(); } [Fact] @@ -49,8 +49,8 @@ public void ConvertIdFromStringWithIntReturnsZero() var store = new MongoRoleStore, DbContext, int>(context); - store.ConvertIdFromString(null).ShouldBe(0); - store.ConvertIdFromString("12345").ShouldBe(12345); + store.ConvertIdFromString(null).Should().Be(0); + store.ConvertIdFromString("12345").Should().Be(12345); } [Fact] @@ -60,8 +60,8 @@ public void ConvertIdToStringWithIntReturnsNull() var store = new MongoRoleStore, DbContext, int>(context); - store.ConvertIdToString(0).ShouldBeNull(); - store.ConvertIdToString(12345).ShouldBe("12345"); + store.ConvertIdToString(0).Should().BeNull(); + store.ConvertIdToString(12345).Should().Be("12345"); } [Fact] @@ -73,7 +73,7 @@ public async Task GetNormalizedRoleReturnsCorrect() var role = new MongoIdentityRole { Name = "testrole", NormalizedName = "TESTROLE" }; var name = await store.GetNormalizedRoleNameAsync(role); - name.ShouldBe("TESTROLE"); + name.Should().Be("TESTROLE"); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs index 685704a..6f92730 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -38,8 +38,8 @@ await store.AddClaimsAsync(user, new Claim("type2", "value2") }); - user.Claims.Count.ShouldBe(2); - user.Claims[0].ClaimType.ShouldBe("type"); + user.Claims.Count.Should().Be(2); + user.Claims[0].ClaimType.Should().Be("type"); } [Fact] @@ -62,8 +62,8 @@ await store.AddClaimsAsync(user, store = new MongoUserOnlyStore(context); user = await store.FindByIdAsync(TestIds.UserId1); - user.Claims.Count.ShouldBe(2); - user.Claims[0].ClaimType.ShouldBe("type"); + user.Claims.Count.Should().Be(2); + user.Claims[0].ClaimType.Should().Be("type"); } [Fact] @@ -73,14 +73,14 @@ public async Task ThrowsExceptionWithNullArguments() var store = new MongoUserOnlyStore(context); var user = await store.FindByIdAsync("1000"); - await Should.ThrowAsync(async () => + await (async () => { await store.AddClaimsAsync(null, new[] { new Claim("type", "value") }); - }); - await Should.ThrowAsync(async () => + }).Should().ThrowAsync(); + await (async () => { await store.AddClaimsAsync(user, null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs index 3fa149e..0eb4355 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -35,8 +35,8 @@ public async Task UpdatesUser() await store.AddLoginAsync(user, new UserLoginInfo("provider1", "provider-key", "Login Provider")); - user.Logins.Count.ShouldBe(1); - user.Logins[0].LoginProvider.ShouldBe("provider1"); + user.Logins.Count.Should().Be(1); + user.Logins[0].LoginProvider.Should().Be("provider1"); } [Fact] @@ -53,8 +53,8 @@ public async Task SavesData() store = new MongoUserOnlyStore(context); user = await store.FindByIdAsync(TestIds.UserId1); - user.Logins.Count.ShouldBe(1); - user.Logins[0].LoginProvider.ShouldBe("provider1"); + user.Logins.Count.Should().Be(1); + user.Logins[0].LoginProvider.Should().Be("provider1"); } [Fact] @@ -64,14 +64,14 @@ public async Task ThrowsExceptionWithNullArguments() var store = new MongoUserOnlyStore(context); var user = await store.FindByIdAsync("1000"); - await Should.ThrowAsync(async () => + await (async () => { await store.AddLoginAsync(null, new UserLoginInfo("", "", "")); - }); - await Should.ThrowAsync(async () => + }).Should().ThrowAsync(); + await (async () => { await store.AddLoginAsync(user, null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs index a6086a7..00b7472 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -22,7 +22,7 @@ public async Task ReturnsSuccessWithStringId() var result = await store.CreateAsync(TestUser.First); - result.ShouldBe(IdentityResult.Success); + result.Should().Be(IdentityResult.Success); } [Fact] @@ -33,9 +33,9 @@ public async Task CreatesDataWithStringId() await store.CreateAsync(TestUser.First); - context.TestUsers.Any().ShouldBeTrue(); - context.TestUsers.Count().ShouldBe(1); - context.TestUsers.FirstOrDefault()?.CustomData.ShouldBe("Some Info 1"); + context.TestUsers.Any().Should().BeTrue(); + context.TestUsers.Count().Should().Be(1); + context.TestUsers.FirstOrDefault()?.CustomData.Should().Be("Some Info 1"); } [Fact] @@ -48,8 +48,8 @@ public async Task DoesNotCreatesDataWithAutoSaveOff() await store.CreateAsync(TestUser.First); - context.TestUsers.Any().ShouldBeFalse(); - context.TestUsers.Count().ShouldBe(0); + context.TestUsers.Any().Should().BeFalse(); + context.TestUsers.Count().Should().Be(0); } @@ -61,7 +61,7 @@ public async Task ReturnsSuccessWithIntId() var result = await store.CreateAsync(TestUserInt.First); - result.ShouldBe(IdentityResult.Success); + result.Should().Be(IdentityResult.Success); } [Fact] @@ -72,9 +72,9 @@ public async Task CreatesDataWithIntId() await store.CreateAsync(TestUserInt.First); - context.TestUsersInt.Any().ShouldBeTrue(); - context.TestUsersInt.Count().ShouldBe(1); - context.TestUsersInt.FirstOrDefault()?.CustomData.ShouldBe("Some Info 1"); + context.TestUsersInt.Any().Should().BeTrue(); + context.TestUsersInt.Count().Should().Be(1); + context.TestUsersInt.FirstOrDefault()?.CustomData.Should().Be("Some Info 1"); } [Fact] @@ -83,10 +83,10 @@ public async Task ThrowsExceptionWithNull() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.CreateAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs index 916a326..4c3cf3b 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -21,7 +21,7 @@ public async Task DeletesDataWithValidUser() var store = new MongoUserOnlyStore(context); await store.CreateAsync(TestUser.First); - context.TestUsers.Any().ShouldBeTrue(); + context.TestUsers.Any().Should().BeTrue(); context = new TestContext(GetConnection()); store = new MongoUserOnlyStore(context); @@ -29,7 +29,7 @@ public async Task DeletesDataWithValidUser() await store.DeleteAsync(user); - context.TestUsers.Any().ShouldBeFalse(); + context.TestUsers.Any().Should().BeFalse(); } [Fact] @@ -39,7 +39,7 @@ public async Task ReturnsSuccessWithValidUser() var store = new MongoUserOnlyStore(context); await store.CreateAsync(TestUser.First); - context.TestUsers.Any().ShouldBeTrue(); + context.TestUsers.Any().Should().BeTrue(); context = new TestContext(GetConnection()); store = new MongoUserOnlyStore(context); @@ -47,7 +47,7 @@ public async Task ReturnsSuccessWithValidUser() var result = await store.DeleteAsync(user); - result.ShouldBe(IdentityResult.Success); + result.Should().Be(IdentityResult.Success); } [Fact] @@ -56,10 +56,10 @@ public async Task ThrowsExceptionWithNull() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.DeleteAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByEmail.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByEmail.cs index 943dfd6..58a7fe9 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByEmail.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByEmail.cs @@ -1,9 +1,9 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -33,8 +33,8 @@ public async Task FindsCorrectUserWithValidEmail() var result = await store.FindByEmailAsync("TEST3@TESTING.COM"); - result.ShouldNotBeNull(); - result.UserName.ShouldBe("User Name3"); + result.Should().NotBeNull(); + result.UserName.Should().Be("User Name3"); } [Fact] @@ -47,8 +47,8 @@ public async Task FindsTrackedEntityWithValidEmail() var result = await store.FindByEmailAsync("TEST2@TESTING.COM"); - result.ShouldBeSameAs(tracked); - result.CustomData.ShouldBe("updated"); + result.Should().BeSameAs(tracked); + result.CustomData.Should().Be("updated"); } [Fact] @@ -59,7 +59,7 @@ public async Task ReturnsNullWithInvalidEmail() var result = await store.FindByEmailAsync("none"); - result.ShouldBeNull(); + result.Should().BeNull(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs index 372308e..0a9ff96 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -38,8 +38,8 @@ public async Task FindsCorrectUserWithValidStringId() var result = await store.FindByIdAsync(TestIds.UserId2); - result.ShouldNotBeNull(); - result.UserName.ShouldBe("User Name2"); + result.Should().NotBeNull(); + result.UserName.Should().Be("User Name2"); } [Fact] @@ -50,7 +50,7 @@ public async Task ReturnsNullWithInvalidStringId() var result = await store.FindByIdAsync("none"); - result.ShouldBeNull(); + result.Should().BeNull(); } [Fact] @@ -61,8 +61,8 @@ public async Task FindsCorrectUserWithValidIntId() var result = await store.FindByIdAsync("2000"); - result.ShouldNotBeNull(); - result.UserName.ShouldBe("User Name2"); + result.Should().NotBeNull(); + result.UserName.Should().Be("User Name2"); } [Fact] @@ -73,7 +73,7 @@ public async Task ReturnsNullWithInvalidIntId() var result = await store.FindByIdAsync("1234"); - result.ShouldBeNull(); + result.Should().BeNull(); } [Fact] @@ -82,10 +82,10 @@ public async Task ThrowsExceptionWithNull() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.FindByIdAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs index 279059e..4012edf 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs @@ -1,11 +1,11 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -54,8 +54,8 @@ public async Task GetsCorrectUserFromLogin() var user = await store.FindByLoginAsync("provider3", "provider-key"); - user.ShouldNotBeNull(); - user.Id.ShouldBe(TestIds.UserId2); + user.Should().NotBeNull(); + user.Id.Should().Be(TestIds.UserId2); } [Fact] @@ -66,9 +66,9 @@ public async Task GetsLoginWithUserIdAndProvider() var login = await store.ExposeFindUserLoginAsync(TestIds.UserId1, "provider2", "provider-key").ConfigureAwait(false); - login.ShouldNotBeNull(); - login.UserId.ShouldBe(TestIds.UserId1); - login.LoginProvider.ShouldBe("provider2"); + login.Should().NotBeNull(); + login.UserId.Should().Be(TestIds.UserId1); + login.LoginProvider.Should().Be("provider2"); } [Fact] @@ -79,7 +79,7 @@ public async Task ReturnsNullFromNonExisting() var user = await store.FindByLoginAsync("provider5", "provider-key"); - user.ShouldBeNull(); + user.Should().BeNull(); } [Fact] @@ -90,7 +90,7 @@ public async Task ReturnsNullFromNull() var user = await store.FindByLoginAsync(null, "provider-key"); - user.ShouldBeNull(); + user.Should().BeNull(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs index 4b20556..edc30f2 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs @@ -1,9 +1,9 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -33,8 +33,8 @@ public async Task FindsCorrectUserWithValidUserName() var result = await store.FindByNameAsync("USER NAME2"); - result.ShouldNotBeNull(); - result.UserName.ShouldBe("User Name2"); + result.Should().NotBeNull(); + result.UserName.Should().Be("User Name2"); } @@ -48,8 +48,8 @@ public async Task FindsTrackedEntityWithValidUserName() var result = await store.FindByNameAsync("USER NAME2"); - result.ShouldBeSameAs(tracked); - result.CustomData.ShouldBe("updated"); + result.Should().BeSameAs(tracked); + result.CustomData.Should().Be("updated"); } @@ -61,7 +61,7 @@ public async Task ReturnsNullWithInvalidUserName() var result = await store.FindByNameAsync("none"); - result.ShouldBeNull(); + result.Should().BeNull(); } [Fact] @@ -70,10 +70,10 @@ public async Task ThrowsExceptionWithNull() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.FindByNameAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs index 4189d11..d460e1f 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -42,8 +42,8 @@ public async Task RetrievesClaimsFromUser() var claims = await store.GetClaimsAsync(user); - claims.Count.ShouldBe(2); - claims[0].Type.ShouldBe("type"); + claims.Count.Should().Be(2); + claims[0].Type.Should().Be("type"); } [Fact] @@ -52,10 +52,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.GetClaimsAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs index 4c699e8..ba76a7b 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -38,8 +38,8 @@ public async Task RetrieveLoginsFromUser() var logins = await store.GetLoginsAsync(user); - logins.Count.ShouldBe(2); - logins[0].LoginProvider.ShouldBe("provider1"); + logins.Count.Should().Be(2); + logins[0].LoginProvider.Should().Be("provider1"); } [Fact] @@ -48,10 +48,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.GetLoginsAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs index 831bf98..053e32e 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -39,8 +39,8 @@ public async Task RetrieveLoginsFromUser() var token1 = await store.GetTokenAsync(user, "provider1", "name1", default); var token2 = await store.GetTokenAsync(user, "provider2", "name2", default); - token1.ShouldBe("token-value1"); - token2.ShouldBe("token-value2"); + token1.Should().Be("token-value1"); + token2.Should().Be("token-value2"); } [Fact] @@ -49,10 +49,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.GetTokenAsync(null, "", "", default); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs index 15483a8..5b1689e 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -60,8 +60,8 @@ public async Task RetrieveUsersForClaim() var users = await store.GetUsersForClaimAsync(new Claim("type", "value")); var users2 = await store.GetUsersForClaimAsync(new Claim("type2", "value2")); - users.Count.ShouldBe(3); - users2.Count.ShouldBe(2); + users.Count.Should().Be(3); + users2.Count.Should().Be(2); } @@ -71,10 +71,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.GetClaimsAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs index ac4909b..a05d639 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -44,7 +44,7 @@ public async Task RemoveClaimWithExistingClaim() await store.RemoveClaimsAsync(user, claims); - user.Claims.Count.ShouldBe(0); + user.Claims.Count.Should().Be(0); } [Fact] @@ -59,7 +59,7 @@ await store.RemoveClaimsAsync(user, new[] { new Claim("type2", "value2") }); - user.Claims.Count.ShouldBe(0); + user.Claims.Count.Should().Be(0); } [Fact] @@ -78,7 +78,7 @@ public async Task SavesData() store = new MongoUserOnlyStore(context); user = await store.FindByIdAsync(TestIds.UserId1); - user.Claims.Count.ShouldBe(0); + user.Claims.Count.Should().Be(0); } [Fact] @@ -88,14 +88,14 @@ public async Task ThrowsExceptionWithNullArguments() var store = new MongoUserOnlyStore(context); var user = await store.FindByIdAsync("1000"); - await Should.ThrowAsync(async () => + await (async () => { await store.RemoveClaimsAsync(null, new[] { new Claim("type", "value") }); - }); - await Should.ThrowAsync(async () => + }).Should().ThrowAsync(); + await (async () => { await store.RemoveClaimsAsync(user, null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs index 5e3a219..f34c1c9 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -37,7 +37,7 @@ public async Task RemoveLoginWithExistingLogin() await store.RemoveLoginAsync(user, "provider1", "provider-key"); - user.Logins.Count.ShouldBe(0); + user.Logins.Count.Should().Be(0); } [Fact] @@ -54,7 +54,7 @@ public async Task SavesData() store = new MongoUserOnlyStore(context); user = await store.FindByIdAsync(TestIds.UserId1); - user.Logins.Count.ShouldBe(0); + user.Logins.Count.Should().Be(0); } [Fact] @@ -63,10 +63,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.RemoveLoginAsync(null, "", ""); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs index f026a9e..222e6f3 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -38,7 +38,7 @@ public async Task RemovesToken() await store.RemoveTokenAsync(user, "provider2", "name2", default); - user.Tokens.Count.ShouldBe(1); + user.Tokens.Count.Should().Be(1); } [Fact] @@ -57,7 +57,7 @@ public async Task SavesData() user = await store.FindByIdAsync(TestIds.UserId1); - user.Tokens.Count.ShouldBe(1); + user.Tokens.Count.Should().Be(1); } [Fact] @@ -66,10 +66,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.RemoveTokenAsync(null, "", "", default); - }); + }).Should().ThrowAsync(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs index 223d80f..87ce384 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -45,8 +45,8 @@ public async Task ReplaceUsersClaim() await store.ReplaceClaimAsync(user, claim, new Claim("new-type", "new-value")); - user.Claims[0].ClaimType.ShouldBe("new-type"); - user.Claims[0].ClaimValue.ShouldBe("new-value"); + user.Claims[0].ClaimType.Should().Be("new-type"); + user.Claims[0].ClaimValue.Should().Be("new-value"); } [Fact] @@ -67,8 +67,8 @@ public async Task SavesData() store = new MongoUserOnlyStore(context); user = await store.FindByIdAsync(TestIds.UserId1); - user.Claims.Count.ShouldBe(2); - user.Claims[0].ClaimType.ShouldBe("new-type"); + user.Claims.Count.Should().Be(2); + user.Claims[0].ClaimType.Should().Be("new-type"); } [Fact] @@ -78,18 +78,18 @@ public async Task ThrowsExceptionWithNullArguments() var store = new MongoUserOnlyStore(context); var user = await store.FindByIdAsync("1000"); - await Should.ThrowAsync(async () => + await (async () => { await store.ReplaceClaimAsync(null, new Claim("type", "value"), new Claim("type", "value")); - }); - await Should.ThrowAsync(async () => + }).Should().ThrowAsync(); + await (async () => { await store.ReplaceClaimAsync(user, null, new Claim("type", "value")); - }); - await Should.ThrowAsync(async () => + }).Should().ThrowAsync(); + await (async () => { await store.ReplaceClaimAsync(user, new Claim("type", "value"), null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs index 0dba82e..925a2fa 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -33,8 +33,8 @@ public async Task UpdatesUserWithValidData() await store.SetTokenAsync(user, "provider", "name", "token-value", default); - user.Tokens.Count.ShouldBe(1); - user.Tokens[0].Value.ShouldBe("token-value"); + user.Tokens.Count.Should().Be(1); + user.Tokens[0].Value.Should().Be("token-value"); } [Fact] @@ -52,8 +52,8 @@ public async Task SavesData() store = new MongoUserOnlyStore(context); user = await store.FindByIdAsync(TestIds.UserId1); - user.Tokens.Count.ShouldBe(1); - user.Tokens[0].Value.ShouldBe("token-value"); + user.Tokens.Count.Should().Be(1); + user.Tokens[0].Value.Should().Be("token-value"); } [Fact] @@ -62,10 +62,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.SetTokenAsync(null, "", "", "", default); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs index e1ce06d..6437ce6 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs @@ -1,9 +1,9 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -35,7 +35,7 @@ public async Task ReturnsSuccess() user.CustomData = "new-data"; var result = await store.UpdateAsync(user); - result.ShouldBe(IdentityResult.Success); + result.Should().Be(IdentityResult.Success); } [Fact] @@ -49,7 +49,7 @@ public async Task SavesData() user.CustomData = "new-data"; await store.UpdateAsync(user); - context.TestUsers.FirstOrDefault()?.CustomData.ShouldBe("new-data"); + context.TestUsers.FirstOrDefault()?.CustomData.Should().Be("new-data"); } [Fact] @@ -58,10 +58,10 @@ public async Task ThrowsExceptionWithNull() var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.UpdateAsync(null); - }); + }).Should().ThrowAsync(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs index 446d097..a8bc27c 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs @@ -1,9 +1,9 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserStoreTests @@ -33,8 +33,8 @@ public async Task FindsCorrectUserWithValidEmail() var result = await store.FindByEmailAsync("TEST3@TESTING.COM"); - result.ShouldNotBeNull(); - result.UserName.ShouldBe("User Name3"); + result.Should().NotBeNull(); + result.UserName.Should().Be("User Name3"); } [Fact] @@ -47,8 +47,8 @@ public async Task FindsTrackedEntityWithValidEmail() var result = await store.FindByEmailAsync("TEST2@TESTING.COM"); - result.ShouldBeSameAs(tracked); - result.CustomData.ShouldBe("updated"); + result.Should().BeSameAs(tracked); + result.CustomData.Should().Be("updated"); } [Fact] @@ -59,7 +59,7 @@ public async Task ReturnsNullWithInvalidEmail() var result = await store.FindByEmailAsync("none"); - result.ShouldBeNull(); + result.Should().BeNull(); } [Fact] @@ -68,10 +68,10 @@ public async Task ThrowsExceptionWithNull() var context = new TestContext(GetConnection()); var store = new MongoUserStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.FindByEmailAsync(null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs index 4760c4d..6852923 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs @@ -1,11 +1,11 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserStoreTests @@ -54,8 +54,8 @@ public async Task GetsCorrectUserFromLogin() var user = await store.FindByLoginAsync("provider3", "provider-key"); - user.ShouldNotBeNull(); - user.Id.ShouldBe(TestIds.UserId2); + user.Should().NotBeNull(); + user.Id.Should().Be(TestIds.UserId2); } [Fact] @@ -66,9 +66,9 @@ public async Task GetsLoginWithUserIdAndProvider() var login = await store.ExposeFindUserLoginAsync(TestIds.UserId1, "provider2", "provider-key").ConfigureAwait(false); - login.ShouldNotBeNull(); - login.UserId.ShouldBe(TestIds.UserId1); - login.LoginProvider.ShouldBe("provider2"); + login.Should().NotBeNull(); + login.UserId.Should().Be(TestIds.UserId1); + login.LoginProvider.Should().Be("provider2"); } [Fact] @@ -79,7 +79,7 @@ public async Task ReturnsNullFromNonExisting() var user = await store.FindByLoginAsync("provider5", "provider-key"); - user.ShouldBeNull(); + user.Should().BeNull(); } [Fact] @@ -90,7 +90,7 @@ public async Task ReturnsNullFromNull() var user = await store.FindByLoginAsync(null, "provider-key"); - user.ShouldBeNull(); + user.Should().BeNull(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByName.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByName.cs index 6f6a6d6..624ca4c 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByName.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByName.cs @@ -1,9 +1,9 @@ -using System; +using System; using System.Linq; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserStoreTests @@ -33,8 +33,8 @@ public async Task FindsCorrectUserWithValidUserName() var result = await store.FindByNameAsync("USER NAME2"); - result.ShouldNotBeNull(); - result.UserName.ShouldBe("User Name2"); + result.Should().NotBeNull(); + result.UserName.Should().Be("User Name2"); } @@ -48,8 +48,8 @@ public async Task FindsTrackedEntityWithValidUserName() var result = await store.FindByNameAsync("USER NAME2"); - result.ShouldBeSameAs(tracked); - result.CustomData.ShouldBe("updated"); + result.Should().BeSameAs(tracked); + result.CustomData.Should().Be("updated"); } @@ -61,7 +61,7 @@ public async Task ReturnsNullWithInvalidUserName() var result = await store.FindByNameAsync("none"); - result.ShouldBeNull(); + result.Should().BeNull(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs index 1287463..b11a975 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading; @@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserStoreTests @@ -53,9 +53,9 @@ public async Task FindUserRoleWithValidRole() var role = await store.ExposeFindUserRoleAsync(TestIds.UserId1, TestIds.RoleId1); - role.ShouldNotBeNull(); - role.RoleId.ShouldBe(TestIds.RoleId1); - role.UserId.ShouldBe(TestIds.UserId1); } + role.Should().NotBeNull(); + role.RoleId.Should().Be(TestIds.RoleId1); + role.UserId.Should().Be(TestIds.UserId1); } [Fact] public async Task FindUserRoleFailsWithInvalidRole() @@ -65,7 +65,7 @@ public async Task FindUserRoleFailsWithInvalidRole() var role = await store.ExposeFindUserRoleAsync("a1", "none-rid1"); - role.ShouldBeNull(); + role.Should().BeNull(); } [Fact] @@ -76,7 +76,7 @@ public async Task FindUserRoleFailsWithInvaliUser() var role = await store.ExposeFindUserRoleAsync("none-a1", "rid1"); - role.ShouldBeNull(); + role.Should().BeNull(); } [Fact] @@ -85,14 +85,14 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new TestStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.ExposeFindUserRoleAsync(null, "rid1"); - }); - await Should.ThrowAsync(async () => + }).Should().ThrowAsync(); + await (async () => { await store.ExposeFindUserRoleAsync("a1", null); - }); + }).Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs index f7f2ad2..c252131 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs @@ -1,10 +1,10 @@ -using System; +using System; using System.Linq; using System.Security.Claims; using System.Threading.Tasks; using Microsoft.AspNetCore.Identity; using MongoEntityFramework.AspNetCore.Identity.Tests.TestClasses; -using Shouldly; +using AwesomeAssertions; using Xunit; namespace MongoEntityFramework.AspNetCore.Identity.Tests.MongoUserOnlyStoreTests @@ -43,8 +43,8 @@ public async Task GetRolesWithUser() var roles = await store.GetRolesAsync(user); - roles.Count.ShouldBe(2); - roles[0].ShouldBe("Role 1"); + roles.Count.Should().Be(2); + roles[0].Should().Be("Role 1"); } [Fact] @@ -53,10 +53,10 @@ public async Task ThrowsExceptionWithNullArguments() var context = new TestContext(GetConnection()); var store = new MongoUserStore(context); - await Should.ThrowAsync(async () => + await (async () => { await store.GetRolesAsync(null); - }); + }).Should().ThrowAsync(); } } From b08218069a01dbd383a8deb69e5987e8fe21b95f Mon Sep 17 00:00:00 2001 From: John Campion Jr Date: Mon, 27 Oct 2025 10:25:53 -0400 Subject: [PATCH 3/7] chore: fix nullable errors --- .../MongoIdentityClaims.cs | 10 +++++----- .../MongoUserOnlyStoreTests/FindByLogin.cs | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/MongoFramework.AspNetCore.Identity/MongoIdentityClaims.cs b/src/MongoFramework.AspNetCore.Identity/MongoIdentityClaims.cs index f0a9319..eee253a 100644 --- a/src/MongoFramework.AspNetCore.Identity/MongoIdentityClaims.cs +++ b/src/MongoFramework.AspNetCore.Identity/MongoIdentityClaims.cs @@ -21,12 +21,12 @@ public class MongoIdentityUserClaim where TKey : IEquatable /// /// Gets or sets the claim type for this claim. /// - public virtual string? ClaimType { get; set; } + public virtual string ClaimType { get; set; } /// /// Gets or sets the claim value for this claim. /// - public virtual string? ClaimValue { get; set; } + public virtual string ClaimValue { get; set; } /// /// Converts the entity into a Claim instance. @@ -63,12 +63,12 @@ public class MongoIdentityRoleClaim where TKey : IEquatable /// /// Gets or sets the claim type for this claim. /// - public virtual string? ClaimType { get; set; } + public virtual string ClaimType { get; set; } /// /// Gets or sets the claim value for this claim. /// - public virtual string? ClaimValue { get; set; } + public virtual string ClaimValue { get; set; } /// /// Constructs a new claim with the type and value. @@ -83,7 +83,7 @@ public virtual Claim ToClaim() /// Initializes by copying ClaimType and ClaimValue from the other claim. /// /// The claim to initialize from. - public virtual void InitializeFromClaim(Claim? other) + public virtual void InitializeFromClaim(Claim other) { ClaimType = other?.Type; ClaimValue = other?.Value; diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs index 4012edf..1182b7b 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByLogin.cs @@ -64,7 +64,7 @@ public async Task GetsLoginWithUserIdAndProvider() var context = new TestContext(GetConnection()); var store = new TestStore(context); - var login = await store.ExposeFindUserLoginAsync(TestIds.UserId1, "provider2", "provider-key").ConfigureAwait(false); + var login = await store.ExposeFindUserLoginAsync(TestIds.UserId1, "provider2", "provider-key"); login.Should().NotBeNull(); login.UserId.Should().Be(TestIds.UserId1); From d2eb22edf82d2d3f80aab4c50a5c03303f2169e6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Oct 2025 14:27:49 +0000 Subject: [PATCH 4/7] Fix exception tests to use synchronous Throw pattern Changed async exception tests to use synchronous pattern as requested: - Removed async keyword from test method signatures - Changed await ThrowAsync pattern to synchronous act.Should().Throw() - Replaced await calls with direct object instantiation where needed - Fixed duplicate variable names in tests with multiple assertions Co-authored-by: JohnCampionJr <1094820+JohnCampionJr@users.noreply.github.com> --- .../MongoUserOnlyStoreTests/AddClaims.cs | 18 +++++++------ .../MongoUserOnlyStoreTests/AddLogin.cs | 18 +++++++------ .../MongoUserOnlyStoreTests/CreateUser.cs | 9 ++++--- .../MongoUserOnlyStoreTests/DeleteUser.cs | 9 ++++--- .../MongoUserOnlyStoreTests/FindById.cs | 9 ++++--- .../MongoUserOnlyStoreTests/FindByName.cs | 9 ++++--- .../MongoUserOnlyStoreTests/GetClaims.cs | 9 ++++--- .../MongoUserOnlyStoreTests/GetLogins.cs | 9 ++++--- .../MongoUserOnlyStoreTests/GetToken.cs | 9 ++++--- .../GetUsersForClaim.cs | 9 ++++--- .../MongoUserOnlyStoreTests/RemoveClaim.cs | 18 +++++++------ .../MongoUserOnlyStoreTests/RemoveLogin.cs | 9 ++++--- .../MongoUserOnlyStoreTests/RemoveToken.cs | 9 ++++--- .../MongoUserOnlyStoreTests/ReplaceClaim.cs | 25 +++++++++++-------- .../MongoUserOnlyStoreTests/SetToken.cs | 9 ++++--- .../MongoUserOnlyStoreTests/UpdateUser.cs | 9 ++++--- .../MongoUserStoreTests/FindByEmail.cs | 9 ++++--- .../MongoUserStoreTests/FindUserRole.cs | 16 ++++++------ .../MongoUserStoreTests/GetRoles.cs | 9 ++++--- 19 files changed, 123 insertions(+), 98 deletions(-) diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs index 6f92730..af9b11a 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs @@ -67,20 +67,22 @@ await store.AddClaimsAsync(user, } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var user = await store.FindByIdAsync("1000"); + var user = new TestUser(); - await (async () => + var act = () => { - await store.AddClaimsAsync(null, new[] { new Claim("type", "value") }); - }).Should().ThrowAsync(); - await (async () => + var _ = store.AddClaimsAsync(null, new[] { new Claim("type", "value") }); + }; + act.Should().Throw(); + var act1 = () => { - await store.AddClaimsAsync(user, null); - }).Should().ThrowAsync(); + var _ = store.AddClaimsAsync(user, null); + }; + act1.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs index 0eb4355..5176ad3 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs @@ -58,20 +58,22 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var user = await store.FindByIdAsync("1000"); + var user = new TestUser(); - await (async () => + var act = () => { - await store.AddLoginAsync(null, new UserLoginInfo("", "", "")); - }).Should().ThrowAsync(); - await (async () => + var _ = store.AddLoginAsync(null, new UserLoginInfo("", "", "")); + }; + act.Should().Throw(); + var act1 = () => { - await store.AddLoginAsync(user, null); - }).Should().ThrowAsync(); + var _ = store.AddLoginAsync(user, null); + }; + act1.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs index 00b7472..3cc3281 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs @@ -78,15 +78,16 @@ public async Task CreatesDataWithIntId() } [Fact] - public async Task ThrowsExceptionWithNull() + public Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.CreateAsync(null); - }).Should().ThrowAsync(); + var _ = store.CreateAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs index 4c3cf3b..3b123d8 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs @@ -51,15 +51,16 @@ public async Task ReturnsSuccessWithValidUser() } [Fact] - public async Task ThrowsExceptionWithNull() + public Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.DeleteAsync(null); - }).Should().ThrowAsync(); + var _ = store.DeleteAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs index 0a9ff96..c3b22e7 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs @@ -77,15 +77,16 @@ public async Task ReturnsNullWithInvalidIntId() } [Fact] - public async Task ThrowsExceptionWithNull() + public Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.FindByIdAsync(null); - }).Should().ThrowAsync(); + var _ = store.FindByIdAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs index edc30f2..4bc05d4 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs @@ -65,15 +65,16 @@ public async Task ReturnsNullWithInvalidUserName() } [Fact] - public async Task ThrowsExceptionWithNull() + public Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.FindByNameAsync(null); - }).Should().ThrowAsync(); + var _ = store.FindByNameAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs index d460e1f..94320fe 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs @@ -47,15 +47,16 @@ public async Task RetrievesClaimsFromUser() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.GetClaimsAsync(null); - }).Should().ThrowAsync(); + var _ = store.GetClaimsAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs index ba76a7b..d156217 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs @@ -43,15 +43,16 @@ public async Task RetrieveLoginsFromUser() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.GetLoginsAsync(null); - }).Should().ThrowAsync(); + var _ = store.GetLoginsAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs index 053e32e..3968146 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs @@ -44,15 +44,16 @@ public async Task RetrieveLoginsFromUser() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.GetTokenAsync(null, "", "", default); - }).Should().ThrowAsync(); + var _ = store.GetTokenAsync(null, "", "", default); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs index 5b1689e..8a035cc 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs @@ -66,15 +66,16 @@ public async Task RetrieveUsersForClaim() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.GetClaimsAsync(null); - }).Should().ThrowAsync(); + var _ = store.GetClaimsAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs index a05d639..fe5c35e 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs @@ -82,20 +82,22 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var user = await store.FindByIdAsync("1000"); + var user = new TestUser(); - await (async () => + var act = () => { - await store.RemoveClaimsAsync(null, new[] { new Claim("type", "value") }); - }).Should().ThrowAsync(); - await (async () => + var _ = store.RemoveClaimsAsync(null, new[] { new Claim("type", "value") }); + }; + act.Should().Throw(); + var act1 = () => { - await store.RemoveClaimsAsync(user, null); - }).Should().ThrowAsync(); + var _ = store.RemoveClaimsAsync(user, null); + }; + act1.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs index f34c1c9..0176f10 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs @@ -58,15 +58,16 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.RemoveLoginAsync(null, "", ""); - }).Should().ThrowAsync(); + var _ = store.RemoveLoginAsync(null, "", ""); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs index 222e6f3..bc09330 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs @@ -61,15 +61,16 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.RemoveTokenAsync(null, "", "", default); - }).Should().ThrowAsync(); + var _ = store.RemoveTokenAsync(null, "", "", default); + }; + act.Should().Throw(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs index 87ce384..2bc28e7 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs @@ -72,24 +72,27 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var user = await store.FindByIdAsync("1000"); + var user = new TestUser(); - await (async () => + var act = () => { - await store.ReplaceClaimAsync(null, new Claim("type", "value"), new Claim("type", "value")); - }).Should().ThrowAsync(); - await (async () => + var _ = store.ReplaceClaimAsync(null, new Claim("type", "value"), new Claim("type", "value")); + }; + act.Should().Throw(); + var act1 = () => { - await store.ReplaceClaimAsync(user, null, new Claim("type", "value")); - }).Should().ThrowAsync(); - await (async () => + var _ = store.ReplaceClaimAsync(user, null, new Claim("type", "value")); + }; + act1.Should().Throw(); + var act2 = () => { - await store.ReplaceClaimAsync(user, new Claim("type", "value"), null); - }).Should().ThrowAsync(); + var _ = store.ReplaceClaimAsync(user, new Claim("type", "value"), null); + }; + act2.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs index 925a2fa..8ad43f4 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs @@ -57,15 +57,16 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.SetTokenAsync(null, "", "", "", default); - }).Should().ThrowAsync(); + var _ = store.SetTokenAsync(null, "", "", "", default); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs index 6437ce6..6cb97f4 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs @@ -53,15 +53,16 @@ public async Task SavesData() } [Fact] - public async Task ThrowsExceptionWithNull() + public Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - await (async () => + var act = () => { - await store.UpdateAsync(null); - }).Should().ThrowAsync(); + var _ = store.UpdateAsync(null); + }; + act.Should().Throw(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs index a8bc27c..1708717 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs @@ -63,15 +63,16 @@ public async Task ReturnsNullWithInvalidEmail() } [Fact] - public async Task ThrowsExceptionWithNull() + public Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserStore(context); - await (async () => + var act = () => { - await store.FindByEmailAsync(null); - }).Should().ThrowAsync(); + var _ = store.FindByEmailAsync(null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs index b11a975..d2861ad 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs @@ -80,19 +80,21 @@ public async Task FindUserRoleFailsWithInvaliUser() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new TestStore(context); - await (async () => + var act = () => { - await store.ExposeFindUserRoleAsync(null, "rid1"); - }).Should().ThrowAsync(); - await (async () => + var _ = store.ExposeFindUserRoleAsync(null, "rid1"); + }; + act.Should().Throw(); + var act = () => { - await store.ExposeFindUserRoleAsync("a1", null); - }).Should().ThrowAsync(); + var _ = store.ExposeFindUserRoleAsync("a1", null); + }; + act.Should().Throw(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs index c252131..ed5217e 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs @@ -48,15 +48,16 @@ public async Task GetRolesWithUser() } [Fact] - public async Task ThrowsExceptionWithNullArguments() + public Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserStore(context); - await (async () => + var act = () => { - await store.GetRolesAsync(null); - }).Should().ThrowAsync(); + var _ = store.GetRolesAsync(null); + }; + act.Should().Throw(); } } From 0c2673718531cfe40c4f6ab8367f5e239411f982 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Oct 2025 14:42:32 +0000 Subject: [PATCH 5/7] Add return Task.CompletedTask to exception test methods Fixed compilation errors where Task methods were not returning a value. All exception test methods now properly return Task.CompletedTask. Co-authored-by: JohnCampionJr <1094820+JohnCampionJr@users.noreply.github.com> --- .../MongoUserOnlyStoreTests/AddClaims.cs | 1 + .../MongoUserOnlyStoreTests/AddLogin.cs | 1 + .../MongoUserOnlyStoreTests/CreateUser.cs | 1 + .../MongoUserOnlyStoreTests/DeleteUser.cs | 1 + .../MongoUserOnlyStoreTests/FindById.cs | 1 + .../MongoUserOnlyStoreTests/FindByName.cs | 1 + .../MongoUserOnlyStoreTests/GetClaims.cs | 1 + .../MongoUserOnlyStoreTests/GetLogins.cs | 1 + .../MongoUserOnlyStoreTests/GetToken.cs | 1 + .../MongoUserOnlyStoreTests/GetUsersForClaim.cs | 1 + .../MongoUserOnlyStoreTests/RemoveClaim.cs | 1 + .../MongoUserOnlyStoreTests/RemoveLogin.cs | 1 + .../MongoUserOnlyStoreTests/RemoveToken.cs | 1 + .../MongoUserOnlyStoreTests/ReplaceClaim.cs | 1 + .../MongoUserOnlyStoreTests/SetToken.cs | 1 + .../MongoUserOnlyStoreTests/UpdateUser.cs | 1 + .../MongoUserStoreTests/FindByEmail.cs | 1 + .../MongoUserStoreTests/FindUserRole.cs | 5 +++-- .../MongoUserStoreTests/GetRoles.cs | 1 + 19 files changed, 21 insertions(+), 2 deletions(-) diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs index af9b11a..4afabe8 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs @@ -83,6 +83,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.AddClaimsAsync(user, null); }; act1.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs index 5176ad3..6bbcd39 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs @@ -74,6 +74,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.AddLoginAsync(user, null); }; act1.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs index 3cc3281..8b83d4a 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs @@ -88,6 +88,7 @@ public Task ThrowsExceptionWithNull() var _ = store.CreateAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs index 3b123d8..984221b 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs @@ -61,6 +61,7 @@ public Task ThrowsExceptionWithNull() var _ = store.DeleteAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs index c3b22e7..762fc26 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs @@ -87,6 +87,7 @@ public Task ThrowsExceptionWithNull() var _ = store.FindByIdAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs index 4bc05d4..835b495 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs @@ -75,6 +75,7 @@ public Task ThrowsExceptionWithNull() var _ = store.FindByNameAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs index 94320fe..97370c6 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs @@ -57,6 +57,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.GetClaimsAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs index d156217..6bb655e 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs @@ -53,6 +53,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.GetLoginsAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs index 3968146..7997ba0 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs @@ -54,6 +54,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.GetTokenAsync(null, "", "", default); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs index 8a035cc..f3850b7 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs @@ -76,6 +76,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.GetClaimsAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs index fe5c35e..8c993ef 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs @@ -98,6 +98,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.RemoveClaimsAsync(user, null); }; act1.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs index 0176f10..fca69b7 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs @@ -68,6 +68,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.RemoveLoginAsync(null, "", ""); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs index bc09330..5f83d90 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs @@ -71,6 +71,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.RemoveTokenAsync(null, "", "", default); }; act.Should().Throw(); + return Task.CompletedTask; } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs index 2bc28e7..3fd5ef7 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs @@ -93,6 +93,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.ReplaceClaimAsync(user, new Claim("type", "value"), null); }; act2.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs index 8ad43f4..598928f 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs @@ -67,6 +67,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.SetTokenAsync(null, "", "", "", default); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs index 6cb97f4..24a9d30 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs @@ -63,6 +63,7 @@ public Task ThrowsExceptionWithNull() var _ = store.UpdateAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs index 1708717..265b1d3 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs @@ -73,6 +73,7 @@ public Task ThrowsExceptionWithNull() var _ = store.FindByEmailAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs index d2861ad..76e6561 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs @@ -90,11 +90,12 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.ExposeFindUserRoleAsync(null, "rid1"); }; act.Should().Throw(); - var act = () => + var act1 = () => { var _ = store.ExposeFindUserRoleAsync("a1", null); }; - act.Should().Throw(); + act1.Should().Throw(); + return Task.CompletedTask; } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs index ed5217e..6d64c30 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs @@ -58,6 +58,7 @@ public Task ThrowsExceptionWithNullArguments() var _ = store.GetRolesAsync(null); }; act.Should().Throw(); + return Task.CompletedTask; } } From 4e9a765ae0e8e819b8111f88cd36e432d2bd83b1 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Oct 2025 14:50:53 +0000 Subject: [PATCH 6/7] Convert exception tests to use async ThrowAsync pattern Changed all exception tests to use async lambdas with await and ThrowAsync: - Method signatures changed from 'public Task' to 'public async Task' - Lambdas changed from synchronous to async with await - Changed .Throw() to .ThrowAsync() - Added await before assertions - Removed return Task.CompletedTask statements Co-authored-by: JohnCampionJr <1094820+JohnCampionJr@users.noreply.github.com> --- .../MongoUserOnlyStoreTests/AddClaims.cs | 15 +++++++------ .../MongoUserOnlyStoreTests/AddLogin.cs | 15 +++++++------ .../MongoUserOnlyStoreTests/CreateUser.cs | 9 ++++---- .../MongoUserOnlyStoreTests/DeleteUser.cs | 9 ++++---- .../MongoUserOnlyStoreTests/FindById.cs | 9 ++++---- .../MongoUserOnlyStoreTests/FindByName.cs | 9 ++++---- .../MongoUserOnlyStoreTests/GetClaims.cs | 9 ++++---- .../MongoUserOnlyStoreTests/GetLogins.cs | 9 ++++---- .../MongoUserOnlyStoreTests/GetToken.cs | 9 ++++---- .../GetUsersForClaim.cs | 9 ++++---- .../MongoUserOnlyStoreTests/RemoveClaim.cs | 15 +++++++------ .../MongoUserOnlyStoreTests/RemoveLogin.cs | 9 ++++---- .../MongoUserOnlyStoreTests/RemoveToken.cs | 9 ++++---- .../MongoUserOnlyStoreTests/ReplaceClaim.cs | 21 +++++++++---------- .../MongoUserOnlyStoreTests/SetToken.cs | 9 ++++---- .../MongoUserOnlyStoreTests/UpdateUser.cs | 9 ++++---- .../MongoUserStoreTests/FindByEmail.cs | 9 ++++---- .../MongoUserStoreTests/FindUserRole.cs | 15 +++++++------ .../MongoUserStoreTests/GetRoles.cs | 9 ++++---- 19 files changed, 94 insertions(+), 113 deletions(-) diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs index 4afabe8..c35cb93 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddClaims.cs @@ -67,23 +67,22 @@ await store.AddClaimsAsync(user, } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); var user = new TestUser(); - var act = () => + var act = async () => { - var _ = store.AddClaimsAsync(null, new[] { new Claim("type", "value") }); + await store.AddClaimsAsync(null, new[] { new Claim("type", "value") }); }; - act.Should().Throw(); - var act1 = () => + await act.Should().ThrowAsync(); + var act1 = async () => { - var _ = store.AddClaimsAsync(user, null); + await store.AddClaimsAsync(user, null); }; - act1.Should().Throw(); - return Task.CompletedTask; + await act1.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs index 6bbcd39..b9f12de 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/AddLogin.cs @@ -58,23 +58,22 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); var user = new TestUser(); - var act = () => + var act = async () => { - var _ = store.AddLoginAsync(null, new UserLoginInfo("", "", "")); + await store.AddLoginAsync(null, new UserLoginInfo("", "", "")); }; - act.Should().Throw(); - var act1 = () => + await act.Should().ThrowAsync(); + var act1 = async () => { - var _ = store.AddLoginAsync(user, null); + await store.AddLoginAsync(user, null); }; - act1.Should().Throw(); - return Task.CompletedTask; + await act1.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs index 8b83d4a..18d5a71 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/CreateUser.cs @@ -78,17 +78,16 @@ public async Task CreatesDataWithIntId() } [Fact] - public Task ThrowsExceptionWithNull() + public async Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.CreateAsync(null); + await store.CreateAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs index 984221b..a81a96f 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/DeleteUser.cs @@ -51,17 +51,16 @@ public async Task ReturnsSuccessWithValidUser() } [Fact] - public Task ThrowsExceptionWithNull() + public async Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.DeleteAsync(null); + await store.DeleteAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs index 762fc26..d6cf956 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindById.cs @@ -77,17 +77,16 @@ public async Task ReturnsNullWithInvalidIntId() } [Fact] - public Task ThrowsExceptionWithNull() + public async Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.FindByIdAsync(null); + await store.FindByIdAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs index 835b495..6a85638 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/FindByName.cs @@ -65,17 +65,16 @@ public async Task ReturnsNullWithInvalidUserName() } [Fact] - public Task ThrowsExceptionWithNull() + public async Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.FindByNameAsync(null); + await store.FindByNameAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs index 97370c6..1c8d99a 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetClaims.cs @@ -47,17 +47,16 @@ public async Task RetrievesClaimsFromUser() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.GetClaimsAsync(null); + await store.GetClaimsAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs index 6bb655e..d82d55c 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetLogins.cs @@ -43,17 +43,16 @@ public async Task RetrieveLoginsFromUser() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.GetLoginsAsync(null); + await store.GetLoginsAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs index 7997ba0..6cc9c9b 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetToken.cs @@ -44,17 +44,16 @@ public async Task RetrieveLoginsFromUser() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.GetTokenAsync(null, "", "", default); + await store.GetTokenAsync(null, "", "", default); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs index f3850b7..c51dab3 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/GetUsersForClaim.cs @@ -66,17 +66,16 @@ public async Task RetrieveUsersForClaim() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.GetClaimsAsync(null); + await store.GetClaimsAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs index 8c993ef..a21e0ee 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveClaim.cs @@ -82,23 +82,22 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); var user = new TestUser(); - var act = () => + var act = async () => { - var _ = store.RemoveClaimsAsync(null, new[] { new Claim("type", "value") }); + await store.RemoveClaimsAsync(null, new[] { new Claim("type", "value") }); }; - act.Should().Throw(); - var act1 = () => + await act.Should().ThrowAsync(); + var act1 = async () => { - var _ = store.RemoveClaimsAsync(user, null); + await store.RemoveClaimsAsync(user, null); }; - act1.Should().Throw(); - return Task.CompletedTask; + await act1.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs index fca69b7..6d9bf29 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveLogin.cs @@ -58,17 +58,16 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.RemoveLoginAsync(null, "", ""); + await store.RemoveLoginAsync(null, "", ""); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs index 5f83d90..5b3e873 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/RemoveToken.cs @@ -61,17 +61,16 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.RemoveTokenAsync(null, "", "", default); + await store.RemoveTokenAsync(null, "", "", default); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs index 3fd5ef7..66472fc 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/ReplaceClaim.cs @@ -72,28 +72,27 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); var user = new TestUser(); - var act = () => + var act = async () => { - var _ = store.ReplaceClaimAsync(null, new Claim("type", "value"), new Claim("type", "value")); + await store.ReplaceClaimAsync(null, new Claim("type", "value"), new Claim("type", "value")); }; - act.Should().Throw(); - var act1 = () => + await act.Should().ThrowAsync(); + var act1 = async () => { - var _ = store.ReplaceClaimAsync(user, null, new Claim("type", "value")); + await store.ReplaceClaimAsync(user, null, new Claim("type", "value")); }; - act1.Should().Throw(); - var act2 = () => + await act1.Should().ThrowAsync(); + var act2 = async () => { - var _ = store.ReplaceClaimAsync(user, new Claim("type", "value"), null); + await store.ReplaceClaimAsync(user, new Claim("type", "value"), null); }; - act2.Should().Throw(); - return Task.CompletedTask; + await act2.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs index 598928f..7195bfa 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/SetToken.cs @@ -57,17 +57,16 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.SetTokenAsync(null, "", "", "", default); + await store.SetTokenAsync(null, "", "", "", default); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs index 24a9d30..d16d02c 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserOnlyStoreTests/UpdateUser.cs @@ -53,17 +53,16 @@ public async Task SavesData() } [Fact] - public Task ThrowsExceptionWithNull() + public async Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserOnlyStore(context); - var act = () => + var act = async () => { - var _ = store.UpdateAsync(null); + await store.UpdateAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs index 265b1d3..90c6288 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByEmail.cs @@ -63,17 +63,16 @@ public async Task ReturnsNullWithInvalidEmail() } [Fact] - public Task ThrowsExceptionWithNull() + public async Task ThrowsExceptionWithNull() { var context = new TestContext(GetConnection()); var store = new MongoUserStore(context); - var act = () => + var act = async () => { - var _ = store.FindByEmailAsync(null); + await store.FindByEmailAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs index 76e6561..f0ad960 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindUserRole.cs @@ -80,22 +80,21 @@ public async Task FindUserRoleFailsWithInvaliUser() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new TestStore(context); - var act = () => + var act = async () => { - var _ = store.ExposeFindUserRoleAsync(null, "rid1"); + await store.ExposeFindUserRoleAsync(null, "rid1"); }; - act.Should().Throw(); - var act1 = () => + await act.Should().ThrowAsync(); + var act1 = async () => { - var _ = store.ExposeFindUserRoleAsync("a1", null); + await store.ExposeFindUserRoleAsync("a1", null); }; - act1.Should().Throw(); - return Task.CompletedTask; + await act1.Should().ThrowAsync(); } } diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs index 6d64c30..e3a82ce 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/GetRoles.cs @@ -48,17 +48,16 @@ public async Task GetRolesWithUser() } [Fact] - public Task ThrowsExceptionWithNullArguments() + public async Task ThrowsExceptionWithNullArguments() { var context = new TestContext(GetConnection()); var store = new MongoUserStore(context); - var act = () => + var act = async () => { - var _ = store.GetRolesAsync(null); + await store.GetRolesAsync(null); }; - act.Should().Throw(); - return Task.CompletedTask; + await act.Should().ThrowAsync(); } } From bb23db501115fff549b09f66a2ffaafa05917c56 Mon Sep 17 00:00:00 2001 From: John Campion Jr Date: Mon, 27 Oct 2025 11:35:07 -0400 Subject: [PATCH 7/7] fix warning on configureawait --- .../MongoUserStoreTests/FindByLogin.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs index 6852923..a5b5ad4 100644 --- a/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs +++ b/tests/MongoFramework.AspNetCore.Identity.Tests/MongoUserStoreTests/FindByLogin.cs @@ -64,7 +64,7 @@ public async Task GetsLoginWithUserIdAndProvider() var context = new TestContext(GetConnection()); var store = new TestStore(context); - var login = await store.ExposeFindUserLoginAsync(TestIds.UserId1, "provider2", "provider-key").ConfigureAwait(false); + var login = await store.ExposeFindUserLoginAsync(TestIds.UserId1, "provider2", "provider-key"); login.Should().NotBeNull(); login.UserId.Should().Be(TestIds.UserId1);