Skip to content

Commit 2586696

Browse files
authored
Merge pull request #80 from jglick/comment
Comment & annotation fix
2 parents 38c363a + 042ec4c commit 2586696

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/main/java/org/jenkinsci/plugins/workflow/log/TaskListenerDecorator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
import java.util.stream.Stream;
4949
import javax.annotation.CheckForNull;
5050
import javax.annotation.Nonnull;
51+
import javax.annotation.Nullable;
5152
import jenkins.util.BuildListenerAdapter;
5253
import jenkins.util.JenkinsJVM;
5354
import org.jenkinsci.plugins.workflow.flow.FlowExecutionOwner;
@@ -87,7 +88,7 @@ public abstract class TaskListenerDecorator implements /* TODO Remotable */ Seri
8788
* @param subsequent an overriding decorator, if any
8889
* @return null, or {@code original} or {@code subsequent}, or a merged result applying one then the other
8990
*/
90-
public static @CheckForNull TaskListenerDecorator merge(@CheckForNull TaskListenerDecorator original, @CheckForNull TaskListenerDecorator subsequent) {
91+
public static @Nullable TaskListenerDecorator merge(@CheckForNull TaskListenerDecorator original, @CheckForNull TaskListenerDecorator subsequent) {
9192
if (original == null) {
9293
if (subsequent == null) {
9394
return null;

src/test/java/org/jenkinsci/plugins/workflow/log/LogStorageTestBase.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.util.concurrent.Callable;
3939
import java.util.function.BiFunction;
4040
import java.util.logging.Logger;
41-
import jenkins.security.ConfidentialStore;
4241
import jenkins.security.MasterToSlaveCallable;
4342
import org.apache.commons.io.IOUtils;
4443
import org.apache.commons.io.output.NullOutputStream;
@@ -60,7 +59,6 @@ public abstract class LogStorageTestBase {
6059
System.setProperty("line.separator", "\n");
6160
}
6261

63-
/** Needed since {@link ConsoleAnnotators} will not work without encryption, and currently {@link ConfidentialStore#get} has no fallback mode for unit tests accessible except via package-local. */
6462
@ClassRule public static JenkinsRule r = new JenkinsRule();
6563

6664
/** Create a new storage implementation, but potentially reusing any data initialized in the last {@link Before} setup. */

0 commit comments

Comments
 (0)