fix(connector): issue #96 normalize HTTP headers to lowercase to prevent duplicates (#98)

* fix(connector): normalize HTTP headers to lowercase to prevent duplicates

Fixes #96

Convert all HTTP header names to lowercase per RFC 7230. This prevents
duplicate headers when servers respond with 'mcp-protocol-version' and
the client adds 'MCP-Protocol-Version', which caused 400 Bad Request
errors in Express-based servers.

* chore: formating

* chore: small improvement for commit message

* chore(release): bump version to 0.18.2

Author: jonigl

DEV.md

@@ -58,8 +58,8 @@ To create a new release:
 
 2. Commit the changes:
    ```bash
-   git add .
-   git commit -m "Bump version to X.Y.Z"
+   git add -A
+   git commit -m "chore(release): bump version to X.Y.Z"
    ```
 
 3. Push the changes and create a tag:

cli-package/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "ollmcp"
-version = "0.18.1"
+version = "0.18.2"
 description = "CLI for MCP Client for Ollama - An easy-to-use command for interacting with Ollama through MCP"
 readme = "README.md"
 requires-python = ">=3.10"
@@ -9,7 +9,7 @@ authors = [
     {name = "Jonathan Löwenstern"}
 ]
 dependencies = [
-    "mcp-client-for-ollama==0.18.1"
+    "mcp-client-for-ollama==0.18.2"
 ]
 
 [project.scripts]

mcp_client_for_ollama/__init__.py

@@ -1,3 +1,3 @@
 """MCP Client for Ollama package."""
 
-__version__ = "0.18.1"
+__version__ = "0.18.2"

mcp_client_for_ollama/server/connector.py

@@ -407,7 +407,7 @@ def _get_headers_from_server(self, server: Dict[str, Any]) -> Dict[str, str]:
             server: Server configuration dictionary
 
         Returns:
-            Dictionary of headers
+            Dictionary of headers with lowercase keys
         """
         # Try to get headers directly from server dict
         headers = server.get("headers", {})
@@ -416,10 +416,13 @@ def _get_headers_from_server(self, server: Dict[str, Any]) -> Dict[str, str]:
         if not headers and "config" in server:
             headers = server["config"].get("headers", {})
 
+        # Normalize all header names to lowercase per RFC 7230
+        headers = {k.lower(): v for k, v in headers.items()}
+
         # Always add MCP Protocol Version header for HTTP connections
         server_type = server.get("type", "script")
         if server_type in ["sse", "streamable_http"]:
-            headers["MCP-Protocol-Version"] = MCP_PROTOCOL_VERSION
+            headers["mcp-protocol-version"] = MCP_PROTOCOL_VERSION
 
         return headers
 

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "mcp-client-for-ollama"
-version = "0.18.1"
+version = "0.18.2"
 description = "MCP Client for Ollama - A client for connecting to Model Context Protocol servers using Ollama"
 readme = "README.md"
 requires-python = ">=3.10"

scripts/bump_version.py

@@ -25,16 +25,16 @@ def regenerate_uvlock(directory):
 def check_version_consistency(files):
     """Check if versions are consistent across all files."""
     versions = {}
-    
-    
+
+
     # Check pyproject.toml files
     for name, file_path in files.items():
         if "pyproject" in name and file_path.exists():
             try:
                 versions[str(file_path)] = read_version(file_path)
             except ValueError:
                 versions[str(file_path)] = "VERSION NOT FOUND"
-    
+
     # Check __init__.py files
     for name, file_path in files.items():
         if "init" in name and file_path.exists():
@@ -48,18 +48,18 @@ def check_version_consistency(files):
                     versions[str(file_path)] = "VERSION NOT FOUND"
             except Exception:
                 versions[str(file_path)] = "ERROR READING FILE"
-    
+
     # Check if all versions match
-    unique_versions = set(v for v in versions.values() 
+    unique_versions = set(v for v in versions.values()
                         if v not in ["VERSION NOT FOUND", "ERROR READING FILE"])
-    
+
     return unique_versions, versions
 
 def read_version(file_path):
     """Read the current version from a pyproject.toml file."""
     with open(file_path, 'r') as f:
         content = f.read()
-    
+
     # Use regex to find the version line
     match = re.search(r'version\s*=\s*"([^"]+)"', content)
     if match:
@@ -71,7 +71,7 @@ def read_version(file_path):
 def bump_version(version, bump_type):
     """Bump a version number based on semantic versioning."""
     major, minor, patch = map(int, version.split('.'))
-    
+
     if bump_type == 'major':
         major += 1
         minor = 0
@@ -81,23 +81,23 @@ def bump_version(version, bump_type):
         patch = 0
     else:  # patch
         patch += 1
-        
+
     return f"{major}.{minor}.{patch}"
 
 
 def update_version_in_file(file_path, new_version):
     """Update the version in a pyproject.toml file."""
     with open(file_path, 'r') as f:
         content = f.read()
-        
+
     # Replace version in the version line - using a lambda for safe replacement
     version_pattern = re.compile(r'(version\s*=\s*)"([^"]+)"')
     updated_content = version_pattern.sub(lambda m: f'{m.group(1)}"{new_version}"', content)
-    
+
     # Also update any dependency on the main package (for the CLI package)
     dep_pattern = re.compile(r'("mcp-client-for-ollama==)([^"]+)"')
     updated_content = dep_pattern.sub(lambda m: f'{m.group(1)}{new_version}"', updated_content)
-    
+
     with open(file_path, 'w') as f:
         f.write(updated_content)
 
@@ -107,41 +107,41 @@ def update_version_in_init(init_path, new_version):
     if os.path.exists(init_path):
         with open(init_path, 'r') as f:
             content = f.read()
-        
+
         # Replace version in __version__ = "x.y.z" - using lambda for safe replacement
         version_pattern = re.compile(r'(__version__\s*=\s*)"([^"]+)"')
         updated_content = version_pattern.sub(lambda m: f'{m.group(1)}"{new_version}"', content)
-        
+
         with open(init_path, 'w') as f:
             f.write(updated_content)
 
 
 def main():
     parser = argparse.ArgumentParser(description="Bump version for MCP Client for Ollama packages")
     parser.add_argument(
-        "bump_type", 
+        "bump_type",
         choices=["patch", "minor", "major", "custom"],
         help="The type of version bump to perform following semantic versioning, or 'custom' to specify a specific version"
     )
     parser.add_argument(
-        "--dry-run", 
+        "--dry-run",
         action="store_true",
         help="Show what would be done without making changes"
     )
     parser.add_argument(
-        "--version", 
+        "--version",
         help="Custom version to set when using the 'custom' bump type"
     )
     parser.add_argument(
-        "--force", 
+        "--force",
         action="store_true",
         help="Force version bump even if inconsistencies are detected"
     )
     args = parser.parse_args()
-    
+
     # Get repo root directory
-    repo_root = Path(__file__).parent.parent.absolute()    
-    
+    repo_root = Path(__file__).parent.parent.absolute()
+
     # Define paths
     files = {
         "main_pyproject": repo_root / "pyproject.toml",
@@ -153,28 +153,28 @@ def main():
      # Calculate and check versions for consistency
     print("Checking version consistency across files...")
     unique_versions, all_versions = check_version_consistency(files)
-    
+
     if len(unique_versions) > 1:
         print("\nWARNING: Version inconsistency detected!")
         print("The following files have different versions:")
         for file_path, version in all_versions.items():
             print(f"  - {file_path}: {version}")
-        
+
         if not args.force:
             print("\nOperation aborted. Use --force to proceed with version bump despite inconsistencies.")
             return
         print("\nProceeding with version bump despite inconsistencies (--force flag used).")
     else:
-        print("\nAll files have consistent versions.")        
+        print("\nAll files have consistent versions.")
 
     # Read current version from main package
     main_pyproject = repo_root / "pyproject.toml"
 
-    
+
     # Read current version
     current_version = read_version(main_pyproject)
     print(f"Current version: {current_version}")
-    
+
     # Calculate new version
     if args.bump_type == "custom":
         if not args.version:
@@ -185,20 +185,20 @@ def main():
             parser.error(f"Invalid version format: {new_version}. Expected format: X.Y.Z")
     else:
         new_version = bump_version(current_version, args.bump_type)
-    
+
     print(f"New version: {new_version}")
-    
+
     if args.dry_run:
         print("Dry run - no changes made.")
         return
-    
+
     # Update versions
     print(f"Updating main package version in {main_pyproject}")
     update_version_in_file(main_pyproject, new_version)
-    
+
     print(f"Updating CLI package version in {files['cli_pyproject']}")
     update_version_in_file(files['cli_pyproject'], new_version)
-    
+
     # Update __version__ in __init__.py files if they exist
     print(f"Checking for __init__.py files...")
     update_version_in_init(files['main_init'], new_version)
@@ -207,10 +207,12 @@ def main():
     # Regenerate uv.lock files
     print("Regenerating uv.lock files...")
     regenerate_uvlock(repo_root)
-    
+
     print(f"Version bump complete! {current_version} -> {new_version}")
     print("\nNext steps:")
-    print(f"1. Commit the changes: git commit -am \"Bump version to {new_version}\"")
+    print("1. Commit the changes:")
+    print("   git add -A")
+    print(f"   git commit -m 'chore(release): bump version to {new_version}'")
     print(f"2. Create a tag: git tag -a v{new_version} -m \"Version {new_version}\"")
     print("3. Push changes: git push && git push --tags")
     print("4. Build and publish the packages will be done automatically by CI/CD pipeline.")