server: fix startup error + misleading error message on port in use

- server: Misleading error message in httpsOnly mode fix #3722
- server: make sure server stop on startup error (exit main thread) fix #3723

Author: jknack

jooby/src/main/java/io/jooby/Jooby.java

@@ -1241,6 +1241,34 @@ public static void runApp(@NonNull String[] args, @NonNull Consumer<Jooby> consu
     runApp(args, ExecutionMode.DEFAULT, consumerProvider(consumer));
   }
 
+  /**
+   * Setup default environment, logging (logback or log4j2) and run application.
+   *
+   * @param args Application arguments.
+   * @param server Server to run.
+   * @param consumer Application consumer.
+   */
+  public static void runApp(
+      @NonNull String[] args, @NonNull Server server, @NonNull Consumer<Jooby> consumer) {
+    runApp(args, server, ExecutionMode.DEFAULT, consumer);
+  }
+
+  /**
+   * Setup default environment, logging (logback or log4j2) and run application.
+   *
+   * @param args Application arguments.
+   * @param server Server to run.
+   * @param consumer Application consumer.
+   */
+  public static void runApp(
+      @NonNull String[] args,
+      @NonNull Server server,
+      @NonNull ExecutionMode executionMode,
+      @NonNull Consumer<Jooby> consumer) {
+    configurePackage(consumer.getClass().getPackage());
+    runApp(args, server, executionMode, List.of(consumerProvider(consumer)));
+  }
+
   /**
    * Setup default environment, logging (logback or log4j2) and run application.
    *
@@ -1319,28 +1347,44 @@ public static void runApp(
       @NonNull Server server,
       @NonNull ExecutionMode executionMode,
       @NonNull List<Supplier<Jooby>> provider) {
+
     /* Dump command line as system properties. */
     parseArguments(args).forEach(System::setProperty);
     var apps = new ArrayList<Jooby>();
     var targetServer = server.getLoggerOff().isEmpty() ? server : MutedServer.mute(server);
-    for (var factory : provider) {
-      var app = createApp(executionMode, factory);
-      app.server = targetServer;
-      /*
-       When running a single app instance, there is no issue with server options, when multiple
-       apps set options a warning will be printed
-      */
-      var options = app.serverOptions;
-      if (options == null) {
-        options = ServerOptions.from(app.getConfig()).orElse(null);
+    try {
+      for (var factory : provider) {
+        var app = createApp(executionMode, factory);
+        app.server = targetServer;
+        /*
+         When running a single app instance, there is no issue with server options, when multiple
+         apps set options a warning will be printed
+        */
+        var options = app.serverOptions;
+        if (options == null) {
+          options = ServerOptions.from(app.getConfig()).orElse(null);
+        }
+        if (options != null) {
+          options.setServer(server.getName());
+          server.setOptions(options);
+        }
+        apps.add(app);
       }
-      if (options != null) {
-        options.setServer(server.getName());
-        server.setOptions(options);
+      targetServer.start(apps.toArray(new Jooby[0]));
+    } catch (Throwable t) {
+      if (targetServer != null) {
+        try {
+          targetServer.stop();
+        } catch (Exception ignore) {
+        }
       }
-      apps.add(app);
+      LoggerFactory.getLogger(Jooby.class)
+          .error("Application initialization resulted in exception", t);
+
+      throw t instanceof StartupException
+          ? (StartupException) t
+          : new StartupException("Application initialization resulted in exception", t);
     }
-    targetServer.start(apps.toArray(new Jooby[0]));
   }
 
   /**
@@ -1366,13 +1410,6 @@ public static Jooby createApp(
     try {
       BOOT_EXECUTION_MODE = executionMode;
       app = provider.get();
-    } catch (Throwable t) {
-      LoggerFactory.getLogger(Jooby.class)
-          .error("Application initialization resulted in exception", t);
-
-      throw t instanceof StartupException
-          ? (StartupException) t
-          : new StartupException("Application initialization resulted in exception", t);
     } finally {
       BOOT_EXECUTION_MODE = ExecutionMode.DEFAULT;
     }

jooby/src/main/java/io/jooby/ServerOptions.java

@@ -252,12 +252,12 @@ public int getPort() {
   }
 
   /**
-   * True when SSL is enabled. Either bc the secure port or SSL options are set.
+   * True when SSL is enabled. Either bc the secure port, httpsOnly or SSL options are set.
    *
-   * @return True when SSL is enabled. Either bc the secure port or SSL options are set.
+   * @return True when SSL is enabled. Either bc the secure port, httpsOnly or SSL options are set.
    */
   public boolean isSSLEnabled() {
-    return securePort != null || ssl != null;
+    return securePort != null || ssl != null || httpsOnly;
   }
 
   /**

modules/jooby-jetty/src/main/java/io/jooby/jetty/JettyServer.java

@@ -31,6 +31,7 @@
 import com.typesafe.config.Config;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import io.jooby.*;
+import io.jooby.exception.StartupException;
 import io.jooby.internal.jetty.JettyHandler;
 import io.jooby.internal.jetty.JettyHttpExpectAndContinueHandler;
 import io.jooby.internal.jetty.PrefixHandler;
@@ -94,6 +95,7 @@ public JettyServer configure(Consumer<HttpConfiguration> configurer) {
   public io.jooby.Server start(@NonNull Jooby... application) {
     // force options to be non-null
     var options = getOptions();
+    var portInUse = options.getPort();
     try {
       this.applications = List.of(application);
       /* Set max request size attribute: */
@@ -187,13 +189,13 @@ public io.jooby.Server start(@NonNull Jooby... application) {
                 acceptors,
                 selectors,
                 secureConnectionFactories.toArray(new ConnectionFactory[0]));
-        secureConnector.setPort(options.getSecurePort());
+        portInUse = options.getSecurePort();
+        secureConnector.setPort(portInUse);
         secureConnector.setHost(options.getHost());
 
         server.addConnector(secureConnector);
       } else if (options.isHttpsOnly()) {
-        throw new IllegalArgumentException(
-            "Server configured for httpsOnly, but ssl options not set");
+        throw new StartupException("Server configured for httpsOnly, but ssl options not set");
       }
 
       var context = new ContextHandler();
@@ -250,7 +252,7 @@ public io.jooby.Server start(@NonNull Jooby... application) {
       fireReady(applications);
     } catch (Exception x) {
       if (io.jooby.Server.isAddressInUse(x.getCause())) {
-        x = new BindException("Address already in use: " + options.getPort());
+        x = new BindException("Address already in use: " + portInUse);
       }
       throw SneakyThrows.propagate(x);
     }

modules/jooby-netty/src/main/java/io/jooby/netty/NettyServer.java

@@ -22,6 +22,7 @@
 import io.jooby.ServerOptions;
 import io.jooby.SneakyThrows;
 import io.jooby.SslOptions;
+import io.jooby.exception.StartupException;
 import io.jooby.internal.netty.*;
 import io.jooby.netty.buffer.NettyDataBufferFactory;
 import io.netty.bootstrap.ServerBootstrap;
@@ -109,6 +110,7 @@ public String getName() {
   public Server start(@NonNull Jooby... application) {
     // force options to be non-null
     var options = getOptions();
+    var portInUse = options.getPort();
     try {
       this.applications = List.of(application);
       boolean single = applications.size() == 1;
@@ -158,10 +160,10 @@ public Server start(@NonNull Jooby... application) {
         var https =
             newBootstrap(
                 allocator, transport, newPipeline(options, sslContext, dateService, http2));
-        https.bind(options.getHost(), options.getSecurePort()).get();
+        portInUse = options.getSecurePort();
+        https.bind(options.getHost(), portInUse).get();
       } else if (options.isHttpsOnly()) {
-        throw new IllegalArgumentException(
-            "Server configured for httpsOnly, but ssl options not set");
+        throw new StartupException("Server configured for httpsOnly, but ssl options not set");
       }
 
       fireReady(applications);
@@ -170,7 +172,7 @@ public Server start(@NonNull Jooby... application) {
     } catch (ExecutionException x) {
       var cause = x.getCause();
       if (Server.isAddressInUse(cause)) {
-        cause = new BindException("Address already in use: " + options.getPort());
+        cause = new BindException("Address already in use: " + portInUse);
       }
       throw SneakyThrows.propagate(cause);
     }

modules/jooby-undertow/src/main/java/io/jooby/undertow/UndertowServer.java

@@ -73,6 +73,7 @@ public String getName() {
   public @NonNull Server start(@NonNull Jooby... application) {
     // force options to be non-null
     var options = getOptions();
+    var portInUse = options.getPort();
     try {
       this.applications = List.of(application);
 
@@ -138,7 +139,8 @@ public String getName() {
       var classLoader = this.applications.get(0).getClassLoader();
       SSLContext sslContext = options.getSSLContext(classLoader);
       if (sslContext != null) {
-        builder.addHttpsListener(options.getSecurePort(), options.getHost(), sslContext);
+        portInUse = options.getSecurePort();
+        builder.addHttpsListener(portInUse, options.getHost(), sslContext);
         SslOptions ssl = options.getSsl();
         builder.setSocketOption(Options.SSL_ENABLED_PROTOCOLS, Sequence.of(ssl.getProtocol()));
         Optional.ofNullable(options.getSsl())
@@ -160,7 +162,7 @@ public String getName() {
       Throwable sourceException = x;
       Throwable cause = Optional.ofNullable(x.getCause()).orElse(x);
       if (Server.isAddressInUse(cause)) {
-        sourceException = new BindException("Address already in use: " + options.getPort());
+        sourceException = new BindException("Address already in use: " + portInUse);
       }
       throw SneakyThrows.propagate(sourceException);
     }
@@ -194,13 +196,13 @@ public synchronized Server stop() {
   }
 
   private void shutdownServer() {
-    if (server != null) {
-      try {
+    try {
+      if (server != null) {
         server.stop();
-      } finally {
-        shutdownWorker();
-        server = null;
       }
+    } finally {
+      shutdownWorker();
+      server = null;
     }
   }
 

tests/src/test/java/examples/PortInUse.java

@@ -0,0 +1,26 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package examples;
+
+import static io.jooby.Jooby.runApp;
+
+import io.jooby.Context;
+import io.jooby.ServerOptions;
+import io.jooby.jetty.JettyServer;
+
+public class PortInUse {
+  public static void main(String[] args) {
+    var options = new ServerOptions();
+    //    options.setHttpsOnly(true);
+    runApp(
+        args,
+        new JettyServer().setOptions(options),
+        app -> {
+          app.get("/", Context::getRequestPath);
+        });
+    System.out.println("Exited");
+  }
+}

tests/src/test/java/examples/PortInUse2.java

@@ -0,0 +1,26 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package examples;
+
+import static io.jooby.Jooby.runApp;
+
+import io.jooby.Context;
+import io.jooby.ServerOptions;
+import io.jooby.jetty.JettyServer;
+
+public class PortInUse2 {
+  public static void main(String[] args) {
+    var options = new ServerOptions();
+    //    options.setHttpsOnly(true);
+    runApp(
+        args,
+        new JettyServer().setOptions(options),
+        app -> {
+          app.get("/", Context::getRequestPath);
+        });
+    System.out.println("Exited");
+  }
+}