fix: apply copilot fixes

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: joshjohanning

scripts/create-app-jwt.sh

@@ -1,9 +1,32 @@
-#!/usr/bin/env bash
-
+#!/bin/bash
+
+# -----------------------------------------------------------------------------
+# Script to create a JWT (JSON Web Token) signed with a private RSA key.
+#
+# Usage:
+#   ./create-app-jwt.sh <client_id> <private_key_file>
+#
+# Arguments:
+#   <client_id>         The client ID to use as the JWT issuer (iss).
+#   <private_key_file>  Path to the PEM-encoded RSA private key file.
+#
+# Example:
+#   ./create-app-jwt.sh my-client-id /path/to/private-key.pem
+#
+# The script outputs the generated JWT to stdout.
+# -----------------------------------------------------------------------------
 set -o pipefail
+
+# Input validation for required parameters
+if [ -z "$1" ] || [ -z "$2" ]; then
+    echo "Error: Missing required parameters." >&2
+    echo "Usage: $0 <client_id> <path_to_private_key_pem>" >&2
+    exit 1
+fi
+
 client_id=$1 # Client ID as first argument
 
-pem=$( cat $2 ) # file path of the private key as second argument
+pem=$( cat "$2" ) # file path of the private key as second argument
 
 now=$(date +%s)
 iat=$((${now} - 60)) # Issues 60 seconds in the past

scripts/github-app-manifest-flow/create-github-app-from-manifest.sh

@@ -142,5 +142,5 @@ echo "Important: Save the client_secret, webhook_secret, and pem values securely
 echo "The pem field contains the full RSA private key for the app."
 echo "These credentials cannot be retrieved again through the API."
 echo ""
-echo "� Private key automatically saved to: $PEM_FILENAME"
+echo "🔑 Private key automatically saved to: $PEM_FILENAME"
 echo "💡 You can use this file for GitHub App authentication and JWT generation."