JSP `forward_to` and `include` support broken on Rails 5+

[chadlwilson]

At some point (long ago probably) the JSP forward_to support seems to have been broken, I think due to some rack 2.x changes where the monkey patch seems no longer reapplied to the correct Rack request object, or the request being wrapped when passed into the application and thus not being visible.

https://github.com/jruby/jruby-rack/blob/9b75601284d1a6dc30be228162358277e991f1ab/src/main/ruby/jruby/rack/rack_ext.rb

Before I dig into this further I wonder if @kares thinks either if these are worth keeping ... or we're better to drop these extensions and add back support if anyone asks for it on a maintained version.

[kares]

Never seen or heard these used, don't even remember that I ever tried these in an example.

or we're better to drop these extensions and add back support if anyone asks for it on a maintained version.

Think you make a good point, 👍 drop it (e.g. in 1.3.0) and see what happens... 🤷

[chadlwilson]

Yeah they are in the sinatra and rails examples in this repo which is why I discovered they seem to be broken - alongside my Rack 3 brute force testing 😅

[chadlwilson]

Hmm, this possibly is working OK on plain Rack apps; the issue seems to be on Rails the request is a pure ActionDispach::Request now - probably broken since Rails 5 in rails/rails@529136d#diff-60b77e427ea7ba142faa477fac10b8d0134cede4e35a3b1953c425200fadf1ac (which caused some other issues around the place here)

Now I'm not sure what to do since it "partially" works. :-)

[chadlwilson]

Could probably fix by monkey patching the rack request helpers (included by rails' request) instead of the rack request directly. If that "just works" I'll fix and keep it I guess?

[chadlwilson]

Seems to work fine for Rails 7 with that, so will double check Sinatra and if still working will PR to fix and move on.

Thanks for the rubber ducking 😅