Fix detection to allow simple this usage in fonctional components (fixes #576)

Author: yannickcr

lib/util/Components.js

@@ -424,11 +424,11 @@ function componentRule(rule, context) {
     },
 
     ThisExpression: function(node) {
-      node = utils.getParentComponent();
-      if (!node || !/Function/.test(node.type)) {
+      var component = utils.getParentComponent();
+      if (!component || !/Function/.test(component.type) || !node.parent.property) {
         return;
       }
-      // Ban functions with a ThisExpression
+      // Ban functions accessing a property on a ThisExpression
       components.add(node, 0);
     },
 

tests/lib/rules/no-multi-comp.js

@@ -61,20 +61,6 @@ ruleTester.run('no-multi-comp', rule, {
       '});'
     ].join('\r'),
     parserOptions: parserOptions
-  }, {
-    code: [
-      'export default {',
-      '  renderHello() {',
-      '    let {name} = this.props;',
-      '    return <div>{name}</div>;',
-      '  },',
-      '  renderHello2() {',
-      '    let {name2} = this.props;',
-      '    return <div>{name2}</div>;',
-      '  }',
-      '};'
-    ].join('\n'),
-    parser: 'babel-eslint'
   }, {
     code: [
       'function Hello(props) {',
@@ -179,5 +165,23 @@ ruleTester.run('no-multi-comp', rule, {
       message: 'Declare only one React component per file',
       line: 4
     }]
+  }, {
+    code: [
+      'export default {',
+      '  renderHello(props) {',
+      '    let {name} = props;',
+      '    return <div>{name}</div>;',
+      '  },',
+      '  renderHello2(props) {',
+      '    let {name} = props;',
+      '    return <div>{name}</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: [{
+      message: 'Declare only one React component per file',
+      line: 6
+    }]
   }]
 });