Add azure pipelines, remove python-jsonrpc-server (#58)

* re-add azure, make r conditional (for travis)

* update conda before creating env

* add pytest-timeout for cleaner exits on windows

* fix env name

* add -y to conda install

* try cargo-culting win line ending fix from unmerged upstream pr

* add r channel

* need r?

* linting

* some more cover skipping

* wait even longer

* try without posix path

* try string

* get rid of r channel

* add some debugging

* add some debugging

* more debugging

* try non-blocking

* add a little waiting

* clean up

* rewrite jsonrpc streams

* back to tornado queues

* close streams

* sleep in test

* don't worry about canceling sleep

* coverage

* clean up text handling

* 3.8 doesn't seem to fail on a canceled sleep

Author: bollwyvl

azure-pipelines.yml

@@ -0,0 +1,17 @@
+trigger:
+  batch: true
+  branches:
+    include:
+      - master
+      - refs/tags/v*
+
+pr:
+  - master
+
+variables:
+  PYTHONUNBUFFERED: 1
+  YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
+  JLSP_VERSION: 0.5.0
+
+jobs:
+  - template: ci/job.test.yml

ci/env-test.yml.in

@@ -0,0 +1,26 @@
+name: jupyterlab-lsp
+
+channels:
+  - conda-forge
+  - defaults
+
+dependencies:
+  # runtime dependencies
+  - python {}
+  - jupyterlab >=1.1,<1.2
+  # build dependencies
+  - nodejs
+  # for python language server (and development)
+  - flake8 >=3.5
+  - python-language-server
+  # for R language server and kernel
+  - r
+  - r-irkernel
+  - r-languageserver
+  - rpy2
+  # test tools
+  - pytest-asyncio
+  - pytest-azurepipelines
+  - pytest-cov
+  - pytest-flake8
+  - pytest-runner

ci/env_template.py

@@ -0,0 +1,6 @@
+from pathlib import Path
+import sys
+
+Path("..", "env-test.yml").write_text(
+    Path("env-test.yml.in").read_text().format(sys.argv[1])
+)

ci/job.test.yml

@@ -0,0 +1,86 @@
+parameters:
+  platforms:
+    - name: Linux
+      vmImage: ubuntu-16.04
+      activate: source activate
+    - name: MacOSX
+      vmImage: macos-10.13
+      activate: source activate
+    - name: Windows
+      vmImage: vs2017-win2016
+      activate: call activate
+  pythons:
+    - name: ThreeSix
+      spec: '>=3.6,<3.7.0a0'
+    - name: ThreeSeven
+      spec: '>=3.7,<3.8.0a0'
+
+jobs:
+  - ${{ each platform in parameters.platforms }}:
+      - ${{ each python in parameters.pythons}}:
+          - job: ${{ platform.name }}${{ python.name }}
+            pool:
+              vmImage: ${{ platform.vmImage }}
+            steps:
+              - ${{ if eq(platform.name, 'Linux') }}:
+                  - bash: echo "##vso[task.prependpath]$CONDA/bin"
+                    displayName: conda $PATH
+
+              - ${{ if eq(platform.name, 'MacOSX') }}:
+                  - bash: echo "##vso[task.prependpath]$CONDA/bin"
+                    displayName: conda $PATH
+
+                  - bash: sudo chown -R $USER $CONDA
+                    displayName: own conda
+
+              - ${{ if eq(platform.name, 'Windows') }}:
+                  - powershell: Write-Host "##vso[task.prependpath]$env:CONDA\Scripts"
+                    displayName: conda %PATH%
+
+              - script: conda install -yn base -c conda-forge conda python-libarchive-c
+                displayName: update conda
+
+              - script: ${{ platform.activate }} && cd ci && python env_template.py "${{ python.spec }}"
+                displayName: update environment with python version
+
+              - script: conda env update -n jupyterlab-lsp --file env-test.yml --quiet
+                displayName: update conda environment with test dependencies
+
+              - script: conda info && conda list -n jupyterlab-lsp
+                displayName: list conda packages and info
+
+              - task: CacheBeta@0
+                inputs:
+                  key: yarn | $(Agent.OS) | yarn.lock
+                  path: $(YARN_CACHE_FOLDER)
+                displayName: restore cached yarn packages
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && jlpm
+                displayName: install npm dependencies
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && jlpm build
+                displayName: build typescript
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && python setup.py sdist bdist_wheel
+                displayName: build python distributions
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && cd dist && npm pack ..
+                displayName: build npm bundle
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && cd dist && python -m pip install jupyter_lsp-$(JLSP_VERSION)-py3-none-any.whl --no-deps
+                displayName: install python wheel
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && jlpm tslint:check && jlpm test:jest
+                displayName: run frontend unit tests
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && jupyter serverextension list
+                displayName: list server extensions
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && python -m pytest --pyargs jupyter_lsp --cov jupyter_lsp --cov-report term-missing:skip-covered -p no:warnings --flake8 --cov-fail-under=100 -vv
+                displayName: run python tests
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && cd dist && jupyter labextension install krassowski-jupyterlab-lsp-$(JLSP_VERSION).tgz @krassowski/jupyterlab_go_to_definition
+                displayName: build lab
+
+              - script: ${{ platform.activate }} jupyterlab-lsp && jupyter labextension list
+                displayName: list labextensions

environment.yml

@@ -23,6 +23,7 @@ dependencies:
       - pyls-isort
       - pyls-mypy
   # for R language server and kernel
-  - rpy2
-  - r-languageserver
+  - r
   - r-irkernel
+  - r-languageserver
+  - rpy2

py_src/jupyter_lsp/README.md

@@ -1,7 +1,7 @@
 # jupyter-lsp
 
 > a Multi-[Language Server][language-server] WebSocket proxy for your Jupyter
-> `notebook` or `lab` server. For Python 3.5+, powered by [python-jsonrpc-server][].
+> `notebook` or `lab` server. For Python 3.5+.
 
 See the parent of this repository, [jupyterlab-lsp](../../README.md) for the
 reference client implementation for [JupyterLab][]
@@ -36,7 +36,6 @@ Don't see an implementation for the language server you want? You can
 
 [language-server]: https://microsoft.github.io/language-server-protocol/specification
 [jupyter-server-proxy]: https://github.com/jupyterhub/jupyter-server-proxy
-[python-jsonrpc-server]: https://github.com/palantir/python-jsonrpc-server
 [lsp-implementations]: https://microsoft.github.io/language-server-protocol/implementors/servers
 [jupyter-lsp]: https://github.com/krassowski/jupyterlab-lsp.git
 [jupyterlab]: https://github.com/jupyterlab/jupyterlab

py_src/jupyter_lsp/jsonrpc.py

@@ -1,4 +1,4 @@
-""" A configurable frontend for `python-jsonrpc-server`
+""" A configurable frontend for stdio-based Language Servers
 """
 import typing
 

py_src/jupyter_lsp/manager.py

@@ -0,0 +1,45 @@
+"""
+Derived from
+
+> https://github.com/rudolfwalter/pygdbmi/blob/0.7.4.2/pygdbmi/gdbcontroller.py
+> MIT License  https://github.com/rudolfwalter/pygdbmi/blob/master/LICENSE
+> Copyright (c) 2016 Chad Smith <grassfedcode <at> gmail.com>
+"""
+import os
+
+if os.name == "nt":  # pragma: no cover
+    import msvcrt
+    from ctypes import windll, byref, wintypes, WinError, POINTER
+    from ctypes.wintypes import HANDLE, DWORD, BOOL
+else:  # pragma: no cover
+    import fcntl
+
+
+def make_non_blocking(file_obj):  # pragma: no cover
+    """
+    make file object non-blocking
+
+    Windows doesn't have the fcntl module, but someone on
+    stack overflow supplied this code as an answer, and it works
+    http://stackoverflow.com/a/34504971/2893090
+    """
+
+    if os.name == "nt":
+        LPDWORD = POINTER(DWORD)
+        PIPE_NOWAIT = wintypes.DWORD(0x00000001)
+
+        SetNamedPipeHandleState = windll.kernel32.SetNamedPipeHandleState
+        SetNamedPipeHandleState.argtypes = [HANDLE, LPDWORD, LPDWORD, LPDWORD]
+        SetNamedPipeHandleState.restype = BOOL
+
+        h = msvcrt.get_osfhandle(file_obj.fileno())
+
+        res = windll.kernel32.SetNamedPipeHandleState(h, byref(PIPE_NOWAIT), None, None)
+        if res == 0:
+            raise ValueError(WinError())
+
+    else:
+        # Set the file status flag (F_SETFL) on the pipes to be non-blocking
+        # so we can attempt to read from a pipe with no new data without locking
+        # the program up
+        fcntl.fcntl(file_obj, fcntl.F_SETFL, os.O_NONBLOCK)