Merge pull request #73 from bollwyvl/fix/lab-settings-null

krassowski · web-flow · commit c78169344462 · 2019-10-27T19:50:10.000Z
Add an empty properties to settings schema
diff --git a/atest/00_Smoke.robot b/atest/00_Smoke.robot
@@ -1,6 +1,17 @@
 *** Settings ***
+Suite Setup       Set Screenshot Directory    ${OUTPUT DIR}${/}screenshots${/}smoke
 Resource          Keywords.robot
 
 *** Test Cases ***
 Smoke
     Capture Page Screenshot    00-splash.png
+
+Settings
+    [Setup]    Reset Application State
+    Lab Command    Advanced Settings Editor
+    Capture Page Screenshot    01-settings-all.png
+    ${sel} =    Set Variable    css:[data-id="@krassowski/jupyterlab-lsp:plugin"]
+    Wait Until Page Contains Element    ${sel}
+    Click Element    ${sel}
+    Wait Until Page Contains    System Defaults
+    Capture Page Screenshot    02-settings-lsp.png
diff --git a/schema/plugin.json b/schema/plugin.json
@@ -2,6 +2,7 @@
   "title": "Language Server",
   "description": "Language Server Protocol settings.",
   "type": "object",
+  "properties": {},
   "jupyter.lab.shortcuts": [
     {
       "command": "lsp:jump-to-definition-notebook",

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`"title": "Language Server",`
`3`	`3`	`"description": "Language Server Protocol settings.",`
`4`	`4`	`"type": "object",`
	`5`	`+ "properties": {},`
`5`	`6`	`"jupyter.lab.shortcuts": [`
`6`	`7`	`{`
`7`	`8`	`"command": "lsp:jump-to-definition-notebook",`