Skip to content

Commit f45ec3c

Browse files
committed
Migrate from lsp-editor-adapter to (stripped) lsp-ws-connection.
This allows us to: - remove some dependencies, especially conflicting COdeMirror versions - remove lots of unused code, since we got the adapter part rewritten - start customizing the connection behaviout to our liking
1 parent b60d765 commit f45ec3c

File tree

5 files changed

+9
-40
lines changed

5 files changed

+9
-40
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"eslint-plugin-prettier": "^3.0.1",
1111
"husky": "^3.0.9",
1212
"javascript-typescript-langserver": "^2.11.3",
13-
"jsonrpc-ws-proxy": "0.0.5",
1413
"lerna": "^3.13.2",
1514
"precise-commits": "^1.0.2",
1615
"prettier": "^1.18.2",

packages/jupyterlab-lsp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
},
4040
"dependencies": {
4141
"@krassowski/jupyterlab_go_to_definition": "^0.7.1",
42-
"lsp-editor-adapter": "0.0.10"
42+
"lsp-ws-connection": "~0.1.0"
4343
},
4444
"devDependencies": {
4545
"@babel/preset-env": "^7.4.3",

packages/jupyterlab-lsp/src/connection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
IPosition,
99
ITokenInfo,
1010
LspWsConnection
11-
} from 'lsp-editor-adapter';
11+
} from 'lsp-ws-connection';
1212
import { CompletionTriggerKind } from './lsp';
1313
import { until_ready } from './utils';
1414

packages/jupyterlab-lsp/src/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ import { IDocumentManager } from '@jupyterlab/docmanager';
1212
import { FileEditorJumper } from '@krassowski/jupyterlab_go_to_definition/lib/jumpers/fileeditor';
1313
import { NotebookJumper } from '@krassowski/jupyterlab_go_to_definition/lib/jumpers/notebook';
1414

15-
import 'codemirror/addon/hint/show-hint.css';
16-
import 'codemirror/addon/hint/show-hint';
15+
// TODO: make use of it for jump target selection (requires to be added to package.json)?
16+
// import 'codemirror/addon/hint/show-hint.css';
17+
// import 'codemirror/addon/hint/show-hint';
1718
import '../style/index.css';
1819

19-
import 'lsp-editor-adapter/lib/codemirror-lsp.css';
2020
import { ICompletionManager } from '@jupyterlab/completer';
2121
import { IRenderMimeRegistry } from '@jupyterlab/rendermime';
2222
import { NotebookAdapter } from './adapters/jupyterlab/notebook';

yarn.lock

Lines changed: 4 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -2142,13 +2142,6 @@
21422142
"@phosphor/signaling" "^1.3.1"
21432143
"@phosphor/virtualdom" "^1.2.0"
21442144

2145-
"@sourcegraph/vscode-ws-jsonrpc@0.0.3-fork":
2146-
version "0.0.3-fork"
2147-
resolved "https://registry.yarnpkg.com/@sourcegraph/vscode-ws-jsonrpc/-/vscode-ws-jsonrpc-0.0.3-fork.tgz#83728a14616ef0587298e7849d960b61853a9954"
2148-
integrity sha512-EJLq/ni66glk3xYyOZtUIEbjTCw8kMI6RvO0YQtPd+4um2+aTSM1LfN4NrsiVrRkG7EG/U2OkFlKqT8mGo6w4Q==
2149-
dependencies:
2150-
vscode-jsonrpc "^4.0.0"
2151-
21522145
"@types/babel__core@^7.1.0":
21532146
version "7.1.3"
21542147
resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.1.3.tgz#e441ea7df63cd080dfcd02ab199e6d16a735fc30"
@@ -5718,16 +5711,6 @@ jsonparse@^1.2.0:
57185711
resolved "https://registry.yarnpkg.com/jsonparse/-/jsonparse-1.3.1.tgz#3f4dae4a91fac315f71062f8521cc239f1366280"
57195712
integrity sha1-P02uSpH6wxX3EGL4UhzCOfE2YoA=
57205713

5721-
jsonrpc-ws-proxy@0.0.5:
5722-
version "0.0.5"
5723-
resolved "https://registry.yarnpkg.com/jsonrpc-ws-proxy/-/jsonrpc-ws-proxy-0.0.5.tgz#e77c4fb4cbeda51a3865eb6314f8deafa8103655"
5724-
integrity sha512-Gz3Njkc4LdJ+wEtrgG5acZWKTH78kYRHCYwN/QKzoJjdQw1jEepwkWTXLRa3JifcIpxh+WjA6OJw8A8RvejzXw==
5725-
dependencies:
5726-
"@sourcegraph/vscode-ws-jsonrpc" "0.0.3-fork"
5727-
js-yaml "^3.12.0"
5728-
minimist "^1.2.0"
5729-
ws "^6.1.0"
5730-
57315714
jsprim@^1.2.2:
57325715
version "1.4.1"
57335716
resolved "https://registry.yarnpkg.com/jsprim/-/jsprim-1.4.1.tgz#313e66bc1e5cc06e438bc1b7499c2e5c56acb6a2"
@@ -5868,11 +5851,6 @@ locate-path@^5.0.0:
58685851
dependencies:
58695852
p-locate "^4.1.0"
58705853

5871-
lodash-es@^4.17.11:
5872-
version "4.17.15"
5873-
resolved "https://registry.yarnpkg.com/lodash-es/-/lodash-es-4.17.15.tgz#21bd96839354412f23d7a10340e5eac6ee455d78"
5874-
integrity sha512-rlrc3yU3+JNOpZ9zj5pQtxnx2THmvRykwL4Xlxoa8I9lHBlVbbyPhgyPMioxVZ4NqyxaVVtaJnzsyOidQIhyyQ==
5875-
58765854
lodash._reinterpolate@^3.0.0:
58775855
version "3.0.0"
58785856
resolved "https://registry.yarnpkg.com/lodash._reinterpolate/-/lodash._reinterpolate-3.0.0.tgz#0ccf2d89166af03b3663c796538b75ac6e114d9d"
@@ -6005,12 +5983,11 @@ lru-cache@^5.1.1:
60055983
dependencies:
60065984
yallist "^3.0.2"
60075985

6008-
lsp-editor-adapter@0.0.10:
6009-
version "0.0.10"
6010-
resolved "https://registry.yarnpkg.com/lsp-editor-adapter/-/lsp-editor-adapter-0.0.10.tgz#eaaa89e46c71e6856de11fe8cf403b0fbd15c08c"
6011-
integrity sha512-jfAQoakF/K2S0hpN4kQZWRH44Wu7UX0OqJGoUEcm52pBkQxKtCgmRC4EusRHX/wgzDCAJc8zi5fBwYlcqEjwBg==
5986+
lsp-ws-connection@~0.1.0:
5987+
version "0.1.0"
5988+
resolved "https://registry.yarnpkg.com/lsp-ws-connection/-/lsp-ws-connection-0.1.0.tgz#a5587d47f7f804f5c3c3a84e743b2b227849d447"
5989+
integrity sha512-0vQcRxBHnDDJ7dx/8Gaijo3IYt+d0he5zyreFZtW2JV9KmqBUuNVtPbA85Iz3Nfj7QxrL0nnswZ/gttLStjD5Q==
60125990
dependencies:
6013-
lodash-es "^4.17.11"
60145991
vscode-jsonrpc "^4.0.0"
60155992
vscode-languageclient "^5.2.1"
60165993
vscode-languageserver-protocol "^3.14.1"
@@ -9994,13 +9971,6 @@ ws@^5.2.0:
99949971
dependencies:
99959972
async-limiter "~1.0.0"
99969973

9997-
ws@^6.1.0:
9998-
version "6.2.1"
9999-
resolved "https://registry.yarnpkg.com/ws/-/ws-6.2.1.tgz#442fdf0a47ed64f59b6a5d8ff130f4748ed524fb"
10000-
integrity sha512-GIyAXC2cB7LjvpgMt9EKS2ldqr0MTrORaleiOno6TweZ6r3TKtoFQWay/2PceJ3RuBasOHzXNn5Lrw1X0bEjqA==
10001-
dependencies:
10002-
async-limiter "~1.0.0"
10003-
100049974
ws@^7.0.0:
100059975
version "7.2.0"
100069976
resolved "https://registry.yarnpkg.com/ws/-/ws-7.2.0.tgz#422eda8c02a4b5dba7744ba66eebbd84bcef0ec7"

0 commit comments

Comments
 (0)