fix #16

Author: sp-yduck

cloud/scope/remote.go

@@ -28,7 +28,7 @@ func NewSSHClient(addr, user, password string) (*SSHClient, error) {
 	return &SSHClient{conn, password}, nil
 }
 
-func (conn *SSHClient) RunCommand(cmd string, stdin ...string) (string, error) {
+func (conn *SSHClient) RunCommand(cmd string) (string, error) {
 	session, err := conn.NewSession()
 	if err != nil {
 		return "", err

cloud/services/compute/instance/image.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"path"
+	"strings"
 
 	"github.com/pkg/errors"
 	"github.com/sp-yduck/proxmox/pkg/service/node/vm"
@@ -53,7 +54,19 @@ func SetCloudImage(ctx context.Context, vmid int, storage infrav1.Storage, image
 		return errors.Errorf("failed to download image: %s : %v", out, err)
 	}
 
-	// to do: should confirm if the checksum matchies
+	// checksum
+	if image.Checksum != "" {
+		cscmd, err := findValidChecksumCommand(*image.ChecksumType)
+		if err != nil {
+			return err
+		}
+		cmd := fmt.Sprintf("%s --check -", cscmd)
+		stdin := fmt.Sprintf("%s %s", image.Checksum, rawImageFilePath)
+		out, err = ssh.RunWithStdin(cmd, stdin)
+		if err != nil {
+			return errors.Errorf("failed to confirm checksum: %s : %v", out, err)
+		}
+	}
 
 	destPath := fmt.Sprintf("%s/images/%d/vm-%d-disk-0.raw", storage.Path, vmid, vmid)
 	out, err = ssh.RunCommand(fmt.Sprintf("/usr/bin/qemu-img convert -O raw %s %s", rawImageFilePath, destPath))
@@ -62,3 +75,15 @@ func SetCloudImage(ctx context.Context, vmid int, storage infrav1.Storage, image
 	}
 	return nil
 }
+
+func findValidChecksumCommand(csType string) (string, error) {
+	csType = strings.ToLower(csType)
+	switch csType {
+	case "sha256", "sha256sum":
+		return "sha256sum", nil
+	case "md5", "md5sum":
+		return "md5sum", nil
+	default:
+		return "", errors.Errorf("checksum type %s is not supported", csType)
+	}
+}

examples/machine_deployment/ubuntu2204.yaml

@@ -42,6 +42,8 @@ spec:
     spec:
       image:
         url: https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64-disk-kvm.img
+        checksum: 86e996f35732d26cd8b0888c46c4309d4d3b04eb6980378cf82b4d3eb2796549
+        checksumType: sha256
       cloudInit:
         user:
           packages:

templates/cluster-template.yaml

@@ -83,6 +83,8 @@ spec:
     spec:
       image:
         url: https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64-disk-kvm.img
+        checksum: 86e996f35732d26cd8b0888c46c4309d4d3b04eb6980378cf82b4d3eb2796549
+        checksumType: sha256
       hardware:
         cpu: 4
         memory: 8192