add validation for disk size

Author: sp-yduck

api/v1beta1/type.go

@@ -84,6 +84,7 @@ type Hardware struct {
 	// SCSIHardWare SCSIHardWare `json:"scsiHardWare,omitempty"`
 
 	// hard disk size
+	// +kubebuilder:validation:Pattern:=\+?\d+(\.\d+)?[KMGT]?
 	// +kubebuilder:default:="50G"
 	Disk string `json:"disk,omitempty"`
 }

cloud/scope/machine.go

@@ -178,7 +178,6 @@ func (m *MachineScope) GetHardware() infrav1.Hardware {
 	if m.ProxmoxMachine.Spec.Hardware.Memory == 0 {
 		m.ProxmoxMachine.Spec.Hardware.Memory = 4096
 	}
-	// to do: validation
 	if m.ProxmoxMachine.Spec.Hardware.Disk == "" {
 		m.ProxmoxMachine.Spec.Hardware.Disk = "50G"
 	}

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachines.yaml

@@ -119,6 +119,7 @@ spec:
                   disk:
                     default: 50G
                     description: hard disk size
+                    pattern: \+?\d+(\.\d+)?[KMGT]?
                     type: string
                   memory:
                     default: 4096

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachinetemplates.yaml

@@ -144,6 +144,7 @@ spec:
                           disk:
                             default: 50G
                             description: hard disk size
+                            pattern: \+?\d+(\.\d+)?[KMGT]?
                             type: string
                           memory:
                             default: 4096