Skip to content

Commit 4b86454

Browse files
committed
fix createQEMU()
1 parent eb18969 commit 4b86454

File tree

1 file changed

+4
-8
lines changed
  • cloud/services/compute/instance

1 file changed

+4
-8
lines changed

cloud/services/compute/instance/qemu.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func (s *Service) getQEMU(ctx context.Context, vmid *int) (*proxmox.VirtualMachi
4848
func (s *Service) createQEMU(ctx context.Context, nodeName string, vmid *int) (*proxmox.VirtualMachine, error) {
4949
log := log.FromContext(ctx)
5050

51-
// get nodej
51+
// get node
5252
if nodeName == "" {
5353
// temp solution
5454
node, err := s.getRandomNode()
@@ -60,9 +60,6 @@ func (s *Service) createQEMU(ctx context.Context, nodeName string, vmid *int) (*
6060
s.scope.SetNodeName(nodeName)
6161
}
6262

63-
// (for multiple node proxmox cluster support)
64-
// to do : set ssh client for specific node
65-
6663
// if vmid is empty, generate new vmid
6764
if vmid == nil {
6865
nextid, err := s.getNextID()
@@ -74,14 +71,13 @@ func (s *Service) createQEMU(ctx context.Context, nodeName string, vmid *int) (*
7471
}
7572

7673
vmoption := generateVMOptions(s.scope.Name(), s.scope.GetStorage().Name, s.scope.GetNetwork(), s.scope.GetHardware())
77-
// to do : do not use RESTClient()
78-
_, err := s.client.RESTClient().CreateVirtualMachine(ctx, nodeName, *vmid, vmoption)
74+
vm, err := s.client.CreateVirtualMachine(ctx, nodeName, *vmid, vmoption)
7975
if err != nil {
80-
log.Error(err, fmt.Sprintf("failed to get node %s", nodeName))
76+
log.Error(err, fmt.Sprintf("failed to create qemu instance %s", vm.VM.Name))
8177
return nil, err
8278
}
8379
s.scope.SetVMID(*vmid)
84-
return s.client.VirtualMachine(ctx, *vmid)
80+
return vm, nil
8581
}
8682

8783
func (s *Service) getNextID() (int, error) {

0 commit comments

Comments
 (0)