Merge pull request #71 from sp-yduck/testing

add test some cases

Author: sp-yduck

api/v1beta1/type.go

@@ -84,6 +84,7 @@ type Hardware struct {
 	// SCSIHardWare SCSIHardWare `json:"scsiHardWare,omitempty"`
 
 	// hard disk size
+	// +kubebuilder:validation:Pattern:=\+?\d+(\.\d+)?[KMGT]?
 	// +kubebuilder:default:="50G"
 	Disk string `json:"disk,omitempty"`
 }

cloud/cloudinit/common.go

@@ -24,7 +24,20 @@ runcmd:
   `
 	_, err := cloudinit.ParseUser(testYaml)
 	if err != nil {
-		t.Fatalf("failed to parse user: %v", err)
+		t.Errorf("failed to parse user: %v", err)
+	}
+
+	testYaml = `
+write_files:
+  - path: /run/kubeadm/kubeadm.yaml
+owner: root:root
+    permissions: '0640'
+    content: |
+      asdfasdfasdf
+  `
+	user, err := cloudinit.ParseUser(testYaml)
+	if err == nil {
+		t.Errorf("should returns an error. user=%v", *user)
 	}
 }
 

cloud/cloudinit/common_test.go

@@ -0,0 +1,39 @@
+package providerid
+
+import (
+	"testing"
+)
+
+func TestNew(t *testing.T) {
+	uuid := ""
+	providerID, err := New(uuid)
+	if err == nil {
+		t.Errorf("err should not be nil. providerID=%s", providerID)
+	}
+
+	uuid = "asdf"
+	providerID, err = New(uuid)
+	if err != nil {
+		t.Errorf("failed to create providerID: %v", err)
+	}
+}
+
+func TestUUID(t *testing.T) {
+	pid := providerID{
+		uuid: "asdf",
+	}
+	uuid := pid.UUID()
+	if uuid != "asdf" {
+		t.Errorf("should be asdf")
+	}
+}
+
+func TestString(t *testing.T) {
+	pid := providerID{
+		uuid: "asdf",
+	}
+	uuid := pid.String()
+	if uuid != Prefix+"asdf" {
+		t.Errorf("should be %sasdf", Prefix)
+	}
+}

cloud/cloudinit/user_test.go

@@ -38,7 +38,7 @@ func newComputeService(ctx context.Context, cluster *infrav1.ProxmoxCluster, crC
 	serverRef := cluster.Spec.ServerRef
 	secretRef := serverRef.SecretRef
 	if secretRef == nil {
-		return nil, errors.New("failed to get proxmox client form nil secretRef")
+		return nil, errors.New("failed to get proxmox client from nil secretRef")
 	}
 
 	var secret corev1.Secret

cloud/providerid/providerid_test.go

@@ -0,0 +1,68 @@
+package scope
+
+import (
+	"context"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/errors"
+
+	infrav1 "github.com/sp-yduck/cluster-api-provider-proxmox/api/v1beta1"
+)
+
+var _ = Describe("newComputeService", func() {
+	var (
+		cluster *infrav1.ProxmoxCluster
+	)
+
+	Context("When SecretRef is not present in ProxmoxCluster", func() {
+		BeforeEach(func() {
+			cluster = &infrav1.ProxmoxCluster{}
+		})
+		It("should return proper error", func() {
+			svc, err := newComputeService(context.TODO(), cluster, k8sClient)
+			Expect(err.Error()).To(Equal("failed to get proxmox client from nil secretRef"))
+			Expect(svc).To(BeNil())
+		})
+	})
+
+	Context("When Secret is not present", func() {
+		BeforeEach(func() {
+			cluster = &infrav1.ProxmoxCluster{}
+			cluster.Spec.ServerRef.SecretRef = &infrav1.ObjectReference{
+				Namespace: "default",
+				Name:      "foo",
+			}
+		})
+
+		It("should return proper error", func() {
+			svc, err := newComputeService(context.TODO(), cluster, k8sClient)
+			Expect(errors.IsNotFound(err)).To(BeTrue())
+			Expect(svc).To(BeNil())
+		})
+	})
+
+	Context("When Secret is empty", func() {
+		BeforeEach(func() {
+			cluster = &infrav1.ProxmoxCluster{}
+			cluster.Spec.ServerRef.SecretRef = &infrav1.ObjectReference{
+				Namespace: "default",
+				Name:      "foo",
+			}
+			cluster.SetName("foo")
+			cluster.SetUID("bar")
+			secret := &corev1.Secret{}
+			secret.SetNamespace("default")
+			secret.SetName("foo")
+			k8sClient.Create(context.TODO(), secret)
+		})
+
+		It("Should return proper error", func() {
+			svc, err := newComputeService(context.TODO(), cluster, k8sClient)
+			Expect(err.Error()).To(Equal("invalid authentication config"))
+			Expect(svc).To(BeNil())
+		})
+	})
+})

cloud/scope/clients.go

@@ -178,7 +178,6 @@ func (m *MachineScope) GetHardware() infrav1.Hardware {
 	if m.ProxmoxMachine.Spec.Hardware.Memory == 0 {
 		m.ProxmoxMachine.Spec.Hardware.Memory = 4096
 	}
-	// to do: validation
 	if m.ProxmoxMachine.Spec.Hardware.Disk == "" {
 		m.ProxmoxMachine.Spec.Hardware.Disk = "50G"
 	}

cloud/scope/clients_test.go

@@ -0,0 +1,64 @@
+package scope
+
+import (
+	// "os"
+	"path/filepath"
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	"k8s.io/client-go/kubernetes/scheme"
+	"k8s.io/client-go/rest"
+	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/envtest"
+	logf "sigs.k8s.io/controller-runtime/pkg/log"
+	"sigs.k8s.io/controller-runtime/pkg/log/zap"
+
+	infrav1 "github.com/sp-yduck/cluster-api-provider-proxmox/api/v1beta1"
+)
+
+var (
+	cfg             *rest.Config
+	k8sClient       client.Client
+	testEnv         *envtest.Environment
+	proxmoxUser     string
+	proxmoxPassword string
+)
+
+func TestScopes(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Scope Suite")
+}
+
+var _ = BeforeSuite(func() {
+	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
+
+	By("bootstrapping test environment")
+	testEnv = &envtest.Environment{
+		CRDDirectoryPaths:     []string{filepath.Join("..", "..", "config", "crd", "bases")},
+		ErrorIfCRDPathMissing: true,
+	}
+
+	var err error
+	// cfg is defined in this file globally.
+	cfg, err = testEnv.Start()
+	Expect(err).NotTo(HaveOccurred())
+	Expect(cfg).NotTo(BeNil())
+
+	Expect(clusterv1.AddToScheme(scheme.Scheme)).To(Succeed())
+	Expect(infrav1.AddToScheme(scheme.Scheme)).To(Succeed())
+
+	//+kubebuilder:scaffold:scheme
+
+	k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme})
+	Expect(err).NotTo(HaveOccurred())
+	Expect(k8sClient).NotTo(BeNil())
+})
+
+var _ = AfterSuite(func() {
+	By("tearing down the test environment")
+	err := testEnv.Stop()
+	Expect(err).NotTo(HaveOccurred())
+})

cloud/scope/machine.go

@@ -119,6 +119,7 @@ spec:
                   disk:
                     default: 50G
                     description: hard disk size
+                    pattern: \+?\d+(\.\d+)?[KMGT]?
                     type: string
                   memory:
                     default: 4096