add instance deletion logic

Author: sp-yduck

README.md

@@ -79,7 +79,7 @@ This project aims to follow the Cluster API [Provider contract](https://cluster-
 
 - [ ] Register virtual machine instance with Controlplane load balancer
 
-- [ ] Delete virtual machine instance
+- [x] Delete virtual machine instance
 
 - [ ] Un-register virtual machine instance with Controlplane load balancer
 

cloud/services/compute/instance/reconcile.go

@@ -169,16 +169,23 @@ func (s *Service) GetRandomNode() (*node.Node, error) {
 	return nodes[r.Intn(len(nodes))], nil
 }
 
-// wip
 func (s *Service) Delete(ctx context.Context) error {
+	log := log.FromContext(ctx)
+	log.Info("Deleting instance resources")
+
 	instance, err := s.GetInstance(ctx)
 	if err != nil {
 		if !IsNotFound(err) {
 			return err
 		}
 		return nil
 	}
-	// to do : stop instance before deletion
+
+	// must stop or pause instance before deletion
+	// otherwise deletion will be fail
+	if err := EnsureStoppedOrPaused(*instance); err != nil {
+		return err
+	}
 	return instance.Delete()
 }
 
@@ -249,11 +256,23 @@ func EnsureRunning(instance vm.VirtualMachine) error {
 			return err
 		}
 	default:
-		errors.Errorf("unexpected status : %s", instance.Status)
+		return errors.Errorf("unexpected status : %s", instance.Status)
 	}
 	return nil
 }
 
-// func EnsureStopped(instance vm.VirtualMachine) error {
-// 	return nil
-// }
+func EnsureStoppedOrPaused(instance vm.VirtualMachine) error {
+	switch instance.Status {
+	case vm.ProcessStatusRunning:
+		if err := instance.Stop(); err != nil {
+			return err
+		}
+	case vm.ProcessStatusPaused:
+		return nil
+	case vm.ProcessStatusStopped:
+		return nil
+	default:
+		return errors.Errorf("unexpected status : %s", instance.Status)
+	}
+	return nil
+}

controllers/proxmoxmachine_controller.go

@@ -183,7 +183,6 @@ func (r *ProxmoxMachineReconciler) reconcile(ctx context.Context, machineScope *
 	}
 }
 
-// wip
 func (r *ProxmoxMachineReconciler) reconcileDelete(ctx context.Context, machineScope *scope.MachineScope) (ctrl.Result, error) {
 	log := log.FromContext(ctx)
 	log.Info("Reconciling Delete ProxmoxMachine")