Skip to content

Commit 89ed099

Browse files
committed
Otel tracing interop test changes.
1 parent bdbcaf1 commit 89ed099

File tree

6 files changed

+25
-8
lines changed

6 files changed

+25
-8
lines changed

buildscripts/kokoro/psm-interop-build-java.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ readonly BUILD_APP_PATH="interop-testing/build/install/grpc-interop-testing"
3131
# Writes the output of xds-test-client and xds-test-server --help to stderr
3232
#######################################
3333
_build_java_test_app() {
34-
psm::tools::log "Building Java test app"
34+
echo "Building Java test app"
3535
cd "${SRC_DIR}"
3636

3737
set -x
@@ -40,9 +40,9 @@ _build_java_test_app() {
4040
-PskipCodegen=true -PskipAndroid=true --console=plain
4141
set +x
4242

43-
psm::tools::log "Test-run grpc-java PSM interop binaries"
44-
psm::tools::run_ignore_exit_code "${SRC_DIR}/${BUILD_APP_PATH}/bin/xds-test-client" --help
45-
psm::tools::run_ignore_exit_code "${SRC_DIR}/${BUILD_APP_PATH}/bin/xds-test-server" --help
43+
#echo "Test-run grpc-java PSM interop binaries"
44+
#psm::tools::run_ignore_exit_code "${SRC_DIR}/${BUILD_APP_PATH}/bin/xds-test-client" --help
45+
#psm::tools::run_ignore_exit_code "${SRC_DIR}/${BUILD_APP_PATH}/bin/xds-test-server" --help
4646
}
4747

4848
#######################################
@@ -62,7 +62,7 @@ psm::lang::build_docker_images() {
6262
local java_build_log="${BUILD_LOGS_ROOT}/build-lang-java.log"
6363
_build_java_test_app |& tee "${java_build_log}"
6464

65-
psm::tools::log "Building Java xDS interop test app Docker images"
65+
echo "Building Java xDS interop test app Docker images"
6666
local docker_dir="${SRC_DIR}/buildscripts/xds-k8s"
6767
local build_dir
6868
build_dir="$(mktemp -d)"

gcp-csm-observability/src/main/java/io/grpc/gcp/csm/observability/CsmObservability.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,11 @@ public Builder enableMetrics(Collection<String> enableMetrics) {
133133
return this;
134134
}
135135

136+
public Builder enableTracing() {
137+
delegate.enableTracing(true);
138+
return this;
139+
}
140+
136141
/**
137142
* Disables the specified metrics from being collected and exported.
138143
*/

interop-testing/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ plugins {
99

1010
description = "gRPC: Integration Testing"
1111

12+
def openTelemetryVersion = '1.56.0'
13+
def openTelemetryContribVersion = '1.52.0'
14+
1215
dependencies {
1316
implementation project(path: ':grpc-alts', configuration: 'shadow'),
1417
project(':grpc-auth'),
@@ -45,6 +48,9 @@ dependencies {
4548
project(':grpc-googleapis'),
4649
project(':grpc-grpclb'),
4750
project(':grpc-rls')
51+
runtimeOnly group: 'io.opentelemetry', name: 'opentelemetry-exporter-otlp', version: "${openTelemetryVersion}"
52+
runtimeOnly group: 'io.opentelemetry.contrib', name: 'opentelemetry-gcp-resources', version: "${openTelemetryContribVersion}-alpha"
53+
runtimeOnly group: 'io.opentelemetry.contrib', name: 'opentelemetry-gcp-auth-extension', version: "${openTelemetryContribVersion}-alpha"
4854
testImplementation testFixtures(project(':grpc-api')),
4955
testFixtures(project(':grpc-core')),
5056
project(':grpc-inprocess'),

interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,14 @@ private static RpcType parseRpc(String rpc) {
266266
private void run() {
267267
if (enableCsmObservability) {
268268
csmObservability = CsmObservability.newBuilder()
269+
.enableTracing()
269270
.sdk(AutoConfiguredOpenTelemetrySdk.builder()
270271
.addPropertiesSupplier(() -> ImmutableMap.of(
271272
"otel.logs.exporter", "none",
272273
"otel.metrics.exporter", "prometheus",
273-
"otel.traces.exporter", "none"))
274+
"otel.traces.exporter", "otlp",
275+
"otel.exporter.otlp.endpoint", "https://telemetry.googleapis.com",
276+
"otel.exporter.otlp.protocol", "http/protobuf"))
274277
.build()
275278
.getOpenTelemetrySdk())
276279
.build();

interop-testing/src/main/java/io/grpc/testing/integration/XdsTestServer.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,14 @@ void parseArgs(String[] args) {
198198
void start() throws Exception {
199199
if (enableCsmObservability) {
200200
csmObservability = CsmObservability.newBuilder()
201+
.enableTracing()
201202
.sdk(AutoConfiguredOpenTelemetrySdk.builder()
202203
.addPropertiesSupplier(() -> ImmutableMap.of(
203204
"otel.logs.exporter", "none",
204205
"otel.metrics.exporter", "prometheus",
205-
"otel.traces.exporter", "none"))
206+
"otel.traces.exporter", "otlp",
207+
"otel.exporter.otlp.endpoint", "https://telemetry.googleapis.com",
208+
"otel.exporter.otlp.protocol", "http/protobuf"))
206209
.build()
207210
.getOpenTelemetrySdk())
208211
.build();

opentelemetry/src/main/java/io/grpc/opentelemetry/GrpcOpenTelemetry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ public Builder disableAllMetrics() {
416416
return this;
417417
}
418418

419-
Builder enableTracing(boolean enable) {
419+
public Builder enableTracing(boolean enable) {
420420
ENABLE_OTEL_TRACING = enable;
421421
return this;
422422
}

0 commit comments

Comments
 (0)