Skip to content

Filter functionality improvements  #10

@undefined-box

Description

@undefined-box

The search filter currently makes a new parameterized call to the API via the cryptocurrency id, causing this issues:

  • Unnecessary API calls:
    the application already fetches all results, it should not be necessary to make a new call upon search if the intent is to filter them

  • Can display only one result:
    The user must specify the exact id of the cryptocurrency to be recovered, so the filter cannot show more than one result at a time

This could be fixed by storing the total results in the app state and displaying filtered results if needed; since the data is managed locally, the application can easily manipulate it, for example allowing the user to show all results that contain a given substring.

I can submit a PR if this looks ok for you :)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions